* [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting
@ 2018-05-09 5:39 Shawn Guo
2018-05-09 5:39 ` [PATCH 2/9] PCI: imx6: " Shawn Guo
` (7 more replies)
0 siblings, 8 replies; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 5:39 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Guo, Jingoo Han
The root_bus_nr initialization has already been done in function
dw_pcie_host_init(). The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed. Drop it.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
---
drivers/pci/dwc/pci-exynos.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/dwc/pci-exynos.c b/drivers/pci/dwc/pci-exynos.c
index 4cc1e5df8c79..cee5f2f590e2 100644
--- a/drivers/pci/dwc/pci-exynos.c
+++ b/drivers/pci/dwc/pci-exynos.c
@@ -421,7 +421,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,
}
}
- pp->root_bus_nr = -1;
pp->ops = &exynos_pcie_host_ops;
ret = dw_pcie_host_init(pp);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/9] PCI: imx6: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
@ 2018-05-09 5:39 ` Shawn Guo
2018-05-09 5:39 ` [PATCH 3/9] PCI: keystone: " Shawn Guo
` (6 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 5:39 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Guo, Richard Zhu, Lucas Stach
The root_bus_nr initialization has already been done in function
dw_pcie_host_init(). The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed. Drop it.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
---
drivers/pci/dwc/pci-imx6.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/dwc/pci-imx6.c b/drivers/pci/dwc/pci-imx6.c
index 4818ef875f8a..f330e322c1e7 100644
--- a/drivers/pci/dwc/pci-imx6.c
+++ b/drivers/pci/dwc/pci-imx6.c
@@ -667,7 +667,6 @@ static int imx6_add_pcie_port(struct imx6_pcie *imx6_pcie,
}
}
- pp->root_bus_nr = -1;
pp->ops = &imx6_pcie_host_ops;
ret = dw_pcie_host_init(pp);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/9] PCI: keystone: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
2018-05-09 5:39 ` [PATCH 2/9] PCI: imx6: " Shawn Guo
@ 2018-05-09 5:39 ` Shawn Guo
2018-05-09 5:39 ` [PATCH 4/9] PCI: armada8k: " Shawn Guo
` (5 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 5:39 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Guo, Murali Karicheri
The root_bus_nr initialization has already been done in function
dw_pcie_host_init(). The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed. Drop it.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Murali Karicheri <m-karicheri2@ti.com>
---
drivers/pci/dwc/pci-keystone.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/dwc/pci-keystone.c b/drivers/pci/dwc/pci-keystone.c
index d55ae0716adf..6ca80a21969e 100644
--- a/drivers/pci/dwc/pci-keystone.c
+++ b/drivers/pci/dwc/pci-keystone.c
@@ -347,7 +347,6 @@ static int __init ks_add_pcie_port(struct keystone_pcie *ks_pcie,
}
}
- pp->root_bus_nr = -1;
pp->ops = &keystone_pcie_host_ops;
ret = ks_dw_pcie_host_init(ks_pcie, ks_pcie->msi_intc_np);
if (ret) {
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 4/9] PCI: armada8k: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
2018-05-09 5:39 ` [PATCH 2/9] PCI: imx6: " Shawn Guo
2018-05-09 5:39 ` [PATCH 3/9] PCI: keystone: " Shawn Guo
@ 2018-05-09 5:39 ` Shawn Guo
2018-05-09 7:29 ` Thomas Petazzoni
2018-05-09 5:39 ` [PATCH 5/9] PCI: artpec6: " Shawn Guo
` (4 subsequent siblings)
7 siblings, 1 reply; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 5:39 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Guo, Thomas Petazzoni
The root_bus_nr initialization has already been done in function
dw_pcie_host_init(). The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed. Drop it.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
drivers/pci/dwc/pcie-armada8k.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/dwc/pcie-armada8k.c b/drivers/pci/dwc/pcie-armada8k.c
index b587352f8b9f..2d8eb88fd4f8 100644
--- a/drivers/pci/dwc/pcie-armada8k.c
+++ b/drivers/pci/dwc/pcie-armada8k.c
@@ -171,7 +171,6 @@ static int armada8k_add_pcie_port(struct armada8k_pcie *pcie,
struct device *dev = &pdev->dev;
int ret;
- pp->root_bus_nr = -1;
pp->ops = &armada8k_pcie_host_ops;
pp->irq = platform_get_irq(pdev, 0);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 5/9] PCI: artpec6: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
` (2 preceding siblings ...)
2018-05-09 5:39 ` [PATCH 4/9] PCI: armada8k: " Shawn Guo
@ 2018-05-09 5:39 ` Shawn Guo
2018-05-09 5:39 ` [PATCH 6/9] PCI: designware-plat: " Shawn Guo
` (3 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 5:39 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Guo, Jesper Nilsson
The root_bus_nr initialization has already been done in function
dw_pcie_host_init(). The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed. Drop it.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
---
drivers/pci/dwc/pcie-artpec6.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
index e66cede2b5b7..af78b5c23bce 100644
--- a/drivers/pci/dwc/pcie-artpec6.c
+++ b/drivers/pci/dwc/pcie-artpec6.c
@@ -399,7 +399,6 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
}
}
- pp->root_bus_nr = -1;
pp->ops = &artpec6_pcie_host_ops;
ret = dw_pcie_host_init(pp);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 6/9] PCI: designware-plat: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
` (3 preceding siblings ...)
2018-05-09 5:39 ` [PATCH 5/9] PCI: artpec6: " Shawn Guo
@ 2018-05-09 5:39 ` Shawn Guo
2018-05-09 5:39 ` [PATCH 7/9] PCI: histb: " Shawn Guo
` (2 subsequent siblings)
7 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 5:39 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Guo, Joao Pinto
The root_bus_nr initialization has already been done in function
dw_pcie_host_init(). The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed. Drop it.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>
---
drivers/pci/dwc/pcie-designware-plat.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/dwc/pcie-designware-plat.c b/drivers/pci/dwc/pcie-designware-plat.c
index 5416aa8a07a5..6e39afefd6db 100644
--- a/drivers/pci/dwc/pcie-designware-plat.c
+++ b/drivers/pci/dwc/pcie-designware-plat.c
@@ -58,7 +58,6 @@ static int dw_plat_add_pcie_port(struct pcie_port *pp,
return pp->msi_irq;
}
- pp->root_bus_nr = -1;
pp->ops = &dw_plat_pcie_host_ops;
ret = dw_pcie_host_init(pp);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 7/9] PCI: histb: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
` (4 preceding siblings ...)
2018-05-09 5:39 ` [PATCH 6/9] PCI: designware-plat: " Shawn Guo
@ 2018-05-09 5:39 ` Shawn Guo
2018-05-09 5:39 ` [PATCH 8/9] PCI: qcom: " Shawn Guo
2018-05-09 5:39 ` [PATCH 9/9] PCI: spear13xx: " Shawn Guo
7 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 5:39 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Guo, Jianguo Sun
The root_bus_nr initialization has already been done in function
dw_pcie_host_init(). The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed. Drop it.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Jianguo Sun <sunjianguo1@huawei.com>
---
drivers/pci/dwc/pcie-histb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/dwc/pcie-histb.c b/drivers/pci/dwc/pcie-histb.c
index 3611d6ce9a92..7b32e619b959 100644
--- a/drivers/pci/dwc/pcie-histb.c
+++ b/drivers/pci/dwc/pcie-histb.c
@@ -420,7 +420,6 @@ static int histb_pcie_probe(struct platform_device *pdev)
phy_init(hipcie->phy);
}
- pp->root_bus_nr = -1;
pp->ops = &histb_pcie_host_ops;
platform_set_drvdata(pdev, hipcie);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 8/9] PCI: qcom: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
` (5 preceding siblings ...)
2018-05-09 5:39 ` [PATCH 7/9] PCI: histb: " Shawn Guo
@ 2018-05-09 5:39 ` Shawn Guo
2018-05-09 15:46 ` Stanimir Varbanov
2018-05-09 5:39 ` [PATCH 9/9] PCI: spear13xx: " Shawn Guo
7 siblings, 1 reply; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 5:39 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Guo, Stanimir Varbanov
The root_bus_nr initialization has already been done in function
dw_pcie_host_init(). The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed. Drop it.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
---
drivers/pci/dwc/pcie-qcom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
index 5897af7d3355..a32aa024e907 100644
--- a/drivers/pci/dwc/pcie-qcom.c
+++ b/drivers/pci/dwc/pcie-qcom.c
@@ -1247,7 +1247,6 @@ static int qcom_pcie_probe(struct platform_device *pdev)
if (ret)
return ret;
- pp->root_bus_nr = -1;
pp->ops = &qcom_pcie_dw_ops;
if (IS_ENABLED(CONFIG_PCI_MSI)) {
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 9/9] PCI: spear13xx: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
` (6 preceding siblings ...)
2018-05-09 5:39 ` [PATCH 8/9] PCI: qcom: " Shawn Guo
@ 2018-05-09 5:39 ` Shawn Guo
7 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 5:39 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, Shawn Guo, Pratyush Anand
The root_bus_nr initialization has already been done in function
dw_pcie_host_init(). The -1 assignment in platform driver before
calling into dw_pcie_host_init() is not really needed. Drop it.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Cc: Pratyush Anand <pratyush.anand@gmail.com>
---
drivers/pci/dwc/pcie-spear13xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/dwc/pcie-spear13xx.c b/drivers/pci/dwc/pcie-spear13xx.c
index ecb58f7b7566..7d0cdfd8138b 100644
--- a/drivers/pci/dwc/pcie-spear13xx.c
+++ b/drivers/pci/dwc/pcie-spear13xx.c
@@ -210,7 +210,6 @@ static int spear13xx_add_pcie_port(struct spear13xx_pcie *spear13xx_pcie,
return ret;
}
- pp->root_bus_nr = -1;
pp->ops = &spear13xx_pcie_host_ops;
ret = dw_pcie_host_init(pp);
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 4/9] PCI: armada8k: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 ` [PATCH 4/9] PCI: armada8k: " Shawn Guo
@ 2018-05-09 7:29 ` Thomas Petazzoni
2018-05-09 7:52 ` Shawn Guo
0 siblings, 1 reply; 12+ messages in thread
From: Thomas Petazzoni @ 2018-05-09 7:29 UTC (permalink / raw)
To: Shawn Guo; +Cc: Bjorn Helgaas, linux-pci, Thomas Petazzoni
Hello Shawn,
On Wed, 9 May 2018 13:39:41 +0800, Shawn Guo wrote:
> The root_bus_nr initialization has already been done in function
> dw_pcie_host_init().
The formulation "has already been done" makes me think it's been done
*before* pp->root_bus_nr = -1, which is not what happens. I believe a
better formulation here would be:
dw_pcie_host_init() already initializes the root_bus_nr field of
'struct pcie_port', so there is no need to initialize it prior to
calling dw_pcie_host_init().
> The -1 assignment in platform driver before
> calling into dw_pcie_host_init() is not really needed. Drop it.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Other than my comment on the commit log:
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 4/9] PCI: armada8k: Drop unnecessary root_bus_nr setting
2018-05-09 7:29 ` Thomas Petazzoni
@ 2018-05-09 7:52 ` Shawn Guo
0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-05-09 7:52 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Bjorn Helgaas, linux-pci, Thomas Petazzoni
On Wed, May 09, 2018 at 09:29:25AM +0200, Thomas Petazzoni wrote:
> Hello Shawn,
>
> On Wed, 9 May 2018 13:39:41 +0800, Shawn Guo wrote:
> > The root_bus_nr initialization has already been done in function
> > dw_pcie_host_init().
>
> The formulation "has already been done" makes me think it's been done
> *before* pp->root_bus_nr = -1, which is not what happens. I believe a
> better formulation here would be:
>
> dw_pcie_host_init() already initializes the root_bus_nr field of
> 'struct pcie_port', so there is no need to initialize it prior to
> calling dw_pcie_host_init().
Yes, this is better. I will improve the commit log as suggested.
Thanks.
>
> > The -1 assignment in platform driver before
> > calling into dw_pcie_host_init() is not really needed. Drop it.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> Other than my comment on the commit log:
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thanks.
Shawn
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 8/9] PCI: qcom: Drop unnecessary root_bus_nr setting
2018-05-09 5:39 ` [PATCH 8/9] PCI: qcom: " Shawn Guo
@ 2018-05-09 15:46 ` Stanimir Varbanov
0 siblings, 0 replies; 12+ messages in thread
From: Stanimir Varbanov @ 2018-05-09 15:46 UTC (permalink / raw)
To: Shawn Guo, Bjorn Helgaas; +Cc: linux-pci
Hi Shawn,
Thanks for the patch!
On 05/09/2018 08:39 AM, Shawn Guo wrote:
> The root_bus_nr initialization has already been done in function
> dw_pcie_host_init(). The -1 assignment in platform driver before
> calling into dw_pcie_host_init() is not really needed. Drop it.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>
> ---
> drivers/pci/dwc/pcie-qcom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 5897af7d3355..a32aa024e907 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -1247,7 +1247,6 @@ static int qcom_pcie_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - pp->root_bus_nr = -1;
> pp->ops = &qcom_pcie_dw_ops;
>
> if (IS_ENABLED(CONFIG_PCI_MSI)) {
>
Acked-by: Stanimir Varbanov <svarbanov@mm-sol.com>
--
regards,
Stan
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-05-09 15:46 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 5:39 [PATCH 1/9] PCI: exynos: Drop unnecessary root_bus_nr setting Shawn Guo
2018-05-09 5:39 ` [PATCH 2/9] PCI: imx6: " Shawn Guo
2018-05-09 5:39 ` [PATCH 3/9] PCI: keystone: " Shawn Guo
2018-05-09 5:39 ` [PATCH 4/9] PCI: armada8k: " Shawn Guo
2018-05-09 7:29 ` Thomas Petazzoni
2018-05-09 7:52 ` Shawn Guo
2018-05-09 5:39 ` [PATCH 5/9] PCI: artpec6: " Shawn Guo
2018-05-09 5:39 ` [PATCH 6/9] PCI: designware-plat: " Shawn Guo
2018-05-09 5:39 ` [PATCH 7/9] PCI: histb: " Shawn Guo
2018-05-09 5:39 ` [PATCH 8/9] PCI: qcom: " Shawn Guo
2018-05-09 15:46 ` Stanimir Varbanov
2018-05-09 5:39 ` [PATCH 9/9] PCI: spear13xx: " Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.