From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v3 1/5] drm/i915: Wrap tasklet_struct for abuse Date: Wed, 09 May 2018 14:51:56 +0100 Message-ID: <152587391627.8613.10312136071207898459@mail.alporthouse.com> References: <20180509120419.6733-1-chris@chris-wilson.co.uk> <87wowd9c5d.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id C46D06E859 for ; Wed, 9 May 2018 13:52:01 +0000 (UTC) In-Reply-To: <87wowd9c5d.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBNaWthIEt1b3BwYWxhICgyMDE4LTA1LTA5IDE0OjQ0OjMwKQo+IENocmlzIFdpbHNv biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPiB3cml0ZXM6Cj4gCj4gPiBJbiB0aGUgbmV4dCBm ZXcgcGF0Y2hlcywgd2Ugd2FudCB0byBhYnVzZSB0YXNrbGV0IHRvIGF2b2lkIGtzb2Z0aXJxZAo+ ID4gbGF0ZW5jeSBhbG9uZyBjcml0aWNhbCBwYXRocy4gVG8gbWFrZSB0aGF0IGFidXNlIGVhc2ls eSB0byBzd2FsbG93LAo+ID4gZmlyc3QgY29hdCB0aGUgdGFza2xldCBpbiBhIGxpdHRsZSBzeW50 YWN0aWMgc3VnYXIuCj4gPgo+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0Bj aHJpcy13aWxzb24uY28udWs+Cj4gPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGlu QGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMg ICAgICAgICAgICAgfCAgOCArLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5j ICAgICAgICAgICAgIHwgIDIgKy0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Rhc2ts ZXQuaCAgICAgICAgIHwgNzggKysrKysrKysrKysrKysrKysrKysrCj4gPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgICAgICB8IDExICsrLQo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Y19zdWJtaXNzaW9uLmMgfCAgOCArLS0KPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgICAgIHwgMTggKystLS0KPiA+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggICAgIHwgIDMgKy0KPiA+ICA3IGZpbGVz IGNoYW5nZWQsIDEwNCBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkKPiA+ICBjcmVhdGUg bW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV90YXNrbGV0LmgKPiA+Cj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+IGluZGV4IDg5YmY1ZDY3Y2I3NC4uOTg0ODFlMTUwZTYx IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ID4gQEAgLTMwNDMsOSArMzA0Myw5 IEBAIGk5MTVfZ2VtX3Jlc2V0X3ByZXBhcmVfZW5naW5lKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSkKPiA+ICAgICAgICAqIGNvbW1vbiBjYXNlIG9mIHJlY3Vyc2l2ZWx5IGJlaW5nIGNh bGxlZCBmcm9tIHNldC13ZWRnZWQgZnJvbSBpbnNpZGUKPiA+ICAgICAgICAqIGk5MTVfcmVzZXQu Cj4gPiAgICAgICAgKi8KPiA+IC0gICAgIGlmICghYXRvbWljX3JlYWQoJmVuZ2luZS0+ZXhlY2xp c3RzLnRhc2tsZXQuY291bnQpKQo+ID4gLSAgICAgICAgICAgICB0YXNrbGV0X2tpbGwoJmVuZ2lu ZS0+ZXhlY2xpc3RzLnRhc2tsZXQpOwo+ID4gLSAgICAgdGFza2xldF9kaXNhYmxlKCZlbmdpbmUt PmV4ZWNsaXN0cy50YXNrbGV0KTsKPiA+ICsgICAgIGlmIChpOTE1X3Rhc2tsZXRfaXNfZW5hYmxl ZCgmZW5naW5lLT5leGVjbGlzdHMudGFza2xldCkpCj4gPiArICAgICAgICAgICAgIGk5MTVfdGFz a2xldF9mbHVzaCgmZW5naW5lLT5leGVjbGlzdHMudGFza2xldCk7Cj4gPiArICAgICBpOTE1X3Rh c2tsZXRfZGlzYWJsZSgmZW5naW5lLT5leGVjbGlzdHMudGFza2xldCk7Cj4gPiAgCj4gPiAgICAg ICAvKgo+ID4gICAgICAgICogV2UncmUgdXNpbmcgd29ya2VyIHRvIHF1ZXVlIHByZWVtcHRpb24g cmVxdWVzdHMgZnJvbSB0aGUgdGFza2xldCBpbgo+ID4gQEAgLTMyNjUsNyArMzI2NSw3IEBAIHZv aWQgaTkxNV9nZW1fcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4g IAo+ID4gIHZvaWQgaTkxNV9nZW1fcmVzZXRfZmluaXNoX2VuZ2luZShzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpCj4gPiAgewo+ID4gLSAgICAgdGFza2xldF9lbmFibGUoJmVuZ2luZS0+ ZXhlY2xpc3RzLnRhc2tsZXQpOwo+ID4gKyAgICAgaTkxNV90YXNrbGV0X2VuYWJsZSgmZW5naW5l LT5leGVjbGlzdHMudGFza2xldCk7Cj4gPiAgICAgICBrdGhyZWFkX3VucGFyayhlbmdpbmUtPmJy ZWFkY3J1bWJzLnNpZ25hbGVyKTsKPiA+ICAKPiA+ICAgICAgIGludGVsX3VuY29yZV9mb3JjZXdh a2VfcHV0KGVuZ2luZS0+aTkxNSwgRk9SQ0VXQUtFX0FMTCk7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf aXJxLmMKPiA+IGluZGV4IGY5YmMzYWFhOTBkMC4uZjhhZmY1YTVhYTgzIDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4gQEAgLTE0NzcsNyArMTQ3Nyw3IEBAIGdlbjhfY3NfaXJx X2hhbmRsZXIoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLCB1MzIgaWlyKQo+ID4gICAg ICAgfQo+ID4gIAo+ID4gICAgICAgaWYgKHRhc2tsZXQpCj4gPiAtICAgICAgICAgICAgIHRhc2ts ZXRfaGlfc2NoZWR1bGUoJmV4ZWNsaXN0cy0+dGFza2xldCk7Cj4gPiArICAgICAgICAgICAgIGk5 MTVfdGFza2xldF9zY2hlZHVsZSgmZXhlY2xpc3RzLT50YXNrbGV0KTsKPiA+ICB9Cj4gPiAgCj4g PiAgc3RhdGljIHZvaWQgZ2VuOF9ndF9pcnFfYWNrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpp OTE1LAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdGFza2xldC5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV90YXNrbGV0LmgKPiA+IG5ldyBmaWxlIG1vZGUg MTAwNjQ0Cj4gPiBpbmRleCAwMDAwMDAwMDAwMDAuLmM5ZjQxYTVlYmI5MQo+ID4gLS0tIC9kZXYv bnVsbAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV90YXNrbGV0LmgKPiA+IEBA IC0wLDAgKzEsNzggQEAKPiA+ICsvKgo+ID4gKyAqIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBH UEwtMi4wCj4gPiArICoKPiA+ICsgKiBDb3B5cmlnaHQgwqkgMjAxOCBJbnRlbCBDb3Jwb3JhdGlv bgo+ID4gKyAqLwo+ID4gKwo+ID4gKyNpZm5kZWYgX0k5MTVfVEFTS0xFVF9IXwo+ID4gKyNkZWZp bmUgX0k5MTVfVEFTS0xFVF9IXwo+ID4gKwo+ID4gKyNpbmNsdWRlIDxsaW51eC9hdG9taWMuaD4K PiA+ICsjaW5jbHVkZSA8bGludXgvaW50ZXJydXB0Lmg+Cj4gPiArCj4gPiArLyoqCj4gPiArICog c3RydWN0IGk5MTVfdGFza2xldCAtIHdyYXBwZXIgYXJvdW5kIHRhc2tsZXRfc3RydWN0Cj4gPiAr ICoKPiA+ICsgKiBXZSB3YW50IHRvIGFidXNlIHRhc2tsZXRzIHNsaWdodGx5LCBzdWNoIGFzIGNh bGxpbmcgdGhlbSBkaXJlY3RseS4gSW4gc29tZQo+ID4gKyAqIGNhc2VzLCB0aGlzIHJlcXVpcmVz IHNvbWUgYXV4aWxpYXJ5IHRyYWNraW5nIHNvIHN1YmNsYXNzIHRoZSB0YXNrbGV0X3N0cnVjdAo+ ID4gKyAqIHNvIHRoYXQgd2UgaGF2ZSBhIGNlbnRyYWwgcGxhY2UgYW5kIGhlbHBlcnMuCj4gPiAr ICovCj4gPiArc3RydWN0IGk5MTVfdGFza2xldCB7Cj4gPiArICAgICBzdHJ1Y3QgdGFza2xldF9z dHJ1Y3QgYmFzZTsKPiA+ICt9Owo+ID4gKwo+ID4gK3N0YXRpYyBpbmxpbmUgdm9pZCBpOTE1X3Rh c2tsZXRfaW5pdChzdHJ1Y3QgaTkxNV90YXNrbGV0ICp0LAo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB2b2lkICgqZnVuYykodW5zaWduZWQgbG9uZyksCj4gPiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZGF0YSkKPiA+ICt7Cj4g PiArICAgICB0YXNrbGV0X2luaXQoJnQtPmJhc2UsIGZ1bmMsIGRhdGEpOwo+ID4gK30KPiA+ICsK PiA+ICtzdGF0aWMgaW5saW5lIGJvb2wgaTkxNV90YXNrbGV0X2lzX3NjaGVkdWxlZChjb25zdCBz dHJ1Y3QgaTkxNV90YXNrbGV0ICp0KQo+ID4gK3sKPiA+ICsgICAgIHJldHVybiB0ZXN0X2JpdChU QVNLTEVUX1NUQVRFX1NDSEVELCAmdC0+YmFzZS5zdGF0ZSk7Cj4gPiArfQo+ID4gKwo+ID4gK3N0 YXRpYyBpbmxpbmUgYm9vbCBpOTE1X3Rhc2tsZXRfaXNfbG9ja2VkKGNvbnN0IHN0cnVjdCBpOTE1 X3Rhc2tsZXQgKnQpCj4gCj4gd2h5IG5vdCBpc19ydW5uaW5nKCkgPwoKQmVjYXVzZSBJIGRpZG4n dCB3YW50IHRvIHJlc2VuZCB0aGUgc2VyaWVzIGltbWVkaWF0ZWx5LiBJdCdzIGNvbmZ1c2luZwpi ZWNhdXNlIGl0J3Mgc2V0IGJ5IHRhc2tsZXRfdHJ5bG9jayBhbmQgY2xlYXJlZCBieSB0YXNrbGV0 X3VubG9jay4KCj4gPiArICAgICByZXR1cm4gdGVzdF9iaXQoVEFTS0xFVF9TVEFURV9SVU4sICZ0 LT5iYXNlLnN0YXRlKTsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGlubGluZSBib29sIGk5MTVf dGFza2xldF9pc19lbmFibGVkKGNvbnN0IHN0cnVjdCBpOTE1X3Rhc2tsZXQgKnQpCj4gPiArewo+ ID4gKyAgICAgcmV0dXJuIGxpa2VseSghYXRvbWljX3JlYWQoJnQtPmJhc2UuY291bnQpKTsKPiAK PiBJIGFtIGNvbmNlcm5lZCB0aGF0IHdlIGJ1cnkgdGhlIHNpZ24gb2YgcmFjeSBuYXR1cmUgb3V0 IG9mIHNpZ2h0IGFuZAo+IHRoZW4gaXQgY29tZXMgYW5kIGJpdGVzIHVzLgoKT2gsIEkgd291bGRu J3Qgd29ycnkgYWJvdXQgdGhhdCwganVzdCB3YWl0IHVudGlsIHlvdSBzZWUgd2hhdCBjb21lcwps YXRlciA6LXAKCj4gPiArc3RhdGljIGlubGluZSB2b2lkIGk5MTVfdGFza2xldF9zZXRfZnVuYyhz dHJ1Y3QgaTkxNV90YXNrbGV0ICp0LAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdm9pZCAoKmZ1bmMpKHVuc2lnbmVkIGxvbmcgZGF0YSksCj4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIGRhdGEpCj4gPiArewo+ ID4gKyAgICAgdGFza2xldF9kaXNhYmxlKCZ0LT5iYXNlKTsKPiAKPiBXaGF0IGRvZXMgdGhlIGRp c2FibGUvZW5hYmxlIHBhaXIgYnV5IHVzIGhlcmU/Cj4gCgpJIHdhcyB0aGlua2luZyBhYm91dCBi ZWluZyBjbGVhciBhYm91dCB0aGUgb3JkZXJpbmcuCgo+IEl0IGxvb2tzIHRoYXQgeW91IHdhbnQg dHJ5bG9jayBhbmQgdW5sb2NrCj4gc28gdGhhdCB5b3UgY2FuIHNhZmVseSBjaGFuZ2UgdGhlIGZ1 bmMvZGF0YS4KCkFzIHlvdSBwb2ludCBvdXQsIHRoZSBsb2NrIGlzIHRhc2tsZXRfZGlzYWJsZSwg dGhlIHRyeWxvY2sgaXMganVzdCBhCnRyeWxvY2suIEVtYnJhY2UgdGhlIGluc2FuaXR5LCBsZXQg aXQgZmxvdyB0aHJvdWdoIHlvdS4KLUNocmlzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=