All of lore.kernel.org
 help / color / mirror / Atom feed
From: <argus.lin@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>
Cc: Chenglin Xu <chenglin.xu@mediatek.com>,
	argus.lin@mediatek.com, Sean Wang <sean.wang@mediatek.com>,
	wsd_upstream@mediatek.com, henryc.chen@mediatek.com,
	flora.fu@mediatek.com, Chen Zhong <chen.zhong@mediatek.com>,
	Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
	Arvind Yadav <arvind.yadav.cs@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: [PATCH V5 2/4] soc: mediatek: pwrap: fix cipher init setting error
Date: Thu, 10 May 2018 21:01:57 +0800	[thread overview]
Message-ID: <1525957319-20557-3-git-send-email-argus.lin@mediatek.com> (raw)
In-Reply-To: <1525957319-20557-1-git-send-email-argus.lin@mediatek.com>


[-- Attachment #1.1: Type: text/html, Size: 2029 bytes --]

[-- Attachment #1.2: Type: text/plain, Size: 1063 bytes --]

From: Argus Lin <argus.lin@mediatek.com>

PWRAP_DEW_CIPHER_LOAD and PWRAP_DEW_CIPHER_START only exist at
PMIC_mt6397 datasheet. We fix it before merge PMIC_mt6351 driver.

Fixes: 5ae48040aa47 ("soc: mediatek: PMIC wrap: add mt6323 slave support")
---
 drivers/soc/mediatek/mtk-pmic-wrap.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index e9e054a..9a01e30 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1080,8 +1080,6 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
 	pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_SWRST], 0x0);
 	pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_KEY_SEL], 0x1);
 	pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_IV_SEL], 0x2);
-	pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_LOAD], 0x1);
-	pwrap_write(wrp, wrp->slave->dew_regs[PWRAP_DEW_CIPHER_START], 0x1);
 
 	switch (wrp->slave->type) {
 	case PMIC_MT6397:
-- 
1.8.1.1.dirty

  parent reply	other threads:[~2018-05-10 13:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 13:01 [PATCH V5 0/4] Pwrap: Mediatek pwrap driver for mt6797 argus.lin
2018-05-10 13:01 ` [PATCH V5 1/4] dt-bindings: pwrap: mediatek: add pwrap support for MT6797 argus.lin
2018-05-15  9:31   ` Matthias Brugger
2018-05-15  9:31     ` Matthias Brugger
2018-05-10 13:01 ` argus.lin [this message]
2018-05-11  9:26   ` [PATCH V5 2/4] soc: mediatek: pwrap: fix cipher init setting error Matthias Brugger
2018-05-11  9:26     ` Matthias Brugger
2018-05-15  9:50   ` Matthias Brugger
2018-05-15  9:50     ` Matthias Brugger
2018-05-10 13:01 ` [PATCH V5 3/4] soc: mediatek: pwrap: add pwrap driver for mt6797 SoCs argus.lin
2018-05-15  9:56   ` Matthias Brugger
2018-05-15  9:56     ` Matthias Brugger
2018-05-10 13:01 ` [PATCH V5 4/4] soc: mediatek: pwrap: add mt6351 " argus.lin
2018-06-08  7:39 [PATCH V5 0/4] Pwrap: Mediatek pwrap driver for mt6797 Argus Lin
2018-06-08  7:39 ` [PATCH V5 2/4] soc: mediatek: pwrap: fix cipher init setting error Argus Lin
2018-06-08  8:17 [PATCH V5 0/4] Pwrap: Mediatek pwrap driver for mt6797 Argus Lin
2018-06-08  8:17 ` [PATCH V5 2/4] soc: mediatek: pwrap: fix cipher init setting error Argus Lin
2018-06-11 10:49 [PATCH V5 0/4] Pwrap: Mediatek pwrap driver for mt6797 argus.lin-NuS5LvNUpcJWk0Htik3J/w
     [not found] ` <1528714200-2500-1-git-send-email-argus.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-06-11 10:49   ` [PATCH V5 2/4] soc: mediatek: pwrap: fix cipher init setting error argus.lin-NuS5LvNUpcJWk0Htik3J/w

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525957319-20557-3-git-send-email-argus.lin@mediatek.com \
    --to=argus.lin@mediatek.com \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=chen.zhong@mediatek.com \
    --cc=chenglin.xu@mediatek.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=devicetree@vger.kernel.org \
    --cc=flora.fu@mediatek.com \
    --cc=henryc.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@mediatek.com \
    --cc=will.deacon@arm.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.