From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.fireflyinternet.com ([109.228.58.192]:57694 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752507AbeEKH1p (ORCPT ); Fri, 11 May 2018 03:27:45 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Ezequiel Garcia , "Sumit Semwal" , "Gustavo Padovan" From: Chris Wilson In-Reply-To: <20180509201449.27452-1-ezequiel@collabora.com> Cc: kernel@collabora.com, "Ezequiel Garcia" , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org References: <20180509201449.27452-1-ezequiel@collabora.com> Message-ID: <152602366168.22269.11696001916463464983@mail.alporthouse.com> Subject: Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error Date: Fri, 11 May 2018 08:27:41 +0100 Sender: linux-media-owner@vger.kernel.org List-ID: Quoting Ezequiel Garcia (2018-05-09 21:14:49) > Change how dma_fence_add_callback() behaves, when the fence > has error-signaled by the time it is being add. After this commit, > dma_fence_add_callback() returns the fence error, if it > has error-signaled before dma_fence_add_callback() is called. Why? What problem are you trying to solve? fence->error does not imply that the fence has yet been signaled, and the caller wants a callback when it is signaled. -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error Date: Fri, 11 May 2018 08:27:41 +0100 Message-ID: <152602366168.22269.11696001916463464983@mail.alporthouse.com> References: <20180509201449.27452-1-ezequiel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9576C6F052 for ; Fri, 11 May 2018 07:27:48 +0000 (UTC) In-Reply-To: <20180509201449.27452-1-ezequiel@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sumit Semwal , Gustavo Padovan Cc: kernel@collabora.com, Ezequiel Garcia , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org UXVvdGluZyBFemVxdWllbCBHYXJjaWEgKDIwMTgtMDUtMDkgMjE6MTQ6NDkpCj4gQ2hhbmdlIGhv dyBkbWFfZmVuY2VfYWRkX2NhbGxiYWNrKCkgYmVoYXZlcywgd2hlbiB0aGUgZmVuY2UKPiBoYXMg ZXJyb3Itc2lnbmFsZWQgYnkgdGhlIHRpbWUgaXQgaXMgYmVpbmcgYWRkLiBBZnRlciB0aGlzIGNv bW1pdCwKPiBkbWFfZmVuY2VfYWRkX2NhbGxiYWNrKCkgcmV0dXJucyB0aGUgZmVuY2UgZXJyb3Is IGlmIGl0Cj4gaGFzIGVycm9yLXNpZ25hbGVkIGJlZm9yZSBkbWFfZmVuY2VfYWRkX2NhbGxiYWNr KCkgaXMgY2FsbGVkLgoKV2h5PyBXaGF0IHByb2JsZW0gYXJlIHlvdSB0cnlpbmcgdG8gc29sdmU/ IGZlbmNlLT5lcnJvciBkb2VzIG5vdCBpbXBseQp0aGF0IHRoZSBmZW5jZSBoYXMgeWV0IGJlZW4g c2lnbmFsZWQsIGFuZCB0aGUgY2FsbGVyIHdhbnRzIGEgY2FsbGJhY2sKd2hlbiBpdCBpcyBzaWdu YWxlZC4KLUNocmlzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=