From: Andy Green <andy@warmcat.com>
To: dev@dpdk.org
Subject: [PATCH v2 2/4] net/bnx2x: correct unmeetable comparison
Date: Sat, 12 May 2018 09:51:16 +0800 [thread overview]
Message-ID: <152608987682.121480.6298707358042668817.stgit@localhost.localdomain> (raw)
In-Reply-To: <152608979178.121480.7311972440076541560.stgit@localhost.localdomain>
/home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:
In function ‘elink_check_kr2_wa’:
/home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28:
error: bitwise comparison always evaluates to false
[-Werror=tautological-compare]
((next_page & 0xe0) == 0x2))));
This was fixed elsewhere in 2014
Signed-off-by: Andy Green <andy@warmcat.com>
Fixes: b5bf7719221d ("bnx2x: driver support routines")
Cc: stable@dpdk.org
---
drivers/net/bnx2x/elink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
index cceae6f9b..74e1bead3 100644
--- a/drivers/net/bnx2x/elink.c
+++ b/drivers/net/bnx2x/elink.c
@@ -12921,7 +12921,7 @@ static void elink_check_kr2_wa(struct elink_params *params,
*/
not_kr2_device = (((base_page & 0x8000) == 0) ||
(((base_page & 0x8000) &&
- ((next_page & 0xe0) == 0x2))));
+ ((next_page & 0xe0) == 0x20))));
/* In case KR2 is already disabled, check if we need to re-enable it */
if (!(vars->link_attr_sync & LINK_ATTR_SYNC_KR2_ENABLE)) {
next prev parent reply other threads:[~2018-05-12 1:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 1:51 [PATCH v2 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Andy Green
2018-05-12 1:51 ` [PATCH v2 1/4] net/bnx2x: do not cast function pointers as a policy Andy Green
2018-05-12 1:51 ` Andy Green [this message]
2018-05-12 1:51 ` [PATCH v2 3/4] net/mlx5: solve var may be used uninitialized Andy Green
2018-05-12 1:51 ` [PATCH v2 4/4] net/bnx2x: solve overruns Andy Green
2018-05-14 5:04 ` [PATCH v3 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Andy Green
2018-05-14 5:04 ` [PATCH v3 1/4] net/bnx2x: do not cast function pointers as a policy Andy Green
2018-05-15 19:47 ` Mody, Rasesh
2018-05-14 5:04 ` [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison Andy Green
2018-05-14 11:17 ` Ferruh Yigit
2018-05-14 22:17 ` Mody, Rasesh
2018-05-14 22:16 ` Mody, Rasesh
2018-05-15 14:46 ` Thomas Monjalon
2018-05-15 19:52 ` Mody, Rasesh
2018-05-14 5:04 ` [PATCH v3 3/4] net/mlx5: solve var may be used uninitialized Andy Green
2018-05-15 17:25 ` Yongseok Koh
2018-05-14 5:04 ` [PATCH v3 4/4] net/bnx2x: solve overruns Andy Green
2018-05-15 19:47 ` Mody, Rasesh
2018-05-15 20:30 ` [PATCH v3 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152608987682.121480.6298707358042668817.stgit@localhost.localdomain \
--to=andy@warmcat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.