All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 08/10] drm/i915: Remove USES_GUC_SUBMISSION() pointer chasing from gen8_cs_irq_handler
Date: Mon, 14 May 2018 12:45:31 +0100	[thread overview]
Message-ID: <152629833164.18532.1691198984585394826@mail.alporthouse.com> (raw)
In-Reply-To: <75583cb0-337f-ed44-c4ba-7f006768c4cf@linux.intel.com>

Quoting Tvrtko Ursulin (2018-05-14 11:27:56)
> 
> On 14/05/2018 10:37, Chris Wilson wrote:
> > Store whether or not we need to kick the guc's execlists emulation on
> > the engine itself to avoid chasing the device info.
> > 
> > gen8_cs_irq_handler                          512     428     -84
> 
> Impressive, or not, depends whether you look at the saving or code 
> generation.

The code generation also looked better, at least in my eyes. Fewer
chained movs and simpler test?

> Hm, actually, is it just GEM_BUG_ON in intel_uc_is_using_guc_submission?
> 
> But blimey, didn't we pencil in long time ago to stop using modparams at 
> runtime in favour of caching the values? This one looks like one to 
> confuse the driver easily if fiddled with at runtime.

Yes, this is one where once upon a time we had an engine->guc_client to
inspect that we traded in for a common i915->guc_client, but that will
still require a pointer dance.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-05-14 11:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14  9:37 Direct execlists submission Chris Wilson
2018-05-14  9:37 ` [PATCH 01/10] drm/i915: Mark up nested spinlocks Chris Wilson
2018-05-14 10:06   ` Tvrtko Ursulin
2018-05-14  9:37 ` [PATCH 02/10] drm/i915: Remove tasklet flush before disable Chris Wilson
2018-05-14  9:37 ` [PATCH 03/10] drm/i915: Wrap tasklet_struct for abuse Chris Wilson
2018-05-14  9:37 ` [PATCH 04/10] drm/i915: Only sync tasklets once for recursive reset preparation Chris Wilson
2018-05-14  9:37 ` [PATCH 05/10] drm/i915/execlists: Direct submit onto idle engines Chris Wilson
2018-05-14  9:37 ` [PATCH 06/10] drm/i915/execlists: Direct submission from irq handler Chris Wilson
2018-05-14  9:37 ` [PATCH 07/10] drm/i915: Rearrange gen8_cs_irq_handler Chris Wilson
2018-05-14  9:37 ` [PATCH 08/10] drm/i915: Remove USES_GUC_SUBMISSION() pointer chasing from gen8_cs_irq_handler Chris Wilson
2018-05-14 10:27   ` Tvrtko Ursulin
2018-05-14 11:45     ` Chris Wilson [this message]
2018-05-14  9:37 ` [PATCH 09/10] drm/i915: Speed up idle detection by kicking the tasklets Chris Wilson
2018-05-14  9:37 ` [PATCH 10/10] drm/i915: Detect if we missed kicking the execlists tasklet Chris Wilson
2018-05-14  9:42 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915: Mark up nested spinlocks Patchwork
2018-05-14  9:45 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-05-14  9:59 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-14 10:11 ` Direct execlists submission Tvrtko Ursulin
2018-05-14 10:25   ` Chris Wilson
2018-05-14 14:54     ` Chris Wilson
2018-05-14 12:45 ` ✓ Fi.CI.IGT: success for series starting with [01/10] drm/i915: Mark up nested spinlocks Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152629833164.18532.1691198984585394826@mail.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.