Re: [igt-dev] [PATCH i-g-t v2] lib/igt_device: Add information why cannot drop drm master

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Katarzyna Dec <katarzyna.dec@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2] lib/igt_device: Add information why cannot drop drm master
Date: Mon, 14 May 2018 13:39:19 +0100	[thread overview]
Message-ID: <152630155962.18532.14957894070207895837@mail.alporthouse.com> (raw)
In-Reply-To: <20180514113722.28594-1-katarzyna.dec@intel.com>

Quoting Katarzyna Dec (2018-05-14 12:37:22)
> Let's add additional information to igt_device_drop_master
> in case we try to run tests with e.g. x11 enabled.
> 
> v2: Changed comment and added listing clients.
> 
> Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  lib/igt_device.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_device.c b/lib/igt_device.c
> index 8a2dd0e3..b2a0a160 100644
> --- a/lib/igt_device.c
> +++ b/lib/igt_device.c
> @@ -74,5 +74,9 @@ int __igt_device_drop_master(int fd)
>   */
>  void igt_device_drop_master(int fd)
>  {
> -       igt_assert_eq(__igt_device_drop_master(fd), 0);
> +       if (__igt_device_drop_master(fd)) {
> +               igt_debugfs_dump(fd, "clients");
> +               igt_require_f(__igt_device_drop_master(fd) == 0,
> +                             "Failed to drop DRM master.\n");
> +       }

I still stand by this should be an assert.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev