From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org,
Franky Lin <franky.lin@broadcom.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: [PATCH 7/8] brcmfmac: trigger memory dump upon firmware halt signal
Date: Tue, 15 May 2018 11:14:50 +0200 [thread overview]
Message-ID: <1526375691-31789-8-git-send-email-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <1526375691-31789-1-git-send-email-arend.vanspriel@broadcom.com>
From: Franky Lin <franky.lin@broadcom.com>
PCIe dongle firmware signals a halt/trap through mailbox interrupt.
Trigger a memory dump upon receiving such signal could help to provide
useful information for issue debug.
Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index 5baa837..45928b5 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -182,6 +182,7 @@ enum brcmf_pcie_state {
#define BRCMF_D2H_DEV_D3_ACK 0x00000001
#define BRCMF_D2H_DEV_DS_ENTER_REQ 0x00000002
#define BRCMF_D2H_DEV_DS_EXIT_NOTE 0x00000004
+#define BRCMF_D2H_DEV_FWHALT 0x10000000
#define BRCMF_H2D_HOST_D3_INFORM 0x00000001
#define BRCMF_H2D_HOST_DS_ACK 0x00000002
@@ -717,6 +718,10 @@ static void brcmf_pcie_handle_mb_data(struct brcmf_pciedev_info *devinfo)
devinfo->mbdata_completed = true;
wake_up(&devinfo->mbdata_resp_wait);
}
+ if (dtoh_mb_data & BRCMF_D2H_DEV_FWHALT) {
+ brcmf_dbg(PCIE, "D2H_MB_DATA: FW HALT\n");
+ brcmf_dev_coredump(&devinfo->pdev->dev);
+ }
}
--
1.9.1
next prev parent reply other threads:[~2018-05-15 9:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 9:14 [PATCH 0/8] brcmfmac: coredump functionality and fixes Arend van Spriel
2018-05-15 9:14 ` [PATCH 1/8] brcmfmac: fix initialization of struct cfg80211_inform_bss variable Arend van Spriel
2018-05-15 15:09 ` [1/8] " Kalle Valo
2018-05-15 9:14 ` [PATCH 2/8] brcmfmac: move ALLFFMAC variable in flowring module Arend van Spriel
2018-05-15 9:14 ` [PATCH 3/8] brcmfmac: add support for sysfs initiated coredump Arend van Spriel
2018-05-15 9:14 ` [PATCH 4/8] mwifiex: support sysfs initiated device coredump Arend van Spriel
2018-05-15 20:22 ` kbuild test robot
2018-05-16 8:55 ` Arend van Spriel
2018-05-16 9:22 ` Kalle Valo
2018-05-15 9:14 ` [PATCH 5/8] btmrvl: support sysfs initiated firmware coredump Arend van Spriel
2018-05-15 9:30 ` Kalle Valo
2018-05-15 9:57 ` Arend van Spriel
2018-05-15 10:02 ` Kalle Valo
2018-05-15 10:02 ` Kalle Valo
2018-05-15 10:37 ` Arend van Spriel
2018-05-15 9:14 ` [PATCH 6/8] brcmfmac: validate user provided data for memdump before copying Arend van Spriel
2018-05-15 9:14 ` Arend van Spriel [this message]
2018-05-15 9:14 ` [PATCH 8/8] brcmfmac: trigger memory dump on SDIO firmware halt message Arend van Spriel
2018-05-15 9:32 ` [PATCH 0/8] brcmfmac: coredump functionality and fixes Kalle Valo
2018-05-15 9:58 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526375691-31789-8-git-send-email-arend.vanspriel@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.