All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Kiernan <alex.kiernan@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 07/14] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME
Date: Tue, 15 May 2018 14:48:46 +0000	[thread overview]
Message-ID: <1526395734-333-8-git-send-email-alex.kiernan@gmail.com> (raw)
In-Reply-To: <1526395734-333-1-git-send-email-alex.kiernan@gmail.com>

CONFIG_FASTBOOT_GPT_NAME and CONFIG_FASTBOOT_MBR_NAME are always defined
by Kconfig if you're compiling this code, so remove these redundant
defaults.

Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

Changes in v4: None
Changes in v3:
- new

Changes in v2: None

 drivers/fastboot/fb_mmc.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
index b1db296..038905f 100644
--- a/drivers/fastboot/fb_mmc.c
+++ b/drivers/fastboot/fb_mmc.c
@@ -15,19 +15,6 @@
 #include <linux/compat.h>
 #include <android_image.h>
 
-/*
- * FIXME: Ensure we always set these names via Kconfig once xxx_PARTITION is
- * migrated
- */
-#ifndef CONFIG_FASTBOOT_GPT_NAME
-#define CONFIG_FASTBOOT_GPT_NAME "gpt"
-#endif
-
-
-#ifndef CONFIG_FASTBOOT_MBR_NAME
-#define CONFIG_FASTBOOT_MBR_NAME "mbr"
-#endif
-
 #define BOOT_PARTITION_NAME "boot"
 
 struct fb_mmc_sparse {
-- 
2.7.4

  parent reply	other threads:[~2018-05-15 14:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15 14:48 [U-Boot] [PATCH v4 00/14] Add fastboot UDP support Alex Kiernan
2018-05-15 14:48 ` [U-Boot] [PATCH v4 01/14] fastboot: Move fastboot to drivers/fastboot Alex Kiernan
2018-05-15 23:07   ` Joe Hershberger
2018-05-15 14:48 ` [U-Boot] [PATCH v4 02/14] fastboot: Switch dependencies on FASTBOOT to USB_FUNCTION_FASTBOOT Alex Kiernan
2018-05-15 23:08   ` Joe Hershberger
2018-05-15 14:48 ` [U-Boot] [PATCH v4 03/14] fastboot: Refactor fastboot_okay/fail to take response Alex Kiernan
2018-05-15 14:48 ` [U-Boot] [PATCH v4 04/14] fastboot: Extract fastboot_okay/fail to fb_common.c Alex Kiernan
2018-05-15 14:48 ` [U-Boot] [PATCH v4 05/14] fastboot: Correct dependencies in FASTBOOT_FLASH Alex Kiernan
2018-05-15 14:48 ` [U-Boot] [PATCH v4 06/14] fastboot: Add missing newlines Alex Kiernan
2018-05-15 14:48 ` Alex Kiernan [this message]
2018-05-15 23:10   ` [U-Boot] [PATCH v4 07/14] fastboot: Remove FIXME for CONFIG_FASTBOOT_...NAME Joe Hershberger
2018-05-15 14:48 ` [U-Boot] [PATCH v4 08/14] fastboot: Fix parameter types in _fb_nand_write Alex Kiernan
2018-05-15 23:11   ` Joe Hershberger
2018-05-15 14:48 ` [U-Boot] [PATCH v4 09/14] fastboot: Rename fb_set_reboot_flag to fastboot_set_reboot_flag Alex Kiernan
2018-05-15 23:13   ` Joe Hershberger
2018-05-15 14:48 ` [U-Boot] [PATCH v4 10/14] fastboot: Extract common definitions from USB fastboot Alex Kiernan
2018-05-15 16:05   ` Simon Glass
2018-05-15 23:14   ` Joe Hershberger
2018-05-15 14:48 ` [U-Boot] [PATCH v4 11/14] ti: fastboot: Move weak overrides to board files Alex Kiernan
2018-05-15 14:48 ` [U-Boot] [PATCH v4 12/14] fs: Add fs_get_type_name to return current filesystem name Alex Kiernan
2018-05-15 23:16   ` Joe Hershberger
2018-05-15 14:48 ` [U-Boot] [PATCH v4 13/14] mmc: Separate "mmc swrite" from fastboot Alex Kiernan
2018-05-15 23:19   ` Joe Hershberger
2018-05-16  5:00     ` Alex Kiernan
2018-05-16 16:17       ` Joe Hershberger
2018-05-16 16:58         ` Alex Kiernan
2018-05-16 18:41   ` Joe Hershberger
2018-05-15 14:48 ` [U-Boot] [PATCH v4 14/14] net: fastboot: Merge AOSP UDP fastboot Alex Kiernan
2018-05-16 19:15   ` Joe Hershberger
2018-05-16 20:10     ` Alex Kiernan
2018-05-15 16:52 ` [U-Boot] [PATCH v4 00/14] Add fastboot UDP support Sam Protsenko
2018-05-15 18:33   ` Alex Kiernan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526395734-333-8-git-send-email-alex.kiernan@gmail.com \
    --to=alex.kiernan@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.