From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbeEQAwo (ORCPT ); Wed, 16 May 2018 20:52:44 -0400 Received: from mga02.intel.com ([134.134.136.20]:28426 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751163AbeEQAwn (ORCPT ); Wed, 16 May 2018 20:52:43 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,408,1520924400"; d="scan'208";a="39946988" Message-ID: <1526518361.8766.1.camel@linux.intel.com> Subject: Re: [RFC/RFT] [PATCH 10/10] cpufreq: intel_pstate: enable boost for SKX From: Srinivas Pandruvada To: Peter Zijlstra Cc: tglx@linutronix.de, mingo@redhat.com, bp@suse.de, lenb@kernel.org, rjw@rjwysocki.net, mgorman@techsingularity.net, x86@kernel.org, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, juri.lelli@arm.com, linux-kernel@vger.kernel.org Date: Wed, 16 May 2018 17:52:41 -0700 In-Reply-To: <20180516155424.GG12198@hirez.programming.kicks-ass.net> References: <20180516044911.28797-1-srinivas.pandruvada@linux.intel.com> <20180516044911.28797-11-srinivas.pandruvada@linux.intel.com> <20180516074948.GZ12217@hirez.programming.kicks-ass.net> <1526485584.61700.19.camel@linux.intel.com> <20180516155424.GG12198@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-05-16 at 17:54 +0200, Peter Zijlstra wrote: > On Wed, May 16, 2018 at 08:46:24AM -0700, Srinivas Pandruvada wrote: > > On Wed, 2018-05-16 at 09:49 +0200, Peter Zijlstra wrote: > > > On Tue, May 15, 2018 at 09:49:11PM -0700, Srinivas Pandruvada > > > wrote: > > > > Enable HWP boost on Skylake server platform. > > > > > > Why not unconditionally enable it on everything HWP ? > > > > Never noticed in any difference performance in clients with HWP nor > > anybody complained. Since clients uses single power domain, some > > other > > CPUs always gives boost.  > > Can't the hardware tell us about per-core stuff? Do we really have to > use tables for that? AFAIK not in a standard way across all platforms. But I will check on this.