From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915: Flush the RING stop bit after clearing RING_HEAD in reset Date: Fri, 18 May 2018 10:47:27 +0100 Message-ID: <152663684782.4210.173099292201688911@mail.alporthouse.com> References: <20180517142442.16979-1-chris@chris-wilson.co.uk> <20180517142442.16979-2-chris@chris-wilson.co.uk> <74bbb686-71d7-39cf-7ccc-d1ef15ec59f2@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 152956ECDA for ; Fri, 18 May 2018 09:47:33 +0000 (UTC) In-Reply-To: <74bbb686-71d7-39cf-7ccc-d1ef15ec59f2@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBUdnJ0a28gVXJzdWxpbiAoMjAxOC0wNS0xOCAxMDozMzo0NCkKPiAKPiBPbiAxNy8w NS8yMDE4IDE1OjI0LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiBJbnNpZGUgdGhlIGxpdmVfaGFu Z2NoZWNrIChyZXNldCkgc2VsZnRlc3RzLCB3ZSBvY2Nhc2lvbmFsbHkgc2VlCj4gPiBmYWlsdXJl cyBsaWtlCj4gPiAKPiA+IDw3PlsgIDIzOS4wOTQ4NDBdIGk5MTVfZ2VtX3NldF93ZWRnZWQgcmNz MAo+ID4gPDc+WyAgMjM5LjA5NDg0M10gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIGN1cnJl bnQgc2Vxbm8gMTlhOTgsIGxhc3QgMTlhOWEsIGhhbmdjaGVjayAwIFs1MTU4IG1zXQo+ID4gPDc+ WyAgMjM5LjA5NDg0Nl0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIFJlc2V0IGNvdW50OiA2 MjM5IChnbG9iYWwgMSkKPiA+IDw3PlsgIDIzOS4wOTQ4NDhdIGk5MTVfZ2VtX3NldF93ZWRnZWQg ICAgICAgICBSZXF1ZXN0czoKPiA+IDw3PlsgIDIzOS4wOTUwNTJdIGk5MTVfZ2VtX3NldF93ZWRn ZWQgICAgICAgICAgICAgICAgIGZpcnN0ICAxOWE5OSBbZThjOjVmXSBwcmlvPTEwMjQgQCA1MTU5 bXM6IChudWxsKQo+ID4gPDc+WyAgMjM5LjA5NTA1Nl0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAg ICAgICAgICAgICAgbGFzdCAgIDE5YTlhIFtlODE6MWFdIHByaW89MTM5IEAgNTE1OW1zOiBpZ3Qv cmNzMFs1OTc3XS8xCj4gPiA8Nz5bICAyMzkuMDk1MDU5XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAg ICAgICAgICAgICAgICBhY3RpdmUgMTlhOTkgW2U4Yzo1Zl0gcHJpbz0xMDI0IEAgNTE1OW1zOiAo bnVsbCkKPiA+IDw3PlsgIDIzOS4wOTUwNjJdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAg ICAgICAgIFtoZWFkIDAyMjAsIHBvc3RmaXggMDI4MCwgdGFpbCAwMmE4LCBiYXRjaCAweGZmZmZm ZmZmX2ZmZmZmZmZmXQo+ID4gPDc+WyAgMjM5LjEwMDA1MF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAg ICAgICAgICAgICAgICAgcmluZy0+c3RhcnQ6ICAweDAwMjgzMDAwCj4gPiA8Nz5bICAyMzkuMTAw MDUzXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAgICByaW5nLT5oZWFkOiAgIDB4 MDAwMDAxZjgKPiA+IDw3PlsgIDIzOS4xMDAwNTVdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAg ICAgICAgICAgIHJpbmctPnRhaWw6ICAgMHgwMDAwMDJhOAo+ID4gPDc+WyAgMjM5LjEwMDA1N10g aTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgcmluZy0+ZW1pdDogICAweDAwMDAw MmE4Cj4gPiA8Nz5bICAyMzkuMTAwMDU5XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAg ICAgICByaW5nLT5zcGFjZTogIDB4MDAwMDBmMTAKPiA+IDw3PlsgIDIzOS4xMDAwODVdIGk5MTVf Z2VtX3NldF93ZWRnZWQgICAgICAgICBSSU5HX1NUQVJUOiAweDAwMjgzMDAwCj4gPiA8Nz5bICAy MzkuMTAwMDg4XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgUklOR19IRUFEOiAgMHgwMDAw MDI2MAo+ID4gPDc+WyAgMjM5LjEwMDA5MV0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIFJJ TkdfVEFJTDogIDB4MDAwMDAyYTgKPiA+IDw3PlsgIDIzOS4xMDAwOTRdIGk5MTVfZ2VtX3NldF93 ZWRnZWQgICAgICAgICBSSU5HX0NUTDogICAweDAwMDAwMDAxCj4gPiA8Nz5bICAyMzkuMTAwMDk3 XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgUklOR19NT0RFOiAgMHgwMDAwMDMwMCBbaWRs ZV0KPiA+IDw3PlsgIDIzOS4xMDAxMDBdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBSSU5H X0lNUjogZmZmZmZlZmUKPiA+IDw3PlsgIDIzOS4xMDAxMDRdIGk5MTVfZ2VtX3NldF93ZWRnZWQg ICAgICAgICBBQ1RIRDogIDB4MDAwMDAwMDBfMDAwMDYwOWMKPiA+IDw3PlsgIDIzOS4xMDAxMDhd IGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBCQkFERFI6IDB4MDAwMDAwMDBfMDAwMDYwOWQK PiA+IDw3PlsgIDIzOS4xMDAxMTFdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBETUFfRkFE RFI6IDB4MDAwMDAwMDBfMDAyODMyNjAKPiA+IDw3PlsgIDIzOS4xMDAxMTRdIGk5MTVfZ2VtX3Nl dF93ZWRnZWQgICAgICAgICBJUEVJUjogMHgwMDAwMDAwMAo+ID4gPDc+WyAgMjM5LjEwMDExN10g aTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIElQRUhSOiAweDAyODAwMDAwCj4gPiA8Nz5bICAy MzkuMTAwMTIwXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgRXhlY2xpc3Qgc3RhdHVzOiAw eDAwMDQ0MDUyIDAwMDAwMDAyCj4gPiA8Nz5bICAyMzkuMTAwMTI0XSBpOTE1X2dlbV9zZXRfd2Vk Z2VkICAgICAgICAgRXhlY2xpc3QgQ1NCIHJlYWQgNSBbNSBjYWNoZWRdLCB3cml0ZSA1IFs1IGZy b20gaHdzXSwgaW50ZXJydXB0IHBvc3RlZD8gbm8sIHRhc2tsZXQgcXVldWVkPyBubyAoZW5hYmxl ZCkKPiA+IDw3PlsgIDIzOS4xMDAxMjhdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAgICAg ICAgIEVMU1BbMF0gY291bnQ9MSwgcmluZy0+c3RhcnQ9MDAyODMwMDAsIHJxOiAxOWE5OSBbZThj OjVmXSBwcmlvPTEwMjQgQCA1MTY0bXM6IChudWxsKQo+ID4gPDc+WyAgMjM5LjEwMDEzMl0gaTkx NV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgRUxTUFsxXSBjb3VudD0xLCByaW5nLT5z dGFydD0wMDI1NzAwMCwgcnE6IDE5YTlhIFtlODE6MWFdIHByaW89MTM5IEAgNTE2NG1zOiBpZ3Qv cmNzMFs1OTc3XS8xCj4gPiA8Nz5bICAyMzkuMTAwMTM1XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAg ICAgICAgICAgICAgICBIVyBhY3RpdmU/IDB4NQo+ID4gPDc+WyAgMjM5LjEwMDI1MF0gaTkxNV9n ZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgRSAxOWE5OSBbZThjOjVmXSBwcmlvPTEwMjQg QCA1MTY0bXM6IChudWxsKQo+ID4gPDc+WyAgMjM5LjEwMDMzOF0gaTkxNV9nZW1fc2V0X3dlZGdl ZCAgICAgICAgICAgICAgICAgRSAxOWE5YSBbZTgxOjFhXSBwcmlvPTEzOSBAIDUxNjRtczogaWd0 L3JjczBbNTk3N10vMQo+ID4gPDc+WyAgMjM5LjEwMDM0MF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAg ICAgICAgICAgICAgICAgUXVldWUgcHJpb3JpdHk6IDEzOQo+ID4gPDc+WyAgMjM5LjEwMDM0M10g aTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgUSAwIFtlOTg6MTldIHByaW89MTMy IEAgNTE2NG1zOiBpZ3QvcmNzMFs1OTc3XS84Cj4gPiA8Nz5bICAyMzkuMTAwMzQ2XSBpOTE1X2dl bV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAgICBRIDAgW2U4NDoxOV0gcHJpbz0xMjEgQCA1MTY1 bXM6IGlndC9yY3MwWzU5NzddLzIKPiA+IDw3PlsgIDIzOS4xMDAzNDldIGk5MTVfZ2VtX3NldF93 ZWRnZWQgICAgICAgICAgICAgICAgIFEgMCBbZTg3OjE5XSBwcmlvPTgyIEAgNTE2NW1zOiBpZ3Qv cmNzMFs1OTc3XS8zCj4gPiA8Nz5bICAyMzkuMTAwMzUyXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAg ICAgICAgICAgICAgICBRIDAgW2U4NDoxYV0gcHJpbz00NCBAIDUxNjRtczogaWd0L3JjczBbNTk3 N10vMgo+ID4gPDc+WyAgMjM5LjEwMDM1Nl0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAg ICAgICAgUSAwIFtlOGI6MTldIHByaW89MjAgQCA1MTY1bXM6IGlndC9yY3MwWzU5NzddLzQKPiA+ IDw3PlsgIDIzOS4xMDAzNjJdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBkcnZfc2VsZnRl c3QgWzU4OTRdIHdhaXRpbmcgZm9yIDE5YTk5Cj4gPiAKPiA+IHdoZXJlIHRoZSBHUFUgc2F3IGFu IGFyYml0cmF0aW9uIHBvaW50IGFuZCBpZGxlczsgQU5EIEhBUyBOT1QgQkVFTiBSRVNFVCEKPiA+ IFRoZSBSSU5HX01PREUgaW5kaWNhdGVzIHRoYXQgaXMgaWRsZSBhbmQgaGFzIHRoZSBTVE9QX1JJ TkcgYml0IHNldCwgc28KPiA+IHRyeSBjbGVhcmluZyBpdC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gPiAtLS0KPiA+ICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgfCAyICsrCj4gPiAgIDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5j b3JlLmMKPiA+IGluZGV4IGIzNmEzYjU3MzZhMC4uMDgyYjAwNDVhYzhjIDEwMDY0NAo+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gPiBAQCAtMTcyMCw2ICsxNzIwLDggQEAgc3Rh dGljIHZvaWQgZ2VuM19zdG9wX2VuZ2luZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUp Cj4gPiAgICAgICBpZiAoSTkxNV9SRUFEX0ZXKFJJTkdfSEVBRChiYXNlKSkgIT0gMCkKPiA+ICAg ICAgICAgICAgICAgRFJNX0RFQlVHX0RSSVZFUigiJXM6IHJpbmcgaGVhZCBub3QgcGFya2VkXG4i LAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVuZ2luZS0+bmFtZSk7Cj4gPiAr Cj4gPiArICAgICBJOTE1X1dSSVRFX0ZXKFJJTkdfTUlfTU9ERShiYXNlKSwgX01BU0tFRF9CSVRf RElTQUJMRShTVE9QX1JJTkcpKTsKPiA+ICAgfQo+ID4gICAKPiA+ICAgc3RhdGljIHZvaWQgaTkx NV9zdG9wX2VuZ2luZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gCj4g Cj4gUmlnaHQsIHNvIGV4cGVjdGF0aW9uIGlzIGFmdGVyIHJlc2V0IFNUT1BfUklORyB3aWxsIG5v dCBiZSBzZXQsIGJ1dCBpdCAKPiBzb21ldGltZXMgaXM/CgpZZXMuCgo+IFNob3VsZCB3ZSBhbHNv IGFkZCBhIG5vdGljZSBvciBpbmZvIGlmIGl0IGlzIHNldCBpbiBpbnRlbF9ncHVfcmVzZXQsIAo+ IGFmdGVyIHRoZSByZXNldCBpcyBjYWxsZWQ/IENvdWxkIGFkZCBpOTE1X2NoZWNrX2VuZ2luZV9y dW5uaW5nKC4uKSAKPiBoZWxwZXIgb3Igc29tZXRoaW5nLgoKQ291bGQgZG8sIHdpbGwgYmUgYW55 IG1vcmUgdXNlZnVsIHRoYW4gdGhlIGR1bXAgd2UgZ2l2ZSBhYm92ZT8gOykKTWlnaHQgYmUgaW50 ZXJlc3RpbmcgdG8gZG8gdGhlIGR1bXAgb24gdW51c3VhbCBzdGF0ZSBvbiB0YWtlb3ZlciBqdXN0 CmZvciByZWZlcmVuY2UgaW4gbGF0ZXIgZmFpbHMuCi1DaHJpcwpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK