All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Zhenyu Wang <zhenyuw@linux.intel.com>, intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gvt: Fix crash after request->hw_context change
Date: Fri, 18 May 2018 11:22:06 +0100	[thread overview]
Message-ID: <152663892627.13126.3694348985111443754@mail.alporthouse.com> (raw)
In-Reply-To: <20180518101305.8840-1-zhenyuw@linux.intel.com>

Quoting Zhenyu Wang (2018-05-18 11:13:05)
> When we do shadowing, workload's request might not be allocated yet,
> so we still require shadow context's object. And when complete workload,
> delay to zero workload's request pointer after used for update guest context.

Please allocate the context earlier then. The point is that until you
do, shadow_ctx->__engine[ring_id]->state is *undefined* and this code is
still illegal. :-p

The intent is that you start tracking the lifetime of the state you are
using because the assumptions made here will not hold for much longer.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-05-18 10:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 10:13 [PATCH] drm/i915/gvt: Fix crash after request->hw_context change Zhenyu Wang
2018-05-18 10:22 ` Chris Wilson [this message]
2018-05-21  3:44   ` Zhenyu Wang
2018-05-21  7:39     ` Chris Wilson
2018-05-18 10:55 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-05-18 11:03   ` Chris Wilson
2018-05-18 14:55     ` ??? " Zhenyu Wang
2018-05-21  8:17 ` [PATCH v2] " Zhenyu Wang
2018-05-21  9:54   ` Chris Wilson
2018-05-21 10:12     ` Chris Wilson
2018-05-21  8:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Fix crash after request->hw_context change (rev2) Patchwork
2018-05-21  8:54 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-21  9:49 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152663892627.13126.3694348985111443754@mail.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=zhenyuw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.