From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751897AbeEROkY (ORCPT ); Fri, 18 May 2018 10:40:24 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54050 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752202AbeEROkO (ORCPT ); Fri, 18 May 2018 10:40:14 -0400 Subject: Re: [PATCH] audit: add containerid support for IMA-audit From: Mimi Zohar To: Stefan Berger , Richard Guy Briggs Cc: containers@lists.linux-foundation.org, Linux-Audit Mailing List , linux-integrity , LKML , paul@paul-moore.com, sgrubb@redhat.com Date: Fri, 18 May 2018 10:39:55 -0400 In-Reply-To: References: <1520257393.10396.291.camel@linux.vnet.ibm.com> <20180305135008.po6lheqnmkqqo6q4@madcap2.tricolour.ca> <1520259854.10396.313.camel@linux.vnet.ibm.com> <20180308112104.z67wohdvjqemy7wy@madcap2.tricolour.ca> <20180517213001.62caslkjwv575xgl@madcap2.tricolour.ca> <86df5c2c-9db3-21b9-b91b-30a4f53f9504@linux.vnet.ibm.com> <1526647996.3632.164.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 18051814-0008-0000-0000-000004F7F3B3 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051814-0009-0000-0000-00001E8C7172 Message-Id: <1526654395.3632.196.camel@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-18_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805180161 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2018-05-18 at 09:54 -0400, Stefan Berger wrote: > On 05/18/2018 08:53 AM, Mimi Zohar wrote: [..] > >>>> If so, which ones? We could probably refactor the current > >>>> integrity_audit_message() and have ima_parse_rule() call into it to get > >>>> those fields as well. I suppose adding new fields to it wouldn't be > >>>> considered breaking user space? > >>> Changing the order of existing fields or inserting fields could break > >>> stuff and is strongly discouraged without a good reason, but appending > >>> fields is usually the right way to add information. > >>> > >>> There are exceptions, and in this case, I'd pick the "more standard" of > >>> the formats for AUDIT_INTEGRITY_RULE (ima_audit_measurement?) and stick > >>> with that, abandoning the other format, renaming the less standard > >>> version of the record (ima_parse_rule?) and perhpas adopting that > >>> abandonned format for the new record type while using > >>> current->audit_context. > > This sounds right, other than "type=INTEGRITY_RULE" (1805) for > > ima_audit_measurement().  Could we rename type=1805 to be > > So do we want to change both? I thought that what > ima_audit_measurement() produces looks ok but may not have a good name > for the 'type'. Now in this case I would not want to 'break user space'. > The only change I was going to make was to what ima_parse_rule() produces. The only change for now is separating the IMA policy rules from the IMA-audit messages. Richard, when the containerid is appended to the IMA-audit messages, would we make the audit type name change then? > > > INTEGRITY_AUDIT or INTEGRITY_IMA_AUDIT?  The new type=1806 audit > > message could be named INTEGRITY_RULE or, if that would be confusing, > > INTEGRITY_POLICY_RULE. > > For 1806, as we would use it in ima_parse_rule(), we could change that > in your patch to INTEGRITY_POLICY_RULE. IMA_POLICY_RULE may be better > for IMA to produce but that's inconsistent then. Ok > > > > >> 1806 would be in sync with INTEGRITY_RULE now for process related info. > >> If this looks good, I'll remove the dependency on your local context > >> creation and post the series. > >> > >> The justification for the change is that the INTEGRITY_RULE, as produced > >> by ima_parse_rule(), is broken. > > Post which series?  The IMA namespacing patch set?  This change should > > be upstreamed independently of IMA namespacing. > > Without Richard's local context patch it may just be one or two patches. Richard, if we separate the ima_parse_rules() audit messages, changing the audit rule number now, without the call to audit_log_task_info(), would adding the call later be breaking userspace? Mimi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48002 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752274AbeEROki (ORCPT ); Fri, 18 May 2018 10:40:38 -0400 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4IEeNCC048491 for ; Fri, 18 May 2018 10:40:38 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j1xba7h52-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 18 May 2018 10:40:29 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 18 May 2018 15:40:11 +0100 Subject: Re: [PATCH] audit: add containerid support for IMA-audit From: Mimi Zohar To: Stefan Berger , Richard Guy Briggs Cc: containers@lists.linux-foundation.org, Linux-Audit Mailing List , linux-integrity , LKML , paul@paul-moore.com, sgrubb@redhat.com Date: Fri, 18 May 2018 10:39:55 -0400 In-Reply-To: References: <1520257393.10396.291.camel@linux.vnet.ibm.com> <20180305135008.po6lheqnmkqqo6q4@madcap2.tricolour.ca> <1520259854.10396.313.camel@linux.vnet.ibm.com> <20180308112104.z67wohdvjqemy7wy@madcap2.tricolour.ca> <20180517213001.62caslkjwv575xgl@madcap2.tricolour.ca> <86df5c2c-9db3-21b9-b91b-30a4f53f9504@linux.vnet.ibm.com> <1526647996.3632.164.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Message-Id: <1526654395.3632.196.camel@linux.vnet.ibm.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Fri, 2018-05-18 at 09:54 -0400, Stefan Berger wrote: > On 05/18/2018 08:53 AM, Mimi Zohar wrote: [..] > >>>> If so, which ones? We could probably refactor the current > >>>> integrity_audit_message() and have ima_parse_rule() call into it to get > >>>> those fields as well. I suppose adding new fields to it wouldn't be > >>>> considered breaking user space? > >>> Changing the order of existing fields or inserting fields could break > >>> stuff and is strongly discouraged without a good reason, but appending > >>> fields is usually the right way to add information. > >>> > >>> There are exceptions, and in this case, I'd pick the "more standard" of > >>> the formats for AUDIT_INTEGRITY_RULE (ima_audit_measurement?) and stick > >>> with that, abandoning the other format, renaming the less standard > >>> version of the record (ima_parse_rule?) and perhpas adopting that > >>> abandonned format for the new record type while using > >>> current->audit_context. > > This sounds right, other than "type=INTEGRITY_RULE" (1805) for > > ima_audit_measurement(). Could we rename type=1805 to be > > So do we want to change both? I thought that what > ima_audit_measurement() produces looks ok but may not have a good name > for the 'type'. Now in this case I would not want to 'break user space'. > The only change I was going to make was to what ima_parse_rule() produces. The only change for now is separating the IMA policy rules from the IMA-audit messages. Richard, when the containerid is appended to the IMA-audit messages, would we make the audit type name change then? > > > INTEGRITY_AUDIT or INTEGRITY_IMA_AUDIT? The new type=1806 audit > > message could be named INTEGRITY_RULE or, if that would be confusing, > > INTEGRITY_POLICY_RULE. > > For 1806, as we would use it in ima_parse_rule(), we could change that > in your patch to INTEGRITY_POLICY_RULE. IMA_POLICY_RULE may be better > for IMA to produce but that's inconsistent then. Ok > > > > >> 1806 would be in sync with INTEGRITY_RULE now for process related info. > >> If this looks good, I'll remove the dependency on your local context > >> creation and post the series. > >> > >> The justification for the change is that the INTEGRITY_RULE, as produced > >> by ima_parse_rule(), is broken. > > Post which series? The IMA namespacing patch set? This change should > > be upstreamed independently of IMA namespacing. > > Without Richard's local context patch it may just be one or two patches. Richard, if we separate the ima_parse_rules() audit messages, changing the audit rule number now, without the call to audit_log_task_info(), would adding the call later be breaking userspace? Mimi