From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from s3.sipsolutions.net ([144.76.63.242]:57472 "EHLO
        sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751629AbeEVOvI (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Tue, 22 May 2018 10:51:08 -0400
Message-ID: <1527000664.6787.15.camel@sipsolutions.net> (sfid-20180522_165113_716445_77B428A7)
Subject: Re: [PATCH] cfg80211: Fix support for flushing old scan results
From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>,
        Arend van Spriel <arend.vanspriel@broadcom.com>,
        Tim Kourt <tim.a.kourt@linux.intel.com>
Cc: linux-wireless@vger.kernel.org
Date: Tue, 22 May 2018 16:51:04 +0200
In-Reply-To: <1527000610.6787.14.camel@sipsolutions.net> (sfid-20180522_165017_766861_D4036905)
References: <20180511164835.40161-1-tim.a.kourt@linux.intel.com>
         <1526631206.3805.1.camel@sipsolutions.net>
         <d12d4d4d-25d6-3cd0-1399-27de09c7f8c5@gmail.com>
         <5AFF2169.4010003@broadcom.com>
         <51c56faf-267d-c204-243a-31fc91976c5e@gmail.com>
         <5B03C5BA.50804@broadcom.com>
         <c8f3d9a7-b978-8af8-6594-d0ae66652956@gmail.com>
         (sfid-20180522_164839_367773_27F91548) <1527000610.6787.14.camel@sipsolutions.net>
         (sfid-20180522_165017_766861_D4036905)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On Tue, 2018-05-22 at 16:50 +0200, Johannes Berg wrote:
> On Tue, 2018-05-22 at 09:48 -0500, Denis Kenzior wrote:
> > Hi Arend,
> > 
> > > > Are you saying the first result is from the Beacon and the other is from
> > > > the Probe Response?  Then why are the 'Information elements from Probe
> > > > Response frame' the way they are?
> > > 
> > > Nope. I am not saying that. I am saying that there are two probe 
> > > requests being sent. One with broadcast ssid, ie. ssid_len == 0, and 
> > > with ssid 'myssid'. But it is speculation without a sniffer capture.
> > 
> > Ah I see what you mean now.  No, we traced this down to hostapd itself 
> > and it was receiving a single Probe Request with the ssid set and 
> > replying to it per spec.  So I'm pretty confident this scenario isn't 
> > what is happening.  Let me try to get some actual packet captures...
> 
> Was "myssid" the real SSID, or did you hide that from us and it was
> really 9 characters long in the original?
> 
> If it was really 9 characters long I could imagine that there's a
> different bug with a beacon with all-zero-bytes having been received
> (and getting stuck into the probe response buffer for some reason), and
> then you *should* see both entries.

Or perhaps there's a bug with how we link the results between
hidden/non-hidden, but it seems to me that hostapd would never have
responded with a probe response with zeroed bytes.

johannes