All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: mst@redhat.com
Cc: famz@redhat.com, qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features
Date: Wed, 23 May 2018 08:17:11 -0700 (PDT)	[thread overview]
Message-ID: <152708863117.129.4568990759282098445@d39dc562802a> (raw)
In-Reply-To: <1527086545-68024-1-git-send-email-mst@redhat.com>

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1527086545-68024-1-git-send-email-mst@redhat.com
Subject: [Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1527086545-68024-1-git-send-email-mst@redhat.com -> patchew/1527086545-68024-1-git-send-email-mst@redhat.com
 t [tag update]            patchew/20180523031805.27101-1-peterx@redhat.com -> patchew/20180523031805.27101-1-peterx@redhat.com
Switched to a new branch 'test'
4c9a6a2ffe intel-iommu: rework the page walk logic
5650cac9fb util: implement simple iova tree
88534312e0 intel-iommu: trace domain id during page walk
8ac709ee1c intel-iommu: pass in address space when page walk
1947a6e8f5 intel-iommu: introduce vtd_page_walk_info
9625294a9c intel-iommu: only do page walk for MAP notifiers
dde4ff462d intel-iommu: add iommu lock
f2f4e4a75c intel-iommu: remove IntelIOMMUNotifierNode
e38afacae2 intel-iommu: send PSI always even if across PDEs
0d36159676 nvdimm: fix typo in label-size definition
471bf9c78b contrib/vhost-user-blk: enable protocol feature for vhost-user-blk
a9ae0b2add hw/virtio: Fix brace Werror with clang 6.0.0
7cbfe1743d libvhost-user: Send messages with no data
195b5bd713 vhost-user+postcopy: Use qemu_set_nonblock
011e39054e virtio: support setting memory region based host notifier
7ecf626817 vhost-user: support receiving file descriptors in slave_read
2f00a166ec vhost-user: add Net prefix to internal state structure
d30090016d linux-headers: add kvm header for mips
6d6f92c8b0 linux-headers: add unistd.h on all arches
0e21fd6465 update-linux-headers.sh: unistd.h, kvm consistency
082496d2b5 linux-headers: drop kvm_para.h
0365135fac x86/cpu: use standard-headers/asm-x86.kvm_para.h
2317795f33 include/standard-headers: add asm-x86/kvm_para.h
1be5f83d10 update-linux-headers.sh: drop kvm_para.h hacks
964e0ee4cf vhost: add trace for IOTLB miss
e679e9a70f virtio-balloon: add hugetlb page allocation counts
a800e0a24e allocate pci id for mdpy
b33c444024 hw/pci-host/q35: Replace hardcoded value with macro

=== OUTPUT BEGIN ===
Checking PATCH 1/28: hw/pci-host/q35: Replace hardcoded value with macro...
WARNING: line over 80 characters
#27: FILE: hw/pci-host/q35.c:538:
+                             mch->pci_address_space, MCH_HOST_BRIDGE_SMRAM_C_BASE,

WARNING: line over 80 characters
#29: FILE: hw/pci-host/q35.c:540:
+    memory_region_add_subregion_overlap(mch->system_memory, MCH_HOST_BRIDGE_SMRAM_C_BASE,

total: 0 errors, 2 warnings, 35 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/28: allocate pci id for mdpy...
Checking PATCH 3/28: virtio-balloon: add hugetlb page allocation counts...
Checking PATCH 4/28: vhost: add trace for IOTLB miss...
Checking PATCH 5/28: update-linux-headers.sh: drop kvm_para.h hacks...
ERROR: line over 90 characters
#48: FILE: scripts/update-linux-headers.sh:121:
+        cp_portable "$tmpdir/include/asm/kvm_para.h" "$output/include/standard-headers/asm-$arch"

total: 1 errors, 0 warnings, 44 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/28: include/standard-headers: add asm-x86/kvm_para.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 121 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/28: x86/cpu: use standard-headers/asm-x86.kvm_para.h...
Checking PATCH 8/28: linux-headers: drop kvm_para.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/28: update-linux-headers.sh: unistd.h, kvm consistency...
Checking PATCH 10/28: linux-headers: add unistd.h on all arches...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 1017 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/28: linux-headers: add kvm header for mips...
Checking PATCH 12/28: vhost-user: add Net prefix to internal state structure...
Checking PATCH 13/28: vhost-user: support receiving file descriptors in slave_read...
Checking PATCH 14/28: virtio: support setting memory region based host notifier...
Checking PATCH 15/28: vhost-user+postcopy: Use qemu_set_nonblock...
Checking PATCH 16/28: libvhost-user: Send messages with no data...
Checking PATCH 17/28: hw/virtio: Fix brace Werror with clang 6.0.0...
Checking PATCH 18/28: contrib/vhost-user-blk: enable protocol feature for vhost-user-blk...
Checking PATCH 19/28: nvdimm: fix typo in label-size definition...
Checking PATCH 20/28: intel-iommu: send PSI always even if across PDEs...
Checking PATCH 21/28: intel-iommu: remove IntelIOMMUNotifierNode...
Checking PATCH 22/28: intel-iommu: add iommu lock...
Checking PATCH 23/28: intel-iommu: only do page walk for MAP notifiers...
Checking PATCH 24/28: intel-iommu: introduce vtd_page_walk_info...
Checking PATCH 25/28: intel-iommu: pass in address space when page walk...
Checking PATCH 26/28: intel-iommu: trace domain id during page walk...
Checking PATCH 27/28: util: implement simple iova tree...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 265 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 28/28: intel-iommu: rework the page walk logic...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2018-05-24 15:04 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 14:42 [Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features Michael S. Tsirkin
2018-05-23 14:42 ` [Qemu-devel] [PULL 01/28] hw/pci-host/q35: Replace hardcoded value with macro Michael S. Tsirkin
2018-05-23 14:42 ` [Qemu-devel] [PULL 02/28] allocate pci id for mdpy Michael S. Tsirkin
2018-05-23 14:42 ` [Qemu-devel] [PULL 04/28] vhost: add trace for IOTLB miss Michael S. Tsirkin
2018-05-23 14:42 ` [Qemu-devel] [PULL 03/28] virtio-balloon: add hugetlb page allocation counts Michael S. Tsirkin
2018-05-23 14:42 ` [Qemu-devel] [PULL 05/28] update-linux-headers.sh: drop kvm_para.h hacks Michael S. Tsirkin
2018-05-23 14:42 ` [Qemu-devel] [PULL 06/28] include/standard-headers: add asm-x86/kvm_para.h Michael S. Tsirkin
2018-05-23 14:43 ` [PULL 07/28] x86/cpu: use standard-headers/asm-x86.kvm_para.h Michael S. Tsirkin
2018-05-23 14:43   ` [Qemu-devel] " Michael S. Tsirkin
2018-05-25 11:06   ` Peter Maydell
2018-05-25 11:06     ` [Qemu-devel] " Peter Maydell
2018-05-25 11:53     ` Peter Maydell
2018-05-25 11:53       ` [Qemu-devel] " Peter Maydell
2018-05-25 12:18       ` Michael S. Tsirkin
2018-05-25 12:18         ` [Qemu-devel] " Michael S. Tsirkin
2018-05-25 12:21         ` Peter Maydell
2018-05-25 12:21           ` [Qemu-devel] " Peter Maydell
2018-05-25 12:27           ` Michael S. Tsirkin
2018-05-25 12:27             ` [Qemu-devel] " Michael S. Tsirkin
2018-05-25 12:30             ` Peter Maydell
2018-05-25 12:30               ` [Qemu-devel] " Peter Maydell
2018-05-25 12:35               ` Michael S. Tsirkin
2018-05-25 12:35                 ` [Qemu-devel] " Michael S. Tsirkin
2018-05-25 12:38                 ` Peter Maydell
2018-05-25 12:38                   ` [Qemu-devel] " Peter Maydell
2018-05-25 12:19     ` Michael S. Tsirkin
2018-05-25 12:19       ` [Qemu-devel] " Michael S. Tsirkin
2018-05-25 14:13     ` Paolo Bonzini
2018-05-25 14:13       ` [Qemu-devel] " Paolo Bonzini
2018-05-23 14:43 ` [Qemu-devel] [PULL 08/28] linux-headers: drop kvm_para.h Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 09/28] update-linux-headers.sh: unistd.h, kvm consistency Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 10/28] linux-headers: add unistd.h on all arches Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 12/28] vhost-user: add Net prefix to internal state structure Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 11/28] linux-headers: add kvm header for mips Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 13/28] vhost-user: support receiving file descriptors in slave_read Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 15/28] vhost-user+postcopy: Use qemu_set_nonblock Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 14/28] virtio: support setting memory region based host notifier Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 16/28] libvhost-user: Send messages with no data Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 17/28] hw/virtio: Fix brace Werror with clang 6.0.0 Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 18/28] contrib/vhost-user-blk: enable protocol feature for vhost-user-blk Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 19/28] nvdimm: fix typo in label-size definition Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 20/28] intel-iommu: send PSI always even if across PDEs Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 21/28] intel-iommu: remove IntelIOMMUNotifierNode Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 22/28] intel-iommu: add iommu lock Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 23/28] intel-iommu: only do page walk for MAP notifiers Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 24/28] intel-iommu: introduce vtd_page_walk_info Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 25/28] intel-iommu: pass in address space when page walk Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 26/28] intel-iommu: trace domain id during " Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 27/28] util: implement simple iova tree Michael S. Tsirkin
2018-05-23 14:43 ` [Qemu-devel] [PULL 28/28] intel-iommu: rework the page walk logic Michael S. Tsirkin
2018-05-23 15:17 ` no-reply [this message]
2018-05-24 14:18 ` [Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152708863117.129.4568990759282098445@d39dc562802a \
    --to=no-reply@patchew.org \
    --cc=famz@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.