Re: [igt-dev] [PATCH i-g-t 1/3] tests/kms_ccs: Don't populate igt_fb structs with stack garbage

From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] tests/kms_ccs: Don't populate igt_fb structs with stack garbage
Date: Wed, 23 May 2018 10:58:12 -0700	[thread overview]
Message-ID: <1527098292.2226.44.camel@intel.com> (raw)
In-Reply-To: <20180518204154.21990-1-ville.syrjala@linux.intel.com>

On Fri, 2018-05-18 at 23:41 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Clear the igt_fb struct to make sure no stack garbage is left in any
> members we don't explicitly initialize.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>

> ---
>  tests/kms_ccs.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
> index 63298f137abb..e1ee58801ac3 100644
> --- a/tests/kms_ccs.c
> +++ b/tests/kms_ccs.c
> @@ -280,6 +280,8 @@ static void generate_fb(data_t *data, struct
> igt_fb *fb,
>  	int ret;
>  	uint32_t ccs_handle;
>  
> +	memset(fb, 0, sizeof(*fb));
> +
>  	/* Use either compressed or Y-tiled to test. However, given
> the lack of
>  	 * available bandwidth, we use linear for the primary plane
> when
>  	 * testing sprites, since we cannot fit two CCS planes into
> the
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev