From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756107AbcCUOLy (ORCPT ); Mon, 21 Mar 2016 10:11:54 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:60124 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755289AbcCUOLv (ORCPT ); Mon, 21 Mar 2016 10:11:51 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar , Shilpasri G Bhat Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com, linux-pm@vger.kernel.org, pc@us.ibm.com, shreyas@linux.vnet.ibm.com, anton@samba.org, mikey@neuling.org Subject: Re: [PATCH] cpufreq: powernv: Define per_cpu chip pointer to optimize hot-path Date: Mon, 21 Mar 2016 15:13:59 +0100 Message-ID: <1527132.IQ7eWgKzaZ@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160321072255.GB1803@vireshk-i7> References: <1458274308.6622.79.camel@neuling.org> <1458313100-27676-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <20160321072255.GB1803@vireshk-i7> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, March 21, 2016 12:52:55 PM Viresh Kumar wrote: > On 18-03-16, 20:28, Shilpasri G Bhat wrote: > > From: Michael Neuling > > > > "cpufreq: powernv: Remove cpu_to_chip_id() from hot-path" introduced > > If the patch is already committed, you should provide its commit id as well. > > > 'core_to_chip_map' array to cache the chip-id of all cores. Replace > > this with per_cpu variable that stores the pointer to the chip-array. > > This removes the linear lookup and provides a neater and simpler > > solution. > > > > Signed-off-by: Michael Neuling > > Tested-by: Shilpasri G Bhat > > You are sending this patch and you have updated it as well.. So, you should have > had your signed-off here. Right. Plus if you send a patch from anyone else, you should add your sigh-off to it anyway, even if it hasn't been modified. So Shilpasri, please resend with your S-o-b and with the ACK from Viresh. Thanks, Rafael