From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tursulin@ursulin.net>, Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/trace: Context field needs to be 64-bit wide
Date: Fri, 25 May 2018 09:50:12 +0100 [thread overview]
Message-ID: <152723821294.11749.1074875749010031287@mail.alporthouse.com> (raw)
In-Reply-To: <20180525082642.18246-3-tvrtko.ursulin@linux.intel.com>
Quoting Tvrtko Ursulin (2018-05-25 09:26:42)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Underlaying field is u64 so the tracepoint needs to be as well.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/i915_trace.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h
> index bac582ed3a0b..009862261218 100644
> --- a/drivers/gpu/drm/i915/i915_trace.h
> +++ b/drivers/gpu/drm/i915/i915_trace.h
> @@ -623,7 +623,7 @@ TRACE_EVENT(i915_request_queue,
> __field(u32, hw_id)
> __field(u16, class)
> __field(u16, instance)
> - __field(u32, ctx)
> + __field(u64, ctx)
Hmm, we have a hole before the u64 if my counting is correct.
Hmm, hw_id is more related to the global seqno wouldn't you say? :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-25 8:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 8:26 [PATCH 1/3] drm/i915/trace: Describe engines as class:instance pairs Tvrtko Ursulin
2018-05-25 8:26 ` [PATCH 2/3] drm/i915/trace: Remove engine out of the context sandwich Tvrtko Ursulin
2018-05-25 10:28 ` Lionel Landwerlin
2018-05-25 10:31 ` Lionel Landwerlin
2018-05-25 12:13 ` Tvrtko Ursulin
2018-05-25 12:23 ` Tvrtko Ursulin
2018-05-25 8:26 ` [PATCH 3/3] drm/i915/trace: Context field needs to be 64-bit wide Tvrtko Ursulin
2018-05-25 8:50 ` Chris Wilson [this message]
2018-06-05 13:41 ` [PATCH v2 " Tvrtko Ursulin
2018-06-05 13:47 ` Chris Wilson
2018-05-25 9:10 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/trace: Describe engines as class:instance pairs Patchwork
2018-05-25 10:22 ` [PATCH 1/3] " Lionel Landwerlin
2018-05-25 12:56 ` ✓ Fi.CI.IGT: success for series starting with [1/3] " Patchwork
2018-06-05 9:41 ` [PATCH 1/3] " Lionel Landwerlin
2018-06-05 13:43 ` Tvrtko Ursulin
2018-06-05 13:45 ` Lionel Landwerlin
2018-06-05 14:43 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/trace: Describe engines as class:instance pairs (rev2) Patchwork
2018-06-05 15:48 ` Tvrtko Ursulin
2018-06-05 19:08 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152723821294.11749.1074875749010031287@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.