From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Blakey Subject: [PATCH net-next 1/2] cls_flower: Fix missing free of rhashtable Date: Wed, 30 May 2018 11:17:37 +0300 Message-ID: <1527668258-27174-2-git-send-email-paulb@mellanox.com> References: <1527668258-27174-1-git-send-email-paulb@mellanox.com> Cc: Yevgeny Kliteynik , Roi Dayan , Shahar Klein , Mark Bloch , Or Gerlitz , Paul Blakey To: Jiri Pirko , Cong Wang , Jamal Hadi Salim , David Miller , netdev@vger.kernel.org Return-path: Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:46992 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935832AbeE3IRt (ORCPT ); Wed, 30 May 2018 04:17:49 -0400 In-Reply-To: <1527668258-27174-1-git-send-email-paulb@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: When destroying the instance, destroy the head rhashtable. Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority") Reported-by: Vlad Buslov Reviewed-by: Roi Dayan Reviewed-by: Jiri Pirko Signed-off-by: Paul Blakey --- net/sched/cls_flower.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index d06e398..ce5983b 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -338,6 +338,8 @@ static void fl_destroy_sleepable(struct work_struct *work) { struct cls_fl_head *head = container_of(work, struct cls_fl_head, work); + + rhashtable_destroy(&head->ht); kfree(head); module_put(THIS_MODULE); } -- 2.7.4