From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753874AbeE3Q0e (ORCPT ); Wed, 30 May 2018 12:26:34 -0400 Received: from mga06.intel.com ([134.134.136.31]:29567 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbeE3Q0c (ORCPT ); Wed, 30 May 2018 12:26:32 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,461,1520924400"; d="scan'208";a="43998862" From: "Duyck, Alexander H" To: "mst@redhat.com" , "alexander.duyck@gmail.com" CC: "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "virtio-dev@lists.oasis-open.org" , "Rustad, Mark D" , "Daly, Dan" , "Bie, Tiwei" , "linux-pci@vger.kernel.org" , "bhelgaas@google.com" , "Liang, Cunming" , "Wang, Zhihong" Subject: Re: [virtio-dev] [PATCH] virtio_pci: support enabling VFs Thread-Topic: [virtio-dev] [PATCH] virtio_pci: support enabling VFs Thread-Index: AQHT9/P5uaO7GXR/D0ickSAfuvKJDaRI5waAgAADPwCAAAEXAA== Date: Wed, 30 May 2018 16:26:30 +0000 Message-ID: <1527697588.16245.136.camel@intel.com> References: <20180530085521.26583-1-tiwei.bie@intel.com> <20180530192215-mutt-send-email-mst@kernel.org> In-Reply-To: <20180530192215-mutt-send-email-mst@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [134.134.177.79] Content-Type: text/plain; charset="utf-8" Content-ID: <27BDE5CE4F9BBE428A5669147C2A00EF@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w4UGQdOA031540 On Wed, 2018-05-30 at 19:22 +0300, Michael S. Tsirkin wrote: > On Wed, May 30, 2018 at 09:10:57AM -0700, Alexander Duyck wrote: > > On Wed, May 30, 2018 at 1:55 AM, Tiwei Bie wrote: > > > There is a new feature bit allocated in virtio spec to > > > support SR-IOV (Single Root I/O Virtualization): > > > > > > https://github.com/oasis-tcs/virtio-spec/issues/11 > > > > > > This patch enables the support for this feature bit in > > > virtio driver. > > > > > > Signed-off-by: Tiwei Bie > > > > So from a quick glance it looks like we are leaving SR-IOV enabled if > > the driver is removed. Do we want to have that behavior or should we > > be adding the code to disable SR-IOV and free the VFs on driver > > removal? > > Could pci core handle it for us somehow? Maybe, but it would require changes to the pci core to do it. The problem is some drivers want to leave the VFs there since the PF doesn't really do anything, or they have the option of essentially putting the VFs into a standby state when the PF is gone. My main concern is do we care if VFs are allocated and then somebody removes the driver and binds a different driver to the interface? If not then this code and be left as is, but I just wanted to be certain since I know this isn't just enabling SR-IOV we are having to do a number of other checks against the virtio device. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:29567 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbeE3Q0c (ORCPT ); Wed, 30 May 2018 12:26:32 -0400 From: "Duyck, Alexander H" To: "mst@redhat.com" , "alexander.duyck@gmail.com" CC: "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "virtio-dev@lists.oasis-open.org" , "Rustad, Mark D" , "Daly, Dan" , "Bie, Tiwei" , "linux-pci@vger.kernel.org" , "bhelgaas@google.com" , "Liang, Cunming" , "Wang, Zhihong" Subject: Re: [virtio-dev] [PATCH] virtio_pci: support enabling VFs Date: Wed, 30 May 2018 16:26:30 +0000 Message-ID: <1527697588.16245.136.camel@intel.com> References: <20180530085521.26583-1-tiwei.bie@intel.com> <20180530192215-mutt-send-email-mst@kernel.org> In-Reply-To: <20180530192215-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: T24gV2VkLCAyMDE4LTA1LTMwIGF0IDE5OjIyICswMzAwLCBNaWNoYWVsIFMuIFRzaXJraW4gd3Jv dGU6DQo+IE9uIFdlZCwgTWF5IDMwLCAyMDE4IGF0IDA5OjEwOjU3QU0gLTA3MDAsIEFsZXhhbmRl ciBEdXljayB3cm90ZToNCj4gPiBPbiBXZWQsIE1heSAzMCwgMjAxOCBhdCAxOjU1IEFNLCBUaXdl aSBCaWUgPHRpd2VpLmJpZUBpbnRlbC5jb20+IHdyb3RlOg0KPiA+ID4gVGhlcmUgaXMgYSBuZXcg ZmVhdHVyZSBiaXQgYWxsb2NhdGVkIGluIHZpcnRpbyBzcGVjIHRvDQo+ID4gPiBzdXBwb3J0IFNS LUlPViAoU2luZ2xlIFJvb3QgSS9PIFZpcnR1YWxpemF0aW9uKToNCj4gPiA+IA0KPiA+ID4gaHR0 cHM6Ly9naXRodWIuY29tL29hc2lzLXRjcy92aXJ0aW8tc3BlYy9pc3N1ZXMvMTENCj4gPiA+IA0K PiA+ID4gVGhpcyBwYXRjaCBlbmFibGVzIHRoZSBzdXBwb3J0IGZvciB0aGlzIGZlYXR1cmUgYml0 IGluDQo+ID4gPiB2aXJ0aW8gZHJpdmVyLg0KPiA+ID4gDQo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBU aXdlaSBCaWUgPHRpd2VpLmJpZUBpbnRlbC5jb20+DQo+ID4gDQo+ID4gU28gZnJvbSBhIHF1aWNr IGdsYW5jZSBpdCBsb29rcyBsaWtlIHdlIGFyZSBsZWF2aW5nIFNSLUlPViBlbmFibGVkIGlmDQo+ ID4gdGhlIGRyaXZlciBpcyByZW1vdmVkLiBEbyB3ZSB3YW50IHRvIGhhdmUgdGhhdCBiZWhhdmlv ciBvciBzaG91bGQgd2UNCj4gPiBiZSBhZGRpbmcgdGhlIGNvZGUgdG8gZGlzYWJsZSBTUi1JT1Yg YW5kIGZyZWUgdGhlIFZGcyBvbiBkcml2ZXINCj4gPiByZW1vdmFsPw0KPiANCj4gQ291bGQgcGNp IGNvcmUgaGFuZGxlIGl0IGZvciB1cyBzb21laG93Pw0KDQpNYXliZSwgYnV0IGl0IHdvdWxkIHJl cXVpcmUgY2hhbmdlcyB0byB0aGUgcGNpIGNvcmUgdG8gZG8gaXQuDQoNClRoZSBwcm9ibGVtIGlz IHNvbWUgZHJpdmVycyB3YW50IHRvIGxlYXZlIHRoZSBWRnMgdGhlcmUgc2luY2UgdGhlIFBGDQpk b2Vzbid0IHJlYWxseSBkbyBhbnl0aGluZywgb3IgdGhleSBoYXZlIHRoZSBvcHRpb24gb2YgZXNz ZW50aWFsbHkNCnB1dHRpbmcgdGhlIFZGcyBpbnRvIGEgc3RhbmRieSBzdGF0ZSB3aGVuIHRoZSBQ RiBpcyBnb25lLg0KDQpNeSBtYWluIGNvbmNlcm4gaXMgZG8gd2UgY2FyZSBpZiBWRnMgYXJlIGFs bG9jYXRlZCBhbmQgdGhlbiBzb21lYm9keQ0KcmVtb3ZlcyB0aGUgZHJpdmVyIGFuZCBiaW5kcyBh IGRpZmZlcmVudCBkcml2ZXIgdG8gdGhlIGludGVyZmFjZT8gSWYNCm5vdCB0aGVuIHRoaXMgY29k ZSBhbmQgYmUgbGVmdCBhcyBpcywgYnV0IEkganVzdCB3YW50ZWQgdG8gYmUgY2VydGFpbg0Kc2lu Y2UgSSBrbm93IHRoaXMgaXNuJ3QganVzdCBlbmFibGluZyBTUi1JT1Ygd2UgYXJlIGhhdmluZyB0 byBkbyBhDQpudW1iZXIgb2Ygb3RoZXIgY2hlY2tzIGFnYWluc3QgdGhlIHZpcnRpbyBkZXZpY2Uu