From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754813AbeEaLWr (ORCPT ); Thu, 31 May 2018 07:22:47 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8220 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754567AbeEaLWi (ORCPT ); Thu, 31 May 2018 07:22:38 -0400 From: Yisheng Xie To: CC: , Yisheng Xie , "Ganesh Goudar" , Subject: [PATCH v2 04/21] cxgb4: use match_string() helper Date: Thu, 31 May 2018 19:11:09 +0800 Message-ID: <1527765086-19873-5-git-send-email-xieyisheng1@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1527765086-19873-1-git-send-email-xieyisheng1@huawei.com> References: <1527765086-19873-1-git-send-email-xieyisheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org match_string() returns the index of an array for a matching string, which can be used instead of open coded variant. Cc: Ganesh Goudar Cc: netdev@vger.kernel.org Signed-off-by: Yisheng Xie --- v2: - no change from v1. drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c index 9da6f57..bd61610 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c @@ -782,17 +782,11 @@ static int cudbg_get_mem_region(struct adapter *padap, if (rc) return rc; - for (i = 0; i < ARRAY_SIZE(cudbg_region); i++) { - if (!strcmp(cudbg_region[i], region_name)) { - found = 1; - idx = i; - break; - } - } - if (!found) - return -EINVAL; + rc = match_string(cudbg_region, ARRAY_SIZE(cudbg_region), region_name); + if (rc < 0) + return rc; - found = 0; + idx = rc; for (i = 0; i < meminfo->mem_c; i++) { if (meminfo->mem[i].idx >= ARRAY_SIZE(cudbg_region)) continue; /* Skip holes */ -- 1.7.12.4