From: Chris Wilson <chris@chris-wilson.co.uk>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: Don't read SOFT_SCRATCH(15) on MMIO error
Date: Thu, 31 May 2018 19:13:32 +0100 [thread overview]
Message-ID: <152779041228.15728.3763049250351407658@mail.alporthouse.com> (raw)
In-Reply-To: <20180528171618.10436-1-michal.wajdeczko@intel.com>
Quoting Michal Wajdeczko (2018-05-28 18:16:18)
> SOFT_SCRATCH(15) is used by GuC for sending MMIO GuC events to host and
> those events are now handled by intel_guc_to_host_event_handler_mmio().
>
> We should not try to read it on MMIO action error as 1) we may be using
> different set of registers for GuC MMIO communication, and 2) GuC may
> use CTB mechanism for sending events to host.
>
> While here, upgrade error message to DRM_ERROR.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
I'm still not totally sold on having the DRM_ERROR here improves
debugging; it doesn't do anything to improve error handling, but
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
nevertheless.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-31 18:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 17:16 [PATCH] drm/i915/guc: Don't read SOFT_SCRATCH(15) on MMIO error Michal Wajdeczko
2018-05-28 17:52 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-05-29 10:43 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-29 12:04 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-29 14:54 ` [PATCH] " Chris Wilson
2018-05-29 15:10 ` Michal Wajdeczko
2018-05-29 15:17 ` Chris Wilson
2018-05-29 15:30 ` Michal Wajdeczko
2018-07-12 15:31 ` Chris Wilson
2018-07-12 17:29 ` Michal Wajdeczko
2018-05-31 18:13 ` Chris Wilson [this message]
2018-05-31 18:23 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152779041228.15728.3763049250351407658@mail.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.