From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: guaneryu@gmail.com, darrick.wong@oracle.com
Cc: fstests@vger.kernel.org, Xiao Yang <yangx.jy@cn.fujitsu.com>
Subject: [PATCH] common/rc: Fix _require_xfs_io_command for scrub probe
Date: Mon, 4 Jun 2018 12:50:12 +0800 [thread overview]
Message-ID: <1528087812-24372-1-git-send-email-yangx.jy@cn.fujitsu.com> (raw)
In-Reply-To: <20180604045436.GN6581@desktop>
Currently, xfs_io scrub command doesn't allow the probe function
to have any parameter, so we remove the invalid parameter.
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 9273ff7..dadbed4 100644
--- a/common/rc
+++ b/common/rc
@@ -2148,7 +2148,7 @@ _require_xfs_io_command()
param_checked=1
;;
"scrub"|"repair")
- testio=`$XFS_IO_PROG -x -c "$command probe 0" $TEST_DIR 2>&1`
+ testio=`$XFS_IO_PROG -x -c "$command probe" $TEST_DIR 2>&1`
echo $testio | grep -q "Inappropriate ioctl" && \
_notrun "xfs_io $command support is missing"
;;
--
1.8.3.1
next prev parent reply other threads:[~2018-06-04 5:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 9:32 [PATCH] xfs: Regression test for vulnerable directory integrity check Xiao Yang
2018-05-25 4:37 ` Darrick J. Wong
2018-05-25 6:33 ` Xiao Yang
2018-05-29 17:53 ` Darrick J. Wong
2018-05-30 4:04 ` Xiao Yang
2018-05-30 4:52 ` Darrick J. Wong
2018-05-30 6:58 ` Eryu Guan
2018-05-30 8:53 ` [PATCH v2] " Xiao Yang
2018-05-30 14:56 ` Darrick J. Wong
2018-06-03 13:37 ` Eryu Guan
2018-06-03 22:56 ` Darrick J. Wong
2018-06-04 4:54 ` Eryu Guan
2018-06-04 4:50 ` Xiao Yang [this message]
2018-06-04 15:44 ` [PATCH] common/rc: Fix _require_xfs_io_command for scrub probe Darrick J. Wong
2018-06-04 5:00 ` [PATCH v2] xfs: Regression test for vulnerable directory integrity check Xiao Yang
2018-06-04 4:55 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528087812-24372-1-git-send-email-yangx.jy@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.