From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org by pdx-caf-mail.web.codeaurora.org (Dovecot) with LMTP id 588WFlpfGVtKNwAAmS7hNA ; Thu, 07 Jun 2018 16:37:46 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 494CD6074D; Thu, 7 Jun 2018 16:37:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by smtp.codeaurora.org (Postfix) with ESMTP id 9B98D601B4; Thu, 7 Jun 2018 16:37:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9B98D601B4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933266AbeFGQhn convert rfc822-to-8bit (ORCPT + 25 others); Thu, 7 Jun 2018 12:37:43 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58838 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933158AbeFGQhh (ORCPT ); Thu, 7 Jun 2018 12:37:37 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w57GYe83072987 for ; Thu, 7 Jun 2018 12:37:36 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2jf5q18w8n-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Jun 2018 12:37:36 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jun 2018 17:37:34 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 7 Jun 2018 17:37:30 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w57GbT5W17432684 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Jun 2018 16:37:29 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE54D42045; Thu, 7 Jun 2018 17:27:48 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A57642047; Thu, 7 Jun 2018 17:27:48 +0100 (BST) Received: from localhost (unknown [9.77.126.253]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 7 Jun 2018 17:27:48 +0100 (BST) Date: Thu, 07 Jun 2018 22:07:26 +0530 From: "Naveen N. Rao" Subject: Re: [RFC PATCH -tip v5 18/27] powerpc/kprobes: Don't call the ->break_handler() in arm kprobes code To: Masami Hiramatsu Cc: Andrew Morton , "H . Peter Anvin" , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Ingo Molnar , Paul Mackerras , Steven Rostedt , Thomas Gleixner References: <152812730943.10068.5166429445118734697.stgit@devbox> <152812783350.10068.4690566636762511152.stgit@devbox> <1528371112.vwnh1m0k39.naveen@linux.ibm.com> <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> In-Reply-To: <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> User-Agent: astroid/0.11.1 (https://github.com/astroidmail/astroid) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 18060716-0020-0000-0000-000002985BD1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18060716-0021-0000-0000-000020E461CD Message-Id: <1528389409.62iyaqw9yn.naveen@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-07_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=917 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806070183 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masami Hiramatsu wrote: > On Thu, 07 Jun 2018 17:07:00 +0530 > "Naveen N. Rao" wrote: > >> Masami Hiramatsu wrote: >> > Don't call the ->break_handler() from the arm kprobes code, >> ^^^ powerpc >> >> > because it was only used by jprobes which got removed. >> > >> > This also makes skip_singlestep() a static function since >> > only ftrace-kprobe.c is using this function. >> > >> > Signed-off-by: Masami Hiramatsu >> > Cc: Benjamin Herrenschmidt >> > Cc: Paul Mackerras >> > Cc: Michael Ellerman >> > Cc: "Naveen N. Rao" >> > Cc: linuxppc-dev@lists.ozlabs.org >> > --- >> > arch/powerpc/include/asm/kprobes.h | 10 ---------- >> > arch/powerpc/kernel/kprobes-ftrace.c | 16 +++------------- >> > arch/powerpc/kernel/kprobes.c | 31 +++++++++++-------------------- >> > 3 files changed, 14 insertions(+), 43 deletions(-) >> >> With 2 small comments... > > 2 ? or 1 ? Two, with one in the commit log above :) - Naveen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 411rn13QJhzF33Y for ; Fri, 8 Jun 2018 02:37:41 +1000 (AEST) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w57GZnTq089011 for ; Thu, 7 Jun 2018 12:37:38 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2jf5pf09py-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 07 Jun 2018 12:37:36 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jun 2018 17:37:34 +0100 Date: Thu, 07 Jun 2018 22:07:26 +0530 From: "Naveen N. Rao" Subject: Re: [RFC PATCH -tip v5 18/27] powerpc/kprobes: Don't call the ->break_handler() in arm kprobes code To: Masami Hiramatsu Cc: Andrew Morton , "H . Peter Anvin" , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar , Ingo Molnar , Paul Mackerras , Steven Rostedt , Thomas Gleixner References: <152812730943.10068.5166429445118734697.stgit@devbox> <152812783350.10068.4690566636762511152.stgit@devbox> <1528371112.vwnh1m0k39.naveen@linux.ibm.com> <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> In-Reply-To: <20180607232802.c5fcea960e94ef2f3cd4cde8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <1528389409.62iyaqw9yn.naveen@linux.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Masami Hiramatsu wrote: > On Thu, 07 Jun 2018 17:07:00 +0530 > "Naveen N. Rao" wrote: >=20 >> Masami Hiramatsu wrote: >> > Don't call the ->break_handler() from the arm kprobes code, >> ^^^ powerpc >>=20 >> > because it was only used by jprobes which got removed. >> >=20 >> > This also makes skip_singlestep() a static function since >> > only ftrace-kprobe.c is using this function. >> >=20 >> > Signed-off-by: Masami Hiramatsu >> > Cc: Benjamin Herrenschmidt >> > Cc: Paul Mackerras >> > Cc: Michael Ellerman >> > Cc: "Naveen N. Rao" >> > Cc: linuxppc-dev@lists.ozlabs.org >> > --- >> > arch/powerpc/include/asm/kprobes.h | 10 ---------- >> > arch/powerpc/kernel/kprobes-ftrace.c | 16 +++------------- >> > arch/powerpc/kernel/kprobes.c | 31 +++++++++++--------------= ------ >> > 3 files changed, 14 insertions(+), 43 deletions(-) >>=20 >> With 2 small comments... >=20 > 2 ? or 1 ? Two, with one in the commit log above :) - Naveen =