From: Johannes Berg <johannes@sipsolutions.net>
To: Wan-Hua Chang <winnie.chang@cypress.com>,
backports@vger.kernel.org,
Aaron Komisar <aaron.komisar@tandemg.com>
Cc: Chi-Hsien.Lin@cypress.com
Subject: Re: [PATCH] Updating id field in backports genl family
Date: Mon, 11 Jun 2018 14:25:07 +0200 [thread overview]
Message-ID: <1528719907.10346.0.camel@sipsolutions.net> (raw)
In-Reply-To: <20180611102947.GA188023@aremote01.aus.cypress.com> (sfid-20180611_123004_861733_D37D3B95)
On Mon, 2018-06-11 at 05:29 -0500, Wan-Hua Chang wrote:
> Hi,
>
> I see the patch causes compiling error becasue family->family is not
> found when LINUX_VERSION >= 3.13
>
> backports/backport/backport-include/genetlink.h
> struct backport_genl_fmaily is only defined when LINUX_VERSION < 3.13
>
>
> And in backports/backport/compat/backport-3.13.c line 127
>
> family->id = family->family.id
>
> it looks like this line has done what the patch want to do. Is the
> comprehension correct?
I guess we have to put an ifdef around this ...
Aaron?
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2018-06-11 12:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 10:29 [PATCH] Updating id field in backports genl family Wan-Hua Chang
2018-06-11 12:25 ` Johannes Berg [this message]
2018-06-12 1:50 ` Chi-Hsien Lin
2018-06-12 12:10 ` Aaron Komisar
2018-06-13 10:30 ` Wan-Hua Chang
2018-06-21 10:12 ` Wan-Hua Chang
2018-06-21 14:14 ` Aaron Komisar
2018-06-21 14:17 ` Johannes Berg
2018-06-25 16:40 ` Johannes Berg
2018-06-26 6:07 ` Wan-Hua Chang
2018-06-26 6:54 ` Aaron Komisar
-- strict thread matches above, loose matches on Subject: below --
2018-05-24 10:57 Aaron Komisar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528719907.10346.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Chi-Hsien.Lin@cypress.com \
--cc=aaron.komisar@tandemg.com \
--cc=backports@vger.kernel.org \
--cc=winnie.chang@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.