From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Jozwiak Subject: [PATCH v3 19/38] crypto/qat: use generic driver name for PCI registration Date: Wed, 13 Jun 2018 14:14:03 +0200 Message-ID: <1528892062-4997-20-git-send-email-tomaszx.jozwiak@intel.com> References: <1523040732-3290-1-git-send-email-fiona.trahe@intel.com> <1528892062-4997-1-git-send-email-tomaszx.jozwiak@intel.com> To: fiona.trahe@intel.com, tomaszx.jozwiak@intel.com, dev@dpdk.org Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 60DAD1EF8B for ; Wed, 13 Jun 2018 14:15:01 +0200 (CEST) In-Reply-To: <1528892062-4997-1-git-send-email-tomaszx.jozwiak@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Fiona Trahe The QAT PMD used to register with PCI using the name "crypto_qat". Keep this name for the driver registered with cryptodev and use a more generic name "qat" for the PCI registration. This paves the way for the PCI device to host other services. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_common.h | 2 ++ drivers/crypto/qat/rte_qat_cryptodev.c | 25 ++++++++++++++++++------- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/qat/qat_common.h b/drivers/crypto/qat/qat_common.h index 77ffc8f72..63e5569ea 100644 --- a/drivers/crypto/qat/qat_common.h +++ b/drivers/crypto/qat/qat_common.h @@ -11,6 +11,8 @@ /**< Intel(R) QAT Symmetric Crypto PMD device name */ #define CRYPTODEV_NAME_QAT_SYM_PMD crypto_qat +/**< Intel(R) QAT device name for PCI registration */ +#define QAT_PCI_NAME qat /* * Maximum number of SGL entries */ diff --git a/drivers/crypto/qat/rte_qat_cryptodev.c b/drivers/crypto/qat/rte_qat_cryptodev.c index 6ab870cad..ad8a56374 100644 --- a/drivers/crypto/qat/rte_qat_cryptodev.c +++ b/drivers/crypto/qat/rte_qat_cryptodev.c @@ -234,16 +234,27 @@ static int qat_pci_remove(struct rte_pci_device *pci_dev) } + +/* An rte_driver is needed in the registration of both the device and the driver + * with cryptodev. + * The actual qat pci's rte_driver can't be used as its name represents + * the whole pci device with all services. Think of this as a holder for a name + * for the crypto part of the pci device. + */ +static const char qat_sym_drv_name[] = RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD); +static struct rte_driver cryptodev_qat_sym_driver = { + .name = qat_sym_drv_name, + .alias = qat_sym_drv_name +}; +static struct cryptodev_driver qat_crypto_drv; +RTE_PMD_REGISTER_CRYPTO_DRIVER(qat_crypto_drv, cryptodev_qat_sym_driver, + cryptodev_qat_driver_id); + static struct rte_pci_driver rte_qat_pmd = { .id_table = pci_id_qat_map, .drv_flags = RTE_PCI_DRV_NEED_MAPPING, .probe = qat_pci_probe, .remove = qat_pci_remove }; - -static struct cryptodev_driver qat_crypto_drv; - -RTE_PMD_REGISTER_PCI(CRYPTODEV_NAME_QAT_SYM_PMD, rte_qat_pmd); -RTE_PMD_REGISTER_PCI_TABLE(CRYPTODEV_NAME_QAT_SYM_PMD, pci_id_qat_map); -RTE_PMD_REGISTER_CRYPTO_DRIVER(qat_crypto_drv, rte_qat_pmd.driver, - cryptodev_qat_driver_id); +RTE_PMD_REGISTER_PCI(QAT_PCI_NAME, rte_qat_pmd); +RTE_PMD_REGISTER_PCI_TABLE(QAT_PCI_NAME, pci_id_qat_map); -- 2.17.0