From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 13/24] drm/i915/icl: unconditionally init DDI for every port Date: Wed, 13 Jun 2018 16:47:06 -0700 Message-ID: <1528933626.2793.4.camel@intel.com> References: <20180522002558.29262-1-paulo.r.zanoni@intel.com> <20180522002558.29262-14-paulo.r.zanoni@intel.com> <20180613233455.GD17137@ldmartin-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71FCE6E1E9 for ; Wed, 13 Jun 2018 23:47:24 +0000 (UTC) In-Reply-To: <20180613233455.GD17137@ldmartin-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org RW0gUXVhLCAyMDE4LTA2LTEzIMOgcyAxNjozNCAtMDcwMCwgTHVjYXMgRGUgTWFyY2hpIGVzY3Jl dmV1Ogo+IE9uIE1vbiwgTWF5IDIxLCAyMDE4IGF0IDA1OjI1OjQ3UE0gLTA3MDAsIFBhdWxvIFph bm9uaSB3cm90ZToKPiA+IE9uIElDUCwgcG9ydCBwcmVzZW50IHN0cmFwcyBhcmUgbm8gbG9uZ2Vy IHN1cHBvcnRlZC4gU29mdHdhcmUKPiA+IHNob3VsZAo+IAo+IElDUD8/IERvZXNuJ3QgaXQgbWFr ZSBtb3JlIHNlbnNlIHRvIHNheSBvbiBJQ0wgaGVyZT8KClRoZSByZWdpc3RlciB0aGF0IHVzZWQg dG8gaGF2ZSB0aGUgcG9ydCBwcmVzZW50IHN0cmFwcyB3YXMgaW4gdGhlIFBDSCwKaXQncyBTRlVT RV9TVFJBUC4gSSdsbCByZXdvcmQgdGhlIGNvbW1pdCBtZXNzYWdlIHRvIGV4cGxpY2l0bHkgbWVu dGlvbgppdCwgc2luY2UgdGhlIHdvcmRpbmcgb24gdGhlIGNvbW1pdCBtZXNzYWdlIGlzIGJhc2lj YWxseSB3aGF0J3Mgd3JpdHRlbgpvbiB0aGUgU0ZVU0VfVFJBUCBwYWdlLgoKPiAKPiA+IGRldGVy bWluZSB0aGUgcHJlc2VuY2UgdGhyb3VnaCBCSU9TIFZCVCwgaG90cGx1ZyBvciBvdGhlcgo+ID4g bWVjaGFuaXNtcy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogUGF1bG8gWmFub25pIDxwYXVsby5y Lnphbm9uaUBpbnRlbC5jb20+Cj4gCj4gUmV2aWV3ZWQtYnk6IEx1Y2FzIERlIE1hcmNoaSA8bHVj YXMuZGVtYXJjaGlAaW50ZWwuY29tPgo+IAoKVGhhbmtzIGEgbG90LApQYXVsbwoKPiBMdWNhcyBE ZSBNYXJjaGkKPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyB8IDkgKysrKysrKystCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+ID4gaW5kZXggZDVhMTljMWIzYjIwLi41MjhkOWY5YzQ1NmQgMTAwNjQ0Cj4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAgLTEzOTY1LDcgKzEzOTY1LDE0IEBAIHN0 YXRpYyB2b2lkIGludGVsX3NldHVwX291dHB1dHMoc3RydWN0Cj4gPiBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiA+ICAJaWYgKGludGVsX2NydF9wcmVzZW50KGRldl9wcml2KSkKPiA+ICAJ CWludGVsX2NydF9pbml0KGRldl9wcml2KTsKPiA+ICAKPiA+IC0JaWYgKElTX0dFTjlfTFAoZGV2 X3ByaXYpKSB7Cj4gPiArCWlmIChJU19JQ0VMQUtFKGRldl9wcml2KSkgewo+ID4gKwkJaW50ZWxf ZGRpX2luaXQoZGV2X3ByaXYsIFBPUlRfQSk7Cj4gPiArCQlpbnRlbF9kZGlfaW5pdChkZXZfcHJp diwgUE9SVF9CKTsKPiA+ICsJCWludGVsX2RkaV9pbml0KGRldl9wcml2LCBQT1JUX0MpOwo+ID4g KwkJaW50ZWxfZGRpX2luaXQoZGV2X3ByaXYsIFBPUlRfRCk7Cj4gPiArCQlpbnRlbF9kZGlfaW5p dChkZXZfcHJpdiwgUE9SVF9FKTsKPiA+ICsJCWludGVsX2RkaV9pbml0KGRldl9wcml2LCBQT1JU X0YpOwo+ID4gKwl9IGVsc2UgaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpKSB7Cj4gPiAgCQkvKgo+ ID4gIAkJICogRklYTUU6IEJyb3h0b24gZG9lc24ndCBzdXBwb3J0IHBvcnQgZGV0ZWN0aW9uCj4g PiB2aWEgdGhlCj4gPiAgCQkgKiBERElfQlVGX0NUTF9BIG9yIFNGVVNFX1NUUkFQIHJlZ2lzdGVy cywgZmluZAo+ID4gYW5vdGhlciB3YXkgdG8KPiA+IC0tIAo+ID4gMi4xNC4zCj4gPiAKPiA+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK