From: richard.purdie@linuxfoundation.org
To: akuster808 <akuster808@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] os-release: add more variables to list
Date: Mon, 29 Oct 2018 17:12:57 +0000 [thread overview]
Message-ID: <1528f5f1b89f065ed67487b9a35b750e908cf64b.camel@linuxfoundation.org> (raw)
In-Reply-To: <a6650d3c-d356-22c7-5efe-8ebcf980e9fb@gmail.com>
On Sun, 2018-10-28 at 18:24 +0000, akuster808 wrote:
> On 10/25/18 10:25 AM, Richard Purdie wrote:
> > On Thu, 2018-10-25 at 08:20 +0100, Armin Kuster wrote:
> > > If someone extends the OS_RELEASE_FIELDS in a bbappend, it will
> > > cause
> > > the hash to change which is
> > > caught by the yocto-check-layer
> > >
> > > Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > > ---
> > > meta/recipes-core/os-release/os-release.bb | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-core/os-release/os-release.bb
> > > b/meta/recipes-core/os-release/os-release.bb
> > > index 7f3d9cb..88bf8f8 100644
> > > --- a/meta/recipes-core/os-release/os-release.bb
> > > +++ b/meta/recipes-core/os-release/os-release.bb
> > > @@ -12,7 +12,7 @@ do_configure[noexec] = "1"
> > >
> > > # Other valid fields: BUILD_ID ID_LIKE ANSI_COLOR CPE_NAME
> > > # HOME_URL SUPPORT_URL BUG_REPORT_URL
> > > -OS_RELEASE_FIELDS = "ID ID_LIKE NAME VERSION VERSION_ID
> > > PRETTY_NAME"
> > > +OS_RELEASE_FIELDS = "ID ID_LIKE NAME VERSION VERSION_ID
> > > PRETTY_NAME BUILD_ID HOME_URL BUG_REPORT_URL SUPPORT_URL
> > > CPE_NAME"
> >
> > I'm not sure I agree with this. It would usually be a policy
> > decision, e.g. a ditro config which would change this and you'd not
> > be doing this with a bbappend?
>
> Yeah, its the feedback I was looking for. Isn't OE core "NoDistro"
> and I will be wanting to have the CPE_NAME available with out having
> to define DISTRO. I am jet lagged so I am not seeing how to fix this
> for meta-secruity.
This sounds very much like "I want to be a distro but I don't want to
be a distro".
Changing os-release just because a layer was included is a really bad
idea. Its distro policy what would be included there, including what
the cpe name might be.
Whether the nodistro defaults are right is a different question but
meta-security should not be poking there.
Cheers,
Richard
next prev parent reply other threads:[~2018-10-29 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 7:20 [PATCH] os-release: add more variables to list Armin Kuster
2018-10-25 9:25 ` Richard Purdie
2018-10-28 18:24 ` akuster808
2018-10-29 17:12 ` richard.purdie [this message]
2018-10-29 19:36 ` akuster808
2018-10-29 21:10 ` richard.purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528f5f1b89f065ed67487b9a35b750e908cf64b.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=akuster808@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.