From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915: Keep the ctx workarounds tightly packed Date: Fri, 15 Jun 2018 12:34:51 +0100 Message-ID: <152906249129.5287.5959251319115903477@mail.alporthouse.com> References: <20180615080045.6671-1-chris@chris-wilson.co.uk> <874li4wang.fsf@gaia.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13D716EAD6 for ; Fri, 15 Jun 2018 11:35:04 +0000 (UTC) In-Reply-To: <874li4wang.fsf@gaia.fi.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org UXVvdGluZyBNaWthIEt1b3BwYWxhICgyMDE4LTA2LTE1IDEyOjI5OjIzKQo+IENocmlzIFdpbHNv biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPiB3cml0ZXM6Cj4gCj4gPiBGb3IgZWFjaCBwbGF0 Zm9ybSwgd2UgaGF2ZSBhIGZldyByZWdpc3RlcnMgdGhhdCByZXdyaXR0ZW4gd2l0aCBtdWx0aXBs ZQo+ID4gdmFsdWVzIC0tIHRoZXkgYXJlIG5vdCBwYXJ0IG9mIGEgc2VxdWVuY2UsIGp1c3QgZGlm ZmVyZW50IHBhcnRzIG9mIGEKPiA+IG1hc2tlZCByZWdpc3RlciBzZXQgYXQgZGlmZmVyZW50IHRp bWVzIChlLmcuIHBsYXRmb3JtIGFuZCBnZW4KPiA+IHdvcmthcm91bmRzKS4gQ29uc29saWRhdGUg dGhlc2UgaW50byBhIHNpbmdsZSByZWdpc3RlciB3cml0ZSB0byBrZWVwIHRoZQo+ID4gdGFibGUg Y29tcGFjdC4KPiA+Cj4gPiBXaGlsZSBhZGp1c3RpbmcgdGhlIGNvbnN0cnVjdGlvbiBvZiB0aGUg d2EgdGFibGUsIG1ha2UgaXQgbm9uIGZhdGFsIHNvCj4gPiB0aGF0IHRoZSBkcml2ZXIgc3RpbGwg bG9hZHMgYnV0IGtlZXBpbmcgdGhlIHdhcm5pbmcgYW5kIGV4dHJhIGRldGFpbHMKPiA+IGZvciBp bnNwZWN0aW9uLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+ID4gQ2M6IE9zY2FyIE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5j b20+Cj4gPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29t Pgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgICAgICB8 IDI1ICsrLS0tLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAg ICAgIHwgIDIgKy0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kcy5j IHwgNjMgKysrKysrKysrKysrKysrKystLS0tLS0tCj4gPiAgMyBmaWxlcyBjaGFuZ2VkLCA1MiBp bnNlcnRpb25zKCspLCAzOCBkZWxldGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2RlYnVnZnMuYwo+ID4gaW5kZXggYzYwMDI3OWQzZGI1Li5mNzg4OTVmZmFiOWIgMTAwNjQ0Cj4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiA+IEBAIC0zMzc4LDI4ICszMzc4LDEz IEBAIHN0YXRpYyBpbnQgaTkxNV9zaGFyZWRfZHBsbHNfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0s IHZvaWQgKnVudXNlZCkKPiA+ICAKPiA+ICBzdGF0aWMgaW50IGk5MTVfd2FfcmVnaXN0ZXJzKHN0 cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqdW51c2VkKQo+ID4gIHsKPiA+IC0gICAgIHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IG5vZGVfdG9faTkxNShtLT5wcml2YXRlKTsKPiA+ IC0gICAgIHN0cnVjdCBpOTE1X3dvcmthcm91bmRzICp3b3JrYXJvdW5kcyA9ICZkZXZfcHJpdi0+ d29ya2Fyb3VuZHM7Cj4gPiArICAgICBzdHJ1Y3QgaTkxNV93b3JrYXJvdW5kcyAqd2EgPSAmbm9k ZV90b19pOTE1KG0tPnByaXZhdGUpLT53b3JrYXJvdW5kczsKPiA+ICAgICAgIGludCBpOwo+ID4g IAo+ID4gLSAgICAgaW50ZWxfcnVudGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+ID4gLQo+ID4gLSAg ICAgc2VxX3ByaW50ZihtLCAiV29ya2Fyb3VuZHMgYXBwbGllZDogJWRcbiIsIHdvcmthcm91bmRz LT5jb3VudCk7Cj4gPiAtICAgICBmb3IgKGkgPSAwOyBpIDwgd29ya2Fyb3VuZHMtPmNvdW50OyAr K2kpIHsKPiA+IC0gICAgICAgICAgICAgaTkxNV9yZWdfdCBhZGRyOwo+ID4gLSAgICAgICAgICAg ICB1MzIgbWFzaywgdmFsdWUsIHJlYWQ7Cj4gPiAtICAgICAgICAgICAgIGJvb2wgb2s7Cj4gPiAt Cj4gPiAtICAgICAgICAgICAgIGFkZHIgPSB3b3JrYXJvdW5kcy0+cmVnW2ldLmFkZHI7Cj4gPiAt ICAgICAgICAgICAgIG1hc2sgPSB3b3JrYXJvdW5kcy0+cmVnW2ldLm1hc2s7Cj4gPiAtICAgICAg ICAgICAgIHZhbHVlID0gd29ya2Fyb3VuZHMtPnJlZ1tpXS52YWx1ZTsKPiA+IC0gICAgICAgICAg ICAgcmVhZCA9IEk5MTVfUkVBRChhZGRyKTsKPiA+IC0gICAgICAgICAgICAgb2sgPSAodmFsdWUg JiBtYXNrKSA9PSAocmVhZCAmIG1hc2spOwo+ID4gLSAgICAgICAgICAgICBzZXFfcHJpbnRmKG0s ICIweCVYOiAweCUwOFgsIG1hc2s6IDB4JTA4WCwgcmVhZDogMHglMDh4LCBzdGF0dXM6ICVzXG4i LAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgIGk5MTVfbW1pb19yZWdfb2Zmc2V0KGFkZHIp LCB2YWx1ZSwgbWFzaywgcmVhZCwgb2sgPyAiT0siIDogIkZBSUwiKTsKPiA+IC0gICAgIH0KPiA+ IC0KPiA+IC0gICAgIGludGVsX3J1bnRpbWVfcG1fcHV0KGRldl9wcml2KTsKPiA+ICsgICAgIHNl cV9wcmludGYobSwgIldvcmthcm91bmRzIGFwcGxpZWQ6ICVkXG4iLCB3YS0+Y291bnQpOwo+ID4g KyAgICAgZm9yIChpID0gMDsgaSA8IHdhLT5jb3VudDsgKytpKQo+ID4gKyAgICAgICAgICAgICBz ZXFfcHJpbnRmKG0sICIweCVYOiAweCUwOFgsIG1hc2s6IDB4JTA4WFxuIiwKPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICB3YS0+cmVnW2ldLmFkZHIsIHdhLT5yZWdbaV0udmFsdWUsIHdhLT5y ZWdbaV0ubWFzayk7Cj4gCj4gSXQgc2VlbXMgdGhhdCBnZW1fd29ya2Fyb3VuZHMgaXMgYWxyZWFk eSBzbWFydCBlbm91Z2ggdG8gbm90Cj4gcGFyc2UvdHJ1c3QgdGhlIGRyaXZlciBwcm92aWRlZCBy ZWFkIHZhbHVlLgo+IAo+IFBlcmhhcHMgdGhlIG9ubHkgdmFsdWUgaW4gaGVyZSB3YXMgdGhhdCB3 ZSBzYXcgd2hhdAo+IHdlcmUgY29udGV4dCBhbmQgbm9uIGNvbnRleHQgc2F2ZWQgb25lcy4gQnV0 IHdlCj4gaGF2ZSBvdGhlciB0b29scyBmb3IgdGhhdC4KCldlIGNvdWxkbid0IGV2ZW4gcmVseSBv biBpdCBkb2luZyB0aGF0LCBzaW5jZSB3aGF0IGl0IHJlYWQgd291bGQgYmUKcmFuZG9tICh3ZSBt YXkgaGF2ZSBoYWQgYSBjb250ZXh0LCB0aGUgcG93ZXIgY29udGV4dCBtYXkgb3IgbWF5IG5vdCBo YXZlCnRoZSBzYW1lIHZhbHVlcywgd2UgbWF5IG5ldmVyIGhhZCBsb2FkZWQgdGhlIHZhbHVlcyku Li4KCkZvcnR1bmF0ZWx5LCB3ZSBzdG9wcGVkIHVzaW5nIHRoZW0gOikKCj4gPiAgICAgICByZXR1 cm4gMDsKPiA+ICB9Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+IGluZGV4IDJjMTJkZTY3 OGUzMi4uOTFjMzg5NjIyMjE3IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaAo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4g QEAgLTEzMDgsNyArMTMwOCw3IEBAIHN0cnVjdCBpOTE1X2Zyb250YnVmZmVyX3RyYWNraW5nIHsK PiA+ICB9Owo+ID4gIAo+ID4gIHN0cnVjdCBpOTE1X3dhX3JlZyB7Cj4gPiAtICAgICBpOTE1X3Jl Z190IGFkZHI7Cj4gPiArICAgICB1MzIgYWRkcjsKPiA+ICAgICAgIHUzMiB2YWx1ZTsKPiA+ICAg ICAgIC8qIGJpdG1hc2sgcmVwcmVzZW50aW5nIFdBIGJpdHMgKi8KPiA+ICAgICAgIHUzMiBtYXNr Owo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dvcmthcm91bmRz LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3JrYXJvdW5kcy5jCj4gPiBpbmRleCAy NGI5MjljZTMzNDEuLmY4YmIzMmU5NzRmNiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3dvcmthcm91bmRzLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3dvcmthcm91bmRzLmMKPiA+IEBAIC00OCwyOSArNDgsNTggQEAKPiA+ICAgKiAtIFB1 YmxpYyBmdW5jdGlvbnMgdG8gaW5pdCBvciBhcHBseSB0aGUgZ2l2ZW4gd29ya2Fyb3VuZCB0eXBl Lgo+ID4gICAqLwo+ID4gIAo+ID4gLXN0YXRpYyBpbnQgd2FfYWRkKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiA+IC0gICAgICAgICAgICAgICBpOTE1X3JlZ190IGFkZHIsCj4g PiAtICAgICAgICAgICAgICAgY29uc3QgdTMyIG1hc2ssIGNvbnN0IHUzMiB2YWwpCj4gPiArc3Rh dGljIHZvaWQgd2FfYWRkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ID4gKyAgICAg ICAgICAgICAgICBpOTE1X3JlZ190IHJlZywgY29uc3QgdTMyIG1hc2ssIGNvbnN0IHUzMiB2YWwp Cj4gPiAgewo+ID4gLSAgICAgY29uc3QgdW5zaWduZWQgaW50IGlkeCA9IGRldl9wcml2LT53b3Jr YXJvdW5kcy5jb3VudDsKPiA+ICsgICAgIHN0cnVjdCBpOTE1X3dvcmthcm91bmRzICp3YSA9ICZp OTE1LT53b3JrYXJvdW5kczsKPiA+ICsgICAgIHVuc2lnbmVkIGludCBzdGFydCA9IDAsIGVuZCA9 IHdhLT5jb3VudDsKPiA+ICsgICAgIHVuc2lnbmVkIGludCBhZGRyID0gaTkxNV9tbWlvX3JlZ19v ZmZzZXQocmVnKTsKPiA+ICsgICAgIHN0cnVjdCBpOTE1X3dhX3JlZyAqcjsKPiA+ICsKPiA+ICsg ICAgIHdoaWxlIChzdGFydCA8IGVuZCkgewo+ID4gKyAgICAgICAgICAgICB1bnNpZ25lZCBpbnQg bWlkID0gc3RhcnQgKyAoZW5kIC0gc3RhcnQpIC8gMjsKPiA+ICsKPiA+ICsgICAgICAgICAgICAg aWYgKHdhLT5yZWdbbWlkXS5hZGRyIDwgYWRkcikgewo+ID4gKyAgICAgICAgICAgICAgICAgICAg IHN0YXJ0ID0gbWlkICsgMTsKPiA+ICsgICAgICAgICAgICAgfSBlbHNlIGlmICh3YS0+cmVnW21p ZF0uYWRkciA+IGFkZHIpIHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBlbmQgPSBtaWQ7Cj4g PiArICAgICAgICAgICAgIH0gZWxzZSB7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgciA9ICZ3 YS0+cmVnW21pZF07Cj4gPiArCj4gPiArICAgICAgICAgICAgICAgICAgICAgaWYgKChtYXNrICYg fnItPm1hc2spID09IDApIHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIERSTV9F UlJPUigiRGlzY2FyZGluZyBvdmVyd3JpdHRlbiB3L2EgZm9yIHJlZyAlMDR4IChtYXNrOiAlMDh4 LCB2YWx1ZTogJTA4eClcbiIsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgYWRkciwgci0+bWFzaywgci0+dmFsdWUpOwo+ID4gKwo+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgci0+dmFsdWUgJj0gfm1hc2s7Cj4gPiArICAgICAgICAgICAgICAgICAg ICAgfQo+ID4gKwo+ID4gKyAgICAgICAgICAgICAgICAgICAgIHItPnZhbHVlIHw9IHZhbDsKPiA+ ICsgICAgICAgICAgICAgICAgICAgICByLT5tYXNrICB8PSBtYXNrOwo+ID4gKyAgICAgICAgICAg ICAgICAgICAgIHJldHVybjsKPiA+ICsgICAgICAgICAgICAgfQo+ID4gKyAgICAgfQo+ID4gIAo+ ID4gLSAgICAgaWYgKFdBUk5fT04oaWR4ID49IEk5MTVfTUFYX1dBX1JFR1MpKQo+ID4gLSAgICAg ICAgICAgICByZXR1cm4gLUVOT1NQQzsKPiA+ICsgICAgIGlmIChXQVJOX09OX09OQ0Uod2EtPmNv dW50ID49IEk5MTVfTUFYX1dBX1JFR1MpKSB7Cj4gPiArICAgICAgICAgICAgIERSTV9FUlJPUigi RHJvcHBpbmcgdy9hIGZvciByZWcgJTA0eCAobWFzazogJTA4eCwgdmFsdWU6ICUwOHgpXG4iLAo+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgYWRkciwgbWFzaywgdmFsKTsKPiA+ICsgICAgICAg ICAgICAgcmV0dXJuOwo+ID4gKyAgICAgfQo+ID4gIAo+ID4gLSAgICAgZGV2X3ByaXYtPndvcmth cm91bmRzLnJlZ1tpZHhdLmFkZHIgPSBhZGRyOwo+ID4gLSAgICAgZGV2X3ByaXYtPndvcmthcm91 bmRzLnJlZ1tpZHhdLnZhbHVlID0gdmFsOwo+ID4gLSAgICAgZGV2X3ByaXYtPndvcmthcm91bmRz LnJlZ1tpZHhdLm1hc2sgPSBtYXNrOwo+ID4gKyAgICAgciA9ICZ3YS0+cmVnW3dhLT5jb3VudCsr XTsKPiA+ICsgICAgIHItPmFkZHIgID0gYWRkcjsKPiA+ICsgICAgIHItPnZhbHVlID0gdmFsOwo+ ID4gKyAgICAgci0+bWFzayAgPSBtYXNrOwo+ID4gIAo+ID4gLSAgICAgZGV2X3ByaXYtPndvcmth cm91bmRzLmNvdW50Kys7Cj4gPiArICAgICB3aGlsZSAoci0tID4gd2EtPnJlZykgewo+ID4gKyAg ICAgICAgICAgICBHRU1fQlVHX09OKHJbMF0uYWRkciA9PSByWzFdLmFkZHIpOwo+ID4gKyAgICAg ICAgICAgICBpZiAoclsxXS5hZGRyID4gclswXS5hZGRyKQo+ID4gKyAgICAgICAgICAgICAgICAg ICAgIGJyZWFrOwo+IAo+IEtlZXBpbmcgdGhlIHdvcmthcm91bmRzIGluIGEgc29ydGVkIG9yZGVy IGJ5IGFkZHIsCj4gY291bGQgYmUgbWVudGlvbmVkIGluIHRoZSBoZWFkZXIuIEJ1dCBub3QgaW5z aXN0aW5nCj4gb24gdGhhdCBhcyB0aGlzIGlzIHJhdGhlciBjbGVhciBmcm9tIHRoZSBjb2RlLgo+ IAo+ID4gIAo+ID4gLSAgICAgcmV0dXJuIDA7Cj4gPiArICAgICAgICAgICAgIHN3YXAoclsxXSwg clswXSk7Cj4gPiArICAgICB9Cj4gPiAgfQo+ID4gIAo+ID4gLSNkZWZpbmUgV0FfUkVHKGFkZHIs IG1hc2ssIHZhbCkgZG8geyBcCj4gPiAtICAgICAgICAgICAgIGNvbnN0IGludCByID0gd2FfYWRk KGRldl9wcml2LCAoYWRkciksIChtYXNrKSwgKHZhbCkpOyBcCj4gPiAtICAgICAgICAgICAgIGlm IChyKSBcCj4gPiAtICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHI7IFwKPiA+IC0gICAgIH0g d2hpbGUgKDApCj4gPiArI2RlZmluZSBXQV9SRUcoYWRkciwgbWFzaywgdmFsKSB3YV9hZGQoZGV2 X3ByaXYsIChhZGRyKSwgKG1hc2spLCAodmFsKSkKPiAKPiBJZiB5b3UgZG8gdGhpcywgdGhlbiB0 aGUgd2hvbGUgY2hhaW4gb2YgaW5pdGluZyB3b3JrYXJvdW5kcwo+IGNhbiBiZSBjb252ZXJ0ZWQg dG8gb21pdHRpbmcgcmV0dXJuIHZhbHVlLgoKSSB3YXMgdGhpbmtpbmcgdGhlIHNhbWUgZm9yIGEg Zm9sbG93dXAuIEFzIHdlbGwgYXMgbm90IHN0b3JpbmcgdGhlCndvcmthcm91bmRzIGJ1dCBjb21w dXRpbmcgdGhlbSBvbiB0aGUgZmx5IC0tIGZvciB0aGUgbm9ybWFsIGNhc2UsIHdlCm9ubHkgbmVl ZCB0aGVtIG9uY2UgZm9yIHRoZSBpbml0aWFsIGNvbnRleHQgaW1hZ2UuCi1DaHJpcwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK