From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Fix fallout of fake reset along resume
Date: Mon, 18 Jun 2018 12:10:15 +0300 [thread overview]
Message-ID: <152931301543.7316.10619579273688980694@mbolton-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <20180616202534.18767-1-chris@chris-wilson.co.uk>
Quoting Chris Wilson (2018-06-16 23:25:34)
> commit b2209e62a450 ("drm/i915/execlists: Reset the CSB head tracking on
> reset/sanitization") and commit 1288786b18f7 ("drm/i915: Move GEM sanitize
> from resume_early to resume") show the conflicting requirements on the
> code. We must reset the GPU before trashing live state on a fast resume
> (hibernation debug, or error paths), but we must only reset our state
> tracking iff the GPU is reset (or power cycled). This is tricky if we
> are disabling GPU reset to simulate broken hardware; we reset our state
> tracking but the GPU is left intact and recovers from its stale state.
>
> v2: Again without the assertion for forcewake, no longer required since
> commit b3ee09a4de33 ("drm/i915/ringbuffer: Fix context restore upon reset")
> as the contexts are reset from the CS ensuring everything is powered up.
>
> Fixes: b2209e62a450 ("drm/i915/execlists: Reset the CSB head tracking on reset/sanitization")
> Fixes: 1288786b18f7 ("drm/i915: Move GEM sanitize from resume_early to resume")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-18 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-16 17:12 [PATCH] drm/i915: Fix fallout of fake reset along resume Chris Wilson
2018-06-16 17:59 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-06-16 20:25 ` [PATCH v2] " Chris Wilson
2018-06-18 9:10 ` Joonas Lahtinen [this message]
2018-06-18 9:17 ` Chris Wilson
2018-06-16 21:04 ` ✓ Fi.CI.BAT: success for drm/i915: Fix fallout of fake reset along resume (rev2) Patchwork
2018-06-16 22:21 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152931301543.7316.10619579273688980694@mbolton-mobl.ger.corp.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.