All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/execlists: Pull the w/a LRI emission into a helper
Date: Mon, 18 Jun 2018 14:01:16 +0300	[thread overview]
Message-ID: <152931967631.8339.12662552743935495119@mbolton-mobl.ger.corp.intel.com> (raw)
In-Reply-To: <20180618094150.30895-1-chris@chris-wilson.co.uk>

Quoting Chris Wilson (2018-06-18 12:41:50)
> Having the w/a registers as an open-coded table leaves a trap for the
> unwary; it would be easy to miss incrementing the LRI counter when
> adding a new register to the list. Instead, pull the list of registers
> into a table, so that we only need add new registers to that table
> rather than try and remember important side-effects of earlier chunks of
> GPU instructions.
> 
> Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Not related to this patch, but the lack of OOB check for batch makes
one itch a little bit.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-06-18 11:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18  9:41 [PATCH] drm/i915/execlists: Pull the w/a LRI emission into a helper Chris Wilson
2018-06-18 11:01 ` Joonas Lahtinen [this message]
2018-06-18 11:05   ` Chris Wilson
2018-06-18 14:16   ` Chris Wilson
2018-06-18 11:35 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-18 14:12 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152931967631.8339.12662552743935495119@mbolton-mobl.ger.corp.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.