Re: [Qemu-devel] [PATCH v3 00/26] vhost-user for input & GPU

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180618161729.334-1-marcandre.lureau@redhat.com
Subject: [Qemu-devel] [PATCH v3 00/26] vhost-user for input & GPU

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5b9f38a1ca hw/display: add vhost-user-vga & gpu-pci
326428ad0c virtio-gpu: split virtio-gpu-pci & virtio-vga
875a640573 virtio-gpu: split virtio-gpu, introduce virtio-gpu-base
30f670795b virtio-gpu: remove useless 'waiting' field
8b62eaebc8 virtio-gpu: block both 2d and 3d rendering
099eb18894 virtio-gpu: remove unused config_size
c7ebfdac23 virtio-gpu: remove unused qdev
bcbc153a12 contrib: add vhost-user-gpu
287104e286 util: promote qemu_egl_rendernode_open() to libqemuutil
1734608225 virtio: add virtio-gpu bswap helpers header
fe8a420d35 vhost-user: add vhost_user_gpu_get_num_capsets()
106d9b6c82 vhost-user: add vhost_user_gpu_set_socket()
73ac986cce Add vhost-user-input-pci
7b3ced4f9e contrib: add vhost-user-input
6285d76ff7 libvhost-user: export vug_source_new()
901a25da6d vhost-user: add vhost_user_input_get_config()
7d0d590b7f vhost-user: split vhost_user_read()
a9bdc75110 HACK: vhost-user-backend: allow to specify binary to execute
c228612ab8 Add vhost-user-backend
0617a84bf3 qio: add qio_channel_command_new_spawn_with_pre_exec()
07bff83cac vhost-user: wrap some read/write with retry handling
a836d90351 libvhost-user: exit by default on VHOST_USER_NONE
fc54036235 vhost-user: simplify vhost_user_init/vhost_user_cleanup
9438a02db7 dmabuf: add y0_top, pass it to spice
9074228c84 chardev: remove qemu_chr_fe_write_all() counter
58f6db3fb0 chardev: avoid crash if no associated address

=== OUTPUT BEGIN ===
Checking PATCH 1/26: chardev: avoid crash if no associated address...
Checking PATCH 2/26: chardev: remove qemu_chr_fe_write_all() counter...
Checking PATCH 3/26: dmabuf: add y0_top, pass it to spice...
Checking PATCH 4/26: vhost-user: simplify vhost_user_init/vhost_user_cleanup...
Checking PATCH 5/26: libvhost-user: exit by default on VHOST_USER_NONE...
Checking PATCH 6/26: vhost-user: wrap some read/write with retry handling...
Checking PATCH 7/26: qio: add qio_channel_command_new_spawn_with_pre_exec()...
Checking PATCH 8/26: Add vhost-user-backend...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

total: 0 errors, 1 warnings, 335 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/26: HACK: vhost-user-backend: allow to specify binary to execute...
Checking PATCH 10/26: vhost-user: split vhost_user_read()...
Checking PATCH 11/26: vhost-user: add vhost_user_input_get_config()...
Checking PATCH 12/26: libvhost-user: export vug_source_new()...
Checking PATCH 13/26: contrib: add vhost-user-input...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 403 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 14/26: Add vhost-user-input-pci...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

total: 0 errors, 1 warnings, 215 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 15/26: vhost-user: add vhost_user_gpu_set_socket()...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

total: 0 errors, 1 warnings, 298 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 16/26: vhost-user: add vhost_user_gpu_get_num_capsets()...
Checking PATCH 17/26: virtio: add virtio-gpu bswap helpers header...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 103 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 18/26: util: promote qemu_egl_rendernode_open() to libqemuutil...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 151 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/26: contrib: add vhost-user-gpu...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#133: 
new file mode 100644

total: 0 errors, 1 warnings, 2219 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 20/26: virtio-gpu: remove unused qdev...
Checking PATCH 21/26: virtio-gpu: remove unused config_size...
Checking PATCH 22/26: virtio-gpu: block both 2d and 3d rendering...
Checking PATCH 23/26: virtio-gpu: remove useless 'waiting' field...
Checking PATCH 24/26: virtio-gpu: split virtio-gpu, introduce virtio-gpu-base...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#175: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#1196: FILE: include/hw/virtio/virtio-gpu.h:124:
+#define VIRTIO_GPU_BASE_PROPERTIES(_state, _conf)                       \
+    DEFINE_PROP_UINT32("max_outputs", _state, _conf.max_outputs, 1),    \
+    DEFINE_PROP_UINT32("xres", _state, _conf.xres, 1024),               \
+    DEFINE_PROP_UINT32("yres", _state, _conf.yres, 768)

total: 1 errors, 1 warnings, 1143 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 25/26: virtio-gpu: split virtio-gpu-pci & virtio-vga...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#358: 
new file mode 100644

total: 0 errors, 1 warnings, 373 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 26/26: hw/display: add vhost-user-vga & gpu-pci...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 0 errors, 1 warnings, 647 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com