From: Ian Kent <raven@themaw.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
autofs mailing list <autofs@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/6] autofs - fix clearing AUTOFS_EXP_LEAVES in autofs_expire_indirect()
Date: Tue, 19 Jun 2018 11:02:04 +0800 [thread overview]
Message-ID: <152937732410.21213.7447294898147765076.stgit@pluto.themaw.net> (raw)
In-Reply-To: <152937731702.21213.7371321165189170865.stgit@pluto.themaw.net>
The expire flag AUTOFS_EXP_LEAVES is cleared before the second
call to should_expire() in autofs_expire_indirect() but the
parameter passed in the second call is incorrect.
Fortunately AUTOFS_EXP_LEAVES expire flag has not been used for
a long time but might be needed in the future so fix it rather
than remove the expire leaves functionality.
Signed-off-by: Ian Kent <raven@themaw.net>
---
fs/autofs/expire.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs/expire.c b/fs/autofs/expire.c
index 295feec10ea6..41855cdc5630 100644
--- a/fs/autofs/expire.c
+++ b/fs/autofs/expire.c
@@ -467,7 +467,7 @@ struct dentry *autofs_expire_indirect(struct super_block *sb,
* things have changed.
*/
flags &= ~AUTOFS_EXP_LEAVES;
- found = should_expire(expired, mnt, timeout, how);
+ found = should_expire(expired, mnt, timeout, flags);
if (!found || found != expired)
/* Something has changed, continue */
goto next;
next prev parent reply other threads:[~2018-06-19 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 3:01 [PATCH 1/6] autofs - fix inconsistent use of now variable Ian Kent
2018-06-19 3:02 ` Ian Kent [this message]
2018-06-19 3:02 ` [PATCH 3/6] autofs - make autofs_expire_direct() static Ian Kent
2018-06-19 3:02 ` [PATCH 4/6] autofs - make autofs_expire_indirect() static Ian Kent
2018-06-19 3:02 ` [PATCH 5/6] autofs - make expire flags usage consistent with v5 params Ian Kent
2018-06-19 3:02 ` [PATCH 6/6] autofs - add AUTOFS_EXP_FORCED flag Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152937732410.21213.7447294898147765076.stgit@pluto.themaw.net \
--to=raven@themaw.net \
--cc=akpm@linux-foundation.org \
--cc=autofs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.