From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVR3u-00055o-7e for qemu-devel@nongnu.org; Tue, 19 Jun 2018 20:33:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVR3r-0000s1-2W for qemu-devel@nongnu.org; Tue, 19 Jun 2018 20:33:26 -0400 Received: from mail-pl0-x241.google.com ([2607:f8b0:400e:c01::241]:45104) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVR3q-0000re-SS for qemu-devel@nongnu.org; Tue, 19 Jun 2018 20:33:23 -0400 Received: by mail-pl0-x241.google.com with SMTP id c23-v6so727091plz.12 for ; Tue, 19 Jun 2018 17:33:22 -0700 (PDT) Message-ID: <1529454797.2246.2.camel@gmail.com> From: Suraj Jitindar Singh Date: Wed, 20 Jun 2018 10:33:17 +1000 In-Reply-To: <20180619102550.GA2368@work-vm> References: <20180619044835.18795-1-sjitindarsingh@gmail.com> <20180619102550.GA2368@work-vm> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hmp-commands: use long for begin and length in dump-guest-memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: qemu-devel@nongnu.org, Suraj Jitindar Singh On Tue, 2018-06-19 at 11:25 +0100, Dr. David Alan Gilbert wrote: > * Suraj Jitindar Singh (sjitindarsingh@gmail.com) wrote: > > The dump-guest-memory command is used to dump an area of guest > > memory > > to a file, the piece of memory is specified by a begin address and > > a length. These parameters are specified as ints and thus have a > > maximum > > value of 4GB. This means you can't dump the guest memory past the > > first > > 4GB and instead get: > > (qemu) dump-guest-memory tmp 0x100000000 0x100000000 > > 'dump-guest-memory' has failed: integer is for 32-bit values > > Try "help dump-guest-memory" for more information > > > > This limitation is imposed in monitor_parse_arguments() since they > > are > > both ints. hmp_dump_guest_memory() uses 64 bit quantities to store > > both > > the begin and length values. Thus specify begin and length as long > > so > > that the entire guest memory space can be dumped. > > > > Signed-off-by: Suraj Jitindar Singh > > --- > > hmp-commands.hx | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hmp-commands.hx b/hmp-commands.hx > > index 0734fea931..3b5c1f65db 100644 > > --- a/hmp-commands.hx > > +++ b/hmp-commands.hx > > @@ -1116,7 +1116,7 @@ ETEXI > > > > { > > .name = "dump-guest-memory", > > - .args_type = "paging:-p,detach:-d,zlib:-z,lzo:-l,snappy:- > > s,filename:F,begin:i?,length:i?", > > + .args_type = "paging:-p,detach:-d,zlib:-z,lzo:-l,snappy:- > > s,filename:F,begin:l?,length:l?", > > .params = "[-p] [-d] [-z|-l|-s] filename [begin > > length]", > > .help = "dump guest memory into file > > 'filename'.\n\t\t\t" > > "-p: do paging to get guest's memory > > mapping.\n\t\t\t" > > OK, so hmp_dump_guest_memory in hmp.c already uses int64_t for both, > as does the qmp_dump_guest_memory it calls; so this looks OK. > > Can you repost this please with the correct sign off that I see you > tried to fix in the following mail; best if we get it in the one > mail. Of course. Done :) > > Dave > > > -- > > 2.13.6 > > > > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK