All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <1767176@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1767176] Re: GTK build fails with qemu 2.12.0
Date: Fri, 22 Jun 2018 05:50:50 -0000	[thread overview]
Message-ID: <152964665117.26305.2564685373468531448.launchpad@soybean.canonical.com> (raw)
In-Reply-To: 152476695027.6122.1941123400059547378.malonedeb@chaenomeles.canonical.com

** Changed in: qemu
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1767176

Title:
  GTK build fails with qemu 2.12.0

Status in QEMU:
  Fix Committed

Bug description:
  With the 2.12.0 release of QEMU passing `--enable-gtk` to configure
  causes the build to fail. I'm running macOS 10.13.5 with Xcode 9.3
  FWIW.

  I'm building against GTK 2.24.32, which I appreciate is no longer the
  preferred version here, but I don't think the error is related to that
  aspect. I'll try and find the time later to attempt a GTK3 build to
  check that though.

  ========================================================================
  ui/gtk.c:1147:16: error: use of undeclared identifier 'qemu_input_map_osx_to_qcode'; did you mean 'qemu_input_map_usb_to_qcode'?
          return qemu_input_map_osx_to_qcode;
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                 qemu_input_map_usb_to_qcode
  /private/tmp/qemu-20180426-60786-1av6pq8/qemu-2.12.0/include/ui/input.h:99:22: note: 'qemu_input_map_usb_to_qcode' declared here
  extern const guint16 qemu_input_map_usb_to_qcode[];
                       ^
  ========================================================================

  I tried poking around locally by applying the following diff, based
  off of a very brief glance over the code involved, but that simply
  causes the build to error out in a different way at a later point, so
  I assume I'm doing something stupid.

  ========================================================================
  diff --git a/Makefile b/Makefile
  index d71dd5b..e857c3c 100644
  --- a/Makefile
  +++ b/Makefile
  @@ -313,6 +313,7 @@ KEYCODEMAP_FILES = \
      ui/input-keymap-qnum-to-qcode.c \
      ui/input-keymap-usb-to-qcode.c \
      ui/input-keymap-win32-to-qcode.c \
  +     ui/input-keymap-osx-to-qcode.c \
      ui/input-keymap-x11-to-qcode.c \
      ui/input-keymap-xorgevdev-to-qcode.c \
      ui/input-keymap-xorgkbd-to-qcode.c \
  diff --git a/include/ui/input.h b/include/ui/input.h
  index 16395ab..8183840 100644
  --- a/include/ui/input.h
  +++ b/include/ui/input.h
  @@ -101,6 +101,9 @@ extern const guint16 qemu_input_map_usb_to_qcode[];
   extern const guint qemu_input_map_win32_to_qcode_len;
   extern const guint16 qemu_input_map_win32_to_qcode[];

  +extern const guint qemu_input_map_osx_to_qcode_len;
  +extern const guint16 qemu_input_map_osx_to_qcode[];
  +
   extern const guint qemu_input_map_x11_to_qcode_len;
   extern const guint16 qemu_input_map_x11_to_qcode[];
  ========================================================================

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1767176/+subscriptions

  parent reply	other threads:[~2018-06-22  6:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26 18:22 [Qemu-devel] [Bug 1767176] [NEW] GTK build fails with qemu 2.12.0 Dominyk Tiller
2018-05-02 18:29 ` [Qemu-devel] [Bug 1767176] " Dominyk Tiller
2018-06-21 17:54 ` Dominyk Tiller
2018-06-22  5:50 ` Thomas Huth [this message]
2018-08-21  6:29 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152964665117.26305.2564685373468531448.launchpad@soybean.canonical.com \
    --to=1767176@bugs.launchpad.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.