From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59534C433E0 for ; Tue, 4 Aug 2020 12:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3179B22BED for ; Tue, 4 Aug 2020 12:23:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="UzwdNxt4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726190AbgHDMXQ (ORCPT ); Tue, 4 Aug 2020 08:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730432AbgHDLvp (ORCPT ); Tue, 4 Aug 2020 07:51:45 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EF27C06174A for ; Tue, 4 Aug 2020 04:51:45 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f12so1256646wru.13 for ; Tue, 04 Aug 2020 04:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2ELWcAGsue+IDtTvWvkReKA3Nsf3mb1elZwEp1F2QQ4=; b=UzwdNxt4kpWuAi+8ldfuo2QXKKKg/T0QNquvRRajdXtqxA3GhsbOgTAbE5hBeDKZiR jHJOe19bBvloWrG2APoOpPsBMlW4LRQIWiL7NiWcTxzCj8Uu/96wg8xOT2rb5p7ZVL9p LGQXgImy1L0ZhRBot7cx0S3DFwG2seCI7xJxLnFOjnc0HjjLJzbLnBGyySTKYMMNzni7 BuJFIlXOseO8ESM63+cQ9C01wne5YqURdAwJrDdvzugRenu/GNzu44eADZskP5idgHci iaeANBtvIeDg1pm2d9jXwQXbOYqK4zQ/4Ex/affnN5i/RTcYyhH5F1X1hjj/HmJbJCy8 bhgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2ELWcAGsue+IDtTvWvkReKA3Nsf3mb1elZwEp1F2QQ4=; b=OC6vwMbx74epCpuhaRQzgZamz3Doj5OLsebQnVbUFZUDt/VpuPwizFAoa+4cdQqVJn jQj+7BPnsqDlsgYm6Zxmkdz77ehXOjOWSQzEppDWjM1MIvPEI5bper9sMXQyY6eG8MbO 73guzTIDgvXTR+sGMbKl/Zhwku4AVKSx0Hf5JhYosfrh5mMPit+VACZIbJOhtvwJ1XK+ RVJtM/vFRS3SGy7oYNmnaxVeGQm1LMWiJD1X8wdSB5GB5awiInkaSbdXvig3yEcJmHLQ WUyN1aBQ6x7rdmnTrstUQvkETbVyuPoFDzSHpuXO3dIkx7Wf652WXNfMGH4xN2wrJZQp BG/g== X-Gm-Message-State: AOAM530/vcMQjJmorJY1JGfGEHuNPzxCtyEts7OTZLWlNotgF7MjRNNM a24TihwwA7tDIZbkQcprONw= X-Google-Smtp-Source: ABdhPJz4CtJn78DqgQgrxiQLspbJ67GLLoKo7Nh8c1Px4oo7tSv256QeYgPXK0lZTc7OvVBr1HfBLg== X-Received: by 2002:adf:b602:: with SMTP id f2mr3141628wre.186.1596541903682; Tue, 04 Aug 2020 04:51:43 -0700 (PDT) Received: from [192.168.1.20] ([213.122.218.185]) by smtp.googlemail.com with ESMTPSA id c4sm29759277wrt.41.2020.08.04.04.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2020 04:51:43 -0700 (PDT) Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on Intel NUC boxes To: =?UTF-8?B?5ZCz5piK5r6EIFJpY2t5?= , "gregkh@linuxfoundation.org" Cc: LKML , "rdunlap@infradead.org" , "philquadra@gmail.com" , Arnd Bergmann References: <862172f0-cd23-800c-27b1-27cb49e99099@googlemail.com> <5729c72bbc2740d3917619c85e2fde58@realtek.com> <20200804074831.GB1761483@kroah.com> <11e224ca299b48f1bea07082f2ff7c00@realtek.com> <0afbd711-0bda-d9a3-138d-5c713b4e2ed9@googlemail.com> <19de15c2f07d447dace6bea483d38159@realtek.com> From: Chris Clayton Message-ID: <152ef6c0-f3c0-bb67-4175-adced3c720cd@googlemail.com> Date: Tue, 4 Aug 2020 12:51:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <19de15c2f07d447dace6bea483d38159@realtek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2020 11:46, 吳昊澄 Ricky wrote: >> -----Original Message----- >> From: Chris Clayton [mailto:chris2553@googlemail.com] >> Sent: Tuesday, August 04, 2020 4:51 PM >> To: 吳昊澄 Ricky; gregkh@linuxfoundation.org >> Cc: LKML; rdunlap@infradead.org; philquadra@gmail.com; Arnd Bergmann >> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on >> Intel NUC boxes >> >> >> >> On 04/08/2020 09:08, 吳昊澄 Ricky wrote: >>>> -----Original Message----- >>>> From: gregkh@linuxfoundation.org [mailto:gregkh@linuxfoundation.org] >>>> Sent: Tuesday, August 04, 2020 3:49 PM >>>> To: 吳昊澄 Ricky >>>> Cc: Chris Clayton; LKML; rdunlap@infradead.org; philquadra@gmail.com; >> Arnd >>>> Bergmann >>>> Subject: Re: PATCH: rtsx_pci driver - don't disable the rts5229 card reader on >>>> Intel NUC boxes >>>> >>>> On Tue, Aug 04, 2020 at 02:44:41AM +0000, 吳昊澄 Ricky wrote: >>>>> Hi Chris, >>>>> >>>>> rtsx_pci_write_register(pcr, FPDTL, OC_POWER_DOWN, >> OC_POWER_DOWN); >>>>> This register operation saved power under 1mA, so if do not care the 1mA >>>> power we can have a patch to remove it, make compatible with NUC6 >>>>> We tested others our card reader that remove it, we did not see any side >> effect >>>>> >>>>> Hi Greg k-h, >>>>> >>>>> Do you have any comments? >>>> >>>> comments on what? I don't know what you are responding to here, sorry. >>>> >>> Can we have a patch to kernel for NUC6? It may cause more power(1mA) but it >> will have more compatibility >>> >> >> Ricky, >> >> I don't understand why you want to completely remove the code that sets up the >> 1mA power saving. That code was there >> even before your patch (bede03a579b3b4a036003c4862cc1baa4ddc351f), so I >> assume it benefits some of the Realtek card >> readers. Before your patch however, rtsx_pci_init_ocp() was not called for the >> rts5229 reader, but the patch introduced >> an unconditional call to that function into rtsx_pci_init_hw(), which is run for the >> rts5229. That is what now disables >> the card reader. >> >> Now, I don't know whether other cards are affected, although I don't recall >> seeing any reported as I searched the kernel >> and ubuntu bugzillas for any analysis of the problem. I know this is not what the >> patch I sent does, but having thought >> about it more, seems to me that the simplest fix is to skip the new call to >> rtsx_pci_init_ocp() if the reader is an rts5229. >> > > Because we are thinking about if others our card reader that not belong A series(my ocp patch coverage) also on NUC6 platform maybe have the same problem... > OK. What if we do make the new call but only for the card readers that are in the A series? Are they the ones that have PID_5nnn defines in include/linux/rtsx_pci.h? Or is there another simple way of identifying that a reader is a member of the A series? I'm thinking of something like: static bool rtsx_pci_is_series_A(pcr) { unsigned short device = pcr->pci->device; return device == PID524A || device == PID_5249 || device == PID_5250 || device == PID_525A || device == PID_525A || device == PID_5260 || device == PID_5261; } then in rtsx_pci_init_hw() change the unconditional call to: if rtsx_pci_is_series_A(pcr) rtsx_pci_init_ocp(); Does that seem OK? >> If you agree, I can prepare a patch and send it to you. Whatever the solution is, it >> will also be needed in the stable >> kernels later than 5.0. >> > > OK, I agree your opinion, for now can only patch rts5229 first make NUC6 user can work well > > Thank you > >> Chris >>>> greg k-h >>>> >>>> ------Please consider the environment before printing this e-mail.