All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@redhat.com, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 07/10] xfs_scrub: rename NOFIX_COMPLAIN to be less confusing
Date: Tue, 26 Jun 2018 19:48:35 -0700	[thread overview]
Message-ID: <153006771523.20121.7089644598888393327.stgit@magnolia> (raw)
In-Reply-To: <153006766483.20121.9285982017465570544.stgit@magnolia>

From: Darrick J. Wong <darrick.wong@oracle.com>

Rename NOFIX_COMPLAIN to COMPLAIN_IF_UNFIXED so that the symbolic name
is less confusing as to what the flag is supposed to mean.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 scrub/phase4.c |    2 +-
 scrub/repair.h |    2 +-
 scrub/scrub.c  |    6 +++---
 scrub/scrub.h  |    2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)


diff --git a/scrub/phase4.c b/scrub/phase4.c
index 01a073bc..7ae6b7cf 100644
--- a/scrub/phase4.c
+++ b/scrub/phase4.c
@@ -69,7 +69,7 @@ xfs_repair_ag(
 		return;
 
 	/* Try once more, but this time complain if we can't fix things. */
-	flags |= ALP_NOFIX_COMPLAIN;
+	flags |= ALP_COMPLAIN_IF_UNFIXED;
 	moveon = xfs_action_list_process(ctx, ctx->mnt_fd, alist, flags);
 	if (!moveon)
 		*pmoveon = false;
diff --git a/scrub/repair.h b/scrub/repair.h
index 4be950e7..c8693ccf 100644
--- a/scrub/repair.h
+++ b/scrub/repair.h
@@ -29,7 +29,7 @@ void xfs_action_list_find_mustfix(struct xfs_action_list *actions,
 
 /* Passed through to xfs_repair_metadata() */
 #define ALP_REPAIR_ONLY		(XRM_REPAIR_ONLY)
-#define ALP_NOFIX_COMPLAIN	(XRM_NOFIX_COMPLAIN)
+#define ALP_COMPLAIN_IF_UNFIXED	(XRM_COMPLAIN_IF_UNFIXED)
 #define ALP_NOPROGRESS		(1U << 31)
 
 bool xfs_action_list_process(struct scrub_ctx *ctx, int fd,
diff --git a/scrub/scrub.c b/scrub/scrub.c
index fe4e880f..2ac146a9 100644
--- a/scrub/scrub.c
+++ b/scrub/scrub.c
@@ -762,7 +762,7 @@ xfs_repair_metadata(
 	 * If the caller doesn't want us to complain, tell the caller to
 	 * requeue the repair for later and don't say a thing.
 	 */
-	if (!(repair_flags & XRM_NOFIX_COMPLAIN) &&
+	if (!(repair_flags & XRM_COMPLAIN_IF_UNFIXED) &&
 	    (error || needs_repair(&meta)))
 		return CHECK_RETRY;
 	if (error) {
@@ -815,11 +815,11 @@ _("Read-only filesystem; cannot make changes."));
 			return CHECK_DONE;
 		}
 	}
-	if (repair_flags & XRM_NOFIX_COMPLAIN)
+	if (repair_flags & XRM_COMPLAIN_IF_UNFIXED)
 		xfs_scrub_warn_incomplete_scrub(ctx, buf, &meta);
 	if (needs_repair(&meta)) {
 		/* Still broken, try again or fix offline. */
-		if ((repair_flags & XRM_NOFIX_COMPLAIN) || debug)
+		if ((repair_flags & XRM_COMPLAIN_IF_UNFIXED) || debug)
 			str_error(ctx, buf,
 _("Repair unsuccessful; offline repair required."));
 	} else {
diff --git a/scrub/scrub.h b/scrub/scrub.h
index fdcbd40d..701a01ae 100644
--- a/scrub/scrub.h
+++ b/scrub/scrub.h
@@ -86,7 +86,7 @@ struct action_item {
 #define XRM_REPAIR_ONLY		(1U << 0)
 
 /* Complain if still broken even after fix. */
-#define XRM_NOFIX_COMPLAIN	(1U << 1)
+#define XRM_COMPLAIN_IF_UNFIXED	(1U << 1)
 
 enum check_outcome xfs_repair_metadata(struct scrub_ctx *ctx, int fd,
 		struct action_item *aitem, unsigned int repair_flags);


  parent reply	other threads:[~2018-06-27  2:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  2:47 [PATCH 00/10] xfsprogs-4.18: mostly scrub/repair stuff Darrick J. Wong
2018-06-27  2:47 ` [PATCH 01/10] libxfs: remove crc32 functions Darrick J. Wong
2018-06-27  2:47 ` [PATCH 02/10] libfrog: move crc32c code out of libxfs Darrick J. Wong
2018-06-27  2:48 ` [PATCH 03/10] xfs_scrub: destroy workqueues when erroring out Darrick J. Wong
2018-07-26  0:29   ` Eric Sandeen
2018-06-27  2:48 ` [PATCH 04/10] xfs_scrub: schedule and manage optimizations/repairs to the filesystem Darrick J. Wong
2018-07-26  1:06   ` Eric Sandeen
2018-07-26  1:17     ` Darrick J. Wong
2018-06-27  2:48 ` [PATCH 05/10] xfs_scrub: allow developers to force repairs Darrick J. Wong
2018-07-26  1:07   ` Eric Sandeen
2018-06-27  2:48 ` [PATCH 06/10] xfs_scrub: don't error out if an optimize-only repair isn't supported Darrick J. Wong
2018-07-26  1:09   ` Eric Sandeen
2018-06-27  2:48 ` Darrick J. Wong [this message]
2018-07-26  1:10   ` [PATCH 07/10] xfs_scrub: rename NOFIX_COMPLAIN to be less confusing Eric Sandeen
2018-06-27  2:48 ` [PATCH 08/10] xfs_scrub: only retry non-permanent repair failures Darrick J. Wong
2018-07-26  1:16   ` Eric Sandeen
2018-07-26  1:19     ` Darrick J. Wong
2018-06-27  2:48 ` [PATCH 09/10] xfs_io: wire up repair ioctl stuff Darrick J. Wong
2018-07-26  1:23   ` Eric Sandeen
2018-06-27  2:48 ` [PATCH 10/10] xfs_repair: use libxfs extsize/cowextsize validation helpers Darrick J. Wong
2018-06-27  3:25   ` Eric Sandeen
2018-06-28 17:28     ` Darrick J. Wong
2018-06-28 17:29 ` [PATCH 11/10] xfs_repair: clear extent size hints when clearing inode core Darrick J. Wong
2018-06-28 19:24   ` Eric Sandeen
2018-06-28 17:30 ` [PATCH 12/10] xfs_repair: use libxfs extsize/cowextsize validation helpers Darrick J. Wong
2018-07-26  1:44   ` Eric Sandeen
2018-07-26  1:48     ` Eric Sandeen
2018-07-26 20:38   ` [PATCH v2 " Darrick J. Wong
2018-07-27 22:44     ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153006771523.20121.7089644598888393327.stgit@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.