From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [-next] dmaengine: fsl-edma: fix the error return code in mcf_edma_probe() From: "weiyongjun \(A\)" Message-Id: <1530692511-191869-1-git-send-email-weiyongjun1@huawei.com> Date: Wed, 4 Jul 2018 08:21:51 +0000 To: Vinod Koul , Dan Williams , Angelo Dureghello Cc: Wei Yongjun , dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: VGhlIGVycm9yIHJldHVybiBjb2RlIFBUUl9FUlIocGRhdGEpIGlzIGFsd2F5cyAwIHNpbmNlIHBk YXRhIGlzCk5VTEwgaW4gdGhpcyBlcnJvciBoYW5kbGluZyBjYXNlLgoKRml4ZXM6IDVjMTM1NWFk ODdhMiAoImRtYWVuZ2luZTogZnNsLWVkbWE6IGFkZCBDb2xkRmlyZSBtY2Y1NDQxeCBlZG1hIHN1 cHBvcnQiKQpTaWduZWQtb2ZmLWJ5OiBXZWkgWW9uZ2p1biA8d2VpeW9uZ2p1bjFAaHVhd2VpLmNv bT4KLS0tCiBkcml2ZXJzL2RtYS9tY2YtZWRtYS5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgoKLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlz IGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGRtYWVuZ2luZSIgaW4KdGhlIGJvZHkg b2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8g aW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCgpkaWZm IC0tZ2l0IGEvZHJpdmVycy9kbWEvbWNmLWVkbWEuYyBiL2RyaXZlcnMvZG1hL21jZi1lZG1hLmMK aW5kZXggMzFlNTMxNy4uNzg3YjdiNiAxMDA2NDQKLS0tIGEvZHJpdmVycy9kbWEvbWNmLWVkbWEu YworKysgYi9kcml2ZXJzL2RtYS9tY2YtZWRtYS5jCkBAIC0xNzUsNyArMTc1LDcgQEAgc3RhdGlj IGludCBtY2ZfZWRtYV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQogCiAJcGRh dGEgPSBkZXZfZ2V0X3BsYXRkYXRhKCZwZGV2LT5kZXYpOwogCWlmICghcGRhdGEpCi0JCXJldHVy biBQVFJfRVJSKHBkYXRhKTsKKwkJcmV0dXJuIC1FSU5WQUw7CiAKIAljaGFucyA9IHBkYXRhLT5k bWFfY2hhbm5lbHM7CiAJbGVuID0gc2l6ZW9mKCptY2ZfZWRtYSkgKyBzaXplb2YoKm1jZl9jaGFu KSAqIGNoYW5zOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yongjun Date: Wed, 04 Jul 2018 08:21:51 +0000 Subject: [PATCH -next] dmaengine: fsl-edma: fix the error return code in mcf_edma_probe() Message-Id: <1530692511-191869-1-git-send-email-weiyongjun1@huawei.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vinod Koul , Dan Williams , Angelo Dureghello Cc: Wei Yongjun , dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org The error return code PTR_ERR(pdata) is always 0 since pdata is NULL in this error handling case. Fixes: 5c1355ad87a2 ("dmaengine: fsl-edma: add ColdFire mcf5441x edma support") Signed-off-by: Wei Yongjun --- drivers/dma/mcf-edma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/mcf-edma.c b/drivers/dma/mcf-edma.c index 31e5317..787b7b6 100644 --- a/drivers/dma/mcf-edma.c +++ b/drivers/dma/mcf-edma.c @@ -175,7 +175,7 @@ static int mcf_edma_probe(struct platform_device *pdev) pdata = dev_get_platdata(&pdev->dev); if (!pdata) - return PTR_ERR(pdata); + return -EINVAL; chans = pdata->dma_channels; len = sizeof(*mcf_edma) + sizeof(*mcf_chan) * chans;