From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72832C1B0E3 for ; Wed, 11 Jul 2018 21:06:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 244532146F for ; Wed, 11 Jul 2018 21:06:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 244532146F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387581AbeGKVM2 (ORCPT ); Wed, 11 Jul 2018 17:12:28 -0400 Received: from mga03.intel.com ([134.134.136.65]:30442 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732552AbeGKVM1 (ORCPT ); Wed, 11 Jul 2018 17:12:27 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 14:06:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,339,1526367600"; d="scan'208";a="66171654" Received: from 2b52.sc.intel.com ([143.183.136.52]) by fmsmga002.fm.intel.com with ESMTP; 11 Jul 2018 14:06:14 -0700 Message-ID: <1531342956.15351.38.camel@intel.com> Subject: Re: [RFC PATCH v2 27/27] x86/cet: Add arch_prctl functions for CET From: Yu-cheng Yu To: Florian Weimer , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , "Ravi V. Shankar" , Vedvyas Shanbhogue Date: Wed, 11 Jul 2018 14:02:36 -0700 In-Reply-To: References: <20180710222639.8241-1-yu-cheng.yu@intel.com> <20180710222639.8241-28-yu-cheng.yu@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-07-11 at 14:19 +0200, Florian Weimer wrote: > On 07/11/2018 12:26 AM, Yu-cheng Yu wrote: > > > > arch_prctl(ARCH_CET_DISABLE, unsigned long features) > >      Disable SHSTK and/or IBT specified in 'features'.  Return > > -EPERM > >      if CET is locked out. > > > > arch_prctl(ARCH_CET_LOCK) > >      Lock out CET feature. > Isn't it a “lock in” rather than a “lock out”? Yes, that makes more sense.  I will fix it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 46D9C7D072 for ; Wed, 11 Jul 2018 21:06:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732695AbeGKVM2 (ORCPT ); Wed, 11 Jul 2018 17:12:28 -0400 Received: from mga03.intel.com ([134.134.136.65]:30442 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732552AbeGKVM1 (ORCPT ); Wed, 11 Jul 2018 17:12:27 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 14:06:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,339,1526367600"; d="scan'208";a="66171654" Received: from 2b52.sc.intel.com ([143.183.136.52]) by fmsmga002.fm.intel.com with ESMTP; 11 Jul 2018 14:06:14 -0700 Message-ID: <1531342956.15351.38.camel@intel.com> Subject: Re: [RFC PATCH v2 27/27] x86/cet: Add arch_prctl functions for CET From: Yu-cheng Yu To: Florian Weimer , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , "Ravi V. Shankar" , Vedvyas Shanbhogue Date: Wed, 11 Jul 2018 14:02:36 -0700 In-Reply-To: References: <20180710222639.8241-1-yu-cheng.yu@intel.com> <20180710222639.8241-28-yu-cheng.yu@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, 2018-07-11 at 14:19 +0200, Florian Weimer wrote: > On 07/11/2018 12:26 AM, Yu-cheng Yu wrote: > > > > arch_prctl(ARCH_CET_DISABLE, unsigned long features) > >      Disable SHSTK and/or IBT specified in 'features'.  Return > > -EPERM > >      if CET is locked out. > > > > arch_prctl(ARCH_CET_LOCK) > >      Lock out CET feature. > Isn't it a “lock in” rather than a “lock out”? Yes, that makes more sense.  I will fix it. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu-cheng Yu Subject: Re: [RFC PATCH v2 27/27] x86/cet: Add arch_prctl functions for CET Date: Wed, 11 Jul 2018 14:02:36 -0700 Message-ID: <1531342956.15351.38.camel@intel.com> References: <20180710222639.8241-1-yu-cheng.yu@intel.com> <20180710222639.8241-28-yu-cheng.yu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Florian Weimer , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek Peter List-Id: linux-api@vger.kernel.org On Wed, 2018-07-11 at 14:19 +0200, Florian Weimer wrote: > On 07/11/2018 12:26 AM, Yu-cheng Yu wrote: > > > > arch_prctl(ARCH_CET_DISABLE, unsigned long features) > >      Disable SHSTK and/or IBT specified in 'features'.  Return > > -EPERM > >      if CET is locked out. > > > > arch_prctl(ARCH_CET_LOCK) > >      Lock out CET feature. > Isn't it a “lock in” rather than a “lock out”? Yes, that makes more sense.  I will fix it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f69.google.com (mail-pl0-f69.google.com [209.85.160.69]) by kanga.kvack.org (Postfix) with ESMTP id 27B786B0010 for ; Wed, 11 Jul 2018 17:06:16 -0400 (EDT) Received: by mail-pl0-f69.google.com with SMTP id y2-v6so5812402pll.16 for ; Wed, 11 Jul 2018 14:06:16 -0700 (PDT) Received: from mga17.intel.com (mga17.intel.com. [192.55.52.151]) by mx.google.com with ESMTPS id z125-v6si3867945pfz.10.2018.07.11.14.06.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jul 2018 14:06:15 -0700 (PDT) Message-ID: <1531342956.15351.38.camel@intel.com> Subject: Re: [RFC PATCH v2 27/27] x86/cet: Add arch_prctl functions for CET From: Yu-cheng Yu Date: Wed, 11 Jul 2018 14:02:36 -0700 In-Reply-To: References: <20180710222639.8241-1-yu-cheng.yu@intel.com> <20180710222639.8241-28-yu-cheng.yu@intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Florian Weimer , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , "Ravi V. Shankar" , Vedvyas Shanbhogue On Wed, 2018-07-11 at 14:19 +0200, Florian Weimer wrote: > On 07/11/2018 12:26 AM, Yu-cheng Yu wrote: > > > > arch_prctl(ARCH_CET_DISABLE, unsigned long features) > > A A A A A Disable SHSTK and/or IBT specified in 'features'.A A Return > > -EPERM > > A A A A A if CET is locked out. > > > > arch_prctl(ARCH_CET_LOCK) > > A A A A A Lock out CET feature. > Isn't it a a??lock ina?? rather than a a??lock outa??? Yes, that makes more sense. A I will fix it.