From: Arun Kumar Neelakantam <aneela@codeaurora.org>
To: ohad@wizery.com, bjorn.andersson@linaro.org, clew@codeaurora.org,
robh+dt@kernel.org, arnaud.pouliquen@st.com,
andy.gross@linaro.org
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Arun Kumar Neelakantam <aneela@codeaurora.org>
Subject: [PATCH V4 4/9] rpmsg: Guard against null endpoint ops in destroy
Date: Fri, 27 Jul 2018 17:47:24 +0530 [thread overview]
Message-ID: <1532693849-7037-5-git-send-email-aneela@codeaurora.org> (raw)
In-Reply-To: <1532693849-7037-1-git-send-email-aneela@codeaurora.org>
From: Chris Lew <clew@codeaurora.org>
In RPMSG GLINK the chrdev device will allocate an ept as part of the
rpdev creation. This device will not register endpoint ops even though
it has an allocated ept. Protect against the case where the device is
being destroyed.
Signed-off-by: Chris Lew <clew@codeaurora.org>
Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
---
drivers/rpmsg/rpmsg_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
index b714a54..0860328 100644
--- a/drivers/rpmsg/rpmsg_core.c
+++ b/drivers/rpmsg/rpmsg_core.c
@@ -80,7 +80,7 @@ struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev,
*/
void rpmsg_destroy_ept(struct rpmsg_endpoint *ept)
{
- if (ept)
+ if (ept && ept->ops)
ept->ops->destroy_ept(ept);
}
EXPORT_SYMBOL(rpmsg_destroy_ept);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-07-27 12:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 12:17 [PATCH V4 0/9] Add chrdev and name query support for GLINK Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 1/9] dt-bindings: soc: qcom: Add label for GLINK bindings Arun Kumar Neelakantam
2018-07-27 12:17 ` Arun Kumar Neelakantam
2018-07-30 22:30 ` Rob Herring
2018-07-30 22:30 ` Rob Herring
2018-07-27 12:17 ` [PATCH V4 2/9] rpmsg: glink: Store edge name for glink device Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 3/9] rpmsg: glink: Use complete_all for open states Arun Kumar Neelakantam
2018-07-27 12:17 ` Arun Kumar Neelakantam [this message]
2018-07-27 12:17 ` [PATCH V4 5/9] rpmsg: glink: Add support for rpmsg glink chrdev Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 6/9] rpmsg: glink: Expose rpmsg name attr for glink Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 7/9] rpmsg: glink: Remove chunk size word align warning Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 8/9] rpmsg: glink: unregister rpmsg device during endpoint destroy Arun Kumar Neelakantam
2018-07-27 12:17 ` [PATCH V4 9/9] rpmsg: Add compat ioctl for rpmsg char driver Arun Kumar Neelakantam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532693849-7037-5-git-send-email-aneela@codeaurora.org \
--to=aneela@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.