From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] net/mlx4: Avoid stripping the glue library
Date: Tue, 31 Jul 2018 14:30:42 +0100
Message-ID: <1533043842.20916.48.camel@debian.org>
References: <99e701e9982397b2d3febb2f36309225481158e9.1533042801.git.tredaelli@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Timothy Redaelli <tredaelli@redhat.com>, Matan Azrad
 <matan@mellanox.com>,  Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66])
 by dpdk.org (Postfix) with ESMTP id 0C399F72
 for <dev@dpdk.org>; Tue, 31 Jul 2018 15:30:45 +0200 (CEST)
Received: by mail-wm0-f66.google.com with SMTP id f21-v6so3085830wmc.5
 for <dev@dpdk.org>; Tue, 31 Jul 2018 06:30:45 -0700 (PDT)
In-Reply-To: <99e701e9982397b2d3febb2f36309225481158e9.1533042801.git.tredaelli@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote:
> Stripping binaries at build time is usually a bad thing since it
> makes
> impossible to generate (split) debug symbols and this can lead to a
> more
> difficult debugging.
>=20
> CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in")
>=20
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> =C2=A0drivers/net/mlx4/Makefile | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile
> index 63bc00337..92e932250 100644
> --- a/drivers/net/mlx4/Makefile
> +++ b/drivers/net/mlx4/Makefile
> @@ -115,7 +115,7 @@ endif
> =C2=A0$(LIB_GLUE): mlx4_glue.o
> =C2=A0	$Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> =C2=A0		-Wl,-h,$(LIB_GLUE) \
> -		-s -shared -o $@ $< -libverbs -lmlx4
> +		-shared -o $@ $< -libverbs -lmlx4
> =C2=A0
> =C2=A0mlx4_glue.o: mlx4_autoconf.h

Acked-by: Luca Boccassi <bluca@debian.org>

Automated tools to generate separate packages with debug symbols (the
standard at least in Debian and derivatives distros) break if a library
is stripped, and it's very hard to notice as well as it's not an error
per se.

--=20
Kind regards,
Luca Boccassi