From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] net/mlx5: Avoid stripping the glue library
Date: Tue, 31 Jul 2018 14:31:03 +0100
Message-ID: <1533043863.20916.49.camel@debian.org>
References: <b467b0280830c94fba9078707c8af85214ce4ed7.1533042803.git.tredaelli@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Timothy Redaelli <tredaelli@redhat.com>, Shahaf Shuler
 <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id AB4FFF72
 for <dev@dpdk.org>; Tue, 31 Jul 2018 15:31:04 +0200 (CEST)
Received: by mail-wr1-f66.google.com with SMTP id j5-v6so16690389wrr.8
 for <dev@dpdk.org>; Tue, 31 Jul 2018 06:31:04 -0700 (PDT)
In-Reply-To: <b467b0280830c94fba9078707c8af85214ce4ed7.1533042803.git.tredaelli@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote:
> Stripping binaries at build time is usually a bad thing since it
> makes
> impossible to generate (split) debug symbols and this can lead to a
> more
> difficult debugging.
>=20
> CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in")
>=20
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> =C2=A0drivers/net/mlx5/Makefile | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> index 75bee4640..2e70dec5b 100644
> --- a/drivers/net/mlx5/Makefile
> +++ b/drivers/net/mlx5/Makefile
> @@ -409,7 +409,7 @@ endif
> =C2=A0$(LIB_GLUE): mlx5_glue.o
> =C2=A0	$Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> =C2=A0		-Wl,-h,$(LIB_GLUE) \
> -		-s -shared -o $@ $< -libverbs -lmlx5
> +		-shared -o $@ $< -libverbs -lmlx5
> =C2=A0
> =C2=A0mlx5_glue.o: mlx5_autoconf.h

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi