All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/execlists: Terminate the context image with BB_END
Date: Tue, 31 Jul 2018 22:58:41 +0100	[thread overview]
Message-ID: <153307432107.4975.10220093082452886079@skylake-alporthouse-com> (raw)
In-Reply-To: <294d28aa-cea6-3383-0274-a575af102cf0@intel.com>

Quoting Lionel Landwerlin (2018-07-31 13:47:32)
> On 30/07/18 17:43, Chris Wilson wrote:
> > In the aub trace utility, the context images are terminated with a
> > MI_BATCH_BUFFER_END; the simulator is reported as complaining otherwise.
> > Do the same for our protocontext image for completeness, and in passing
> > apply the magic bit for gen10 to mark the end of the context image.
> >
> > Reported-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> 
> Doesn't look like anything exploded.
> Have you noticed any improvement maybe in the benchmarks?

Haven't found anything that shows a difference. I expect that after the
first save, the context image has grown the BB_END.

I was going to dissect the default context image to see if that was
true.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2018-07-31 21:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 16:28 [PATCH] drm/i915/execlists: Terminate the context image with BB_END Chris Wilson
2018-07-30 16:38 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-07-30 16:43 ` [PATCH] " Chris Wilson
2018-07-31 12:47   ` Lionel Landwerlin
2018-07-31 21:58     ` Chris Wilson [this message]
2018-08-01 16:03     ` Chris Wilson
2018-07-30 17:31 ` ✓ Fi.CI.BAT: success for drm/i915/execlists: Terminate the context image with BB_END (rev2) Patchwork
2018-07-30 19:52 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153307432107.4975.10220093082452886079@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lionel.g.landwerlin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.