All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows
Date: Wed, 01 Aug 2018 09:22:51 +0100	[thread overview]
Message-ID: <153311177179.5022.15207516841263853624@skylake-alporthouse-com> (raw)
In-Reply-To: <20180731234504.5553-1-paulo.r.zanoni@intel.com>

Quoting Paulo Zanoni (2018-08-01 00:45:04)
> +static bool icl_tc_phy_connect(struct drm_i915_private *dev_priv,
> +                              struct intel_digital_port *dig_port)
> +{
> +       enum tc_port tc_port = intel_port_to_tc(dev_priv, dig_port->base.port);
> +       u32 val;
> +
> +       if (dig_port->tc_type != TC_PORT_LEGACY &&
> +           dig_port->tc_type != TC_PORT_TYPEC)
> +               return true;
> +
> +       val = I915_READ(PORT_TX_DFLEXDPPMS);
> +       if (!(val & DP_PHY_MODE_STATUS_COMPLETED(tc_port))) {
> +               DRM_ERROR("DP PHY for TC port %d not ready\n", tc_port);
> +               return false;

This is going to be hit as soon as someone manages to plug&unplug the
cable rapidly enough, The callers all handle the bool return so why
proclaim error on their behalf?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-08-01  8:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 23:45 [PATCH] drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows Paulo Zanoni
2018-08-01  0:21 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-08-01  1:15 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-01  8:22 ` Chris Wilson [this message]
2018-08-01 17:05   ` [PATCH] " Paulo Zanoni
2018-08-01 17:34 ` [PATCH v3] " Paulo Zanoni
2018-08-17 16:25   ` Srivatsa, Anusha
2018-08-17 23:27     ` Paulo Zanoni
2018-08-23  1:07   ` Rodrigo Vivi
2018-08-01 18:34 ` ✗ Fi.CI.BAT: failure for drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows (rev2) Patchwork
2018-08-23 22:17 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-23 23:30 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153311177179.5022.15207516841263853624@skylake-alporthouse-com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.