Re: [PATCH v2 0/6] Link Bonding mode 6 support (ALB)

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2015-02-19 09:18, Jastrzebski, MichalX K:
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > 2015-02-13 16:12, Declan Doherty:
> > > On 13/02/15 15:16, Michal Jastrzebski wrote:
> > > > Michal Jastrzebski (6):
> > > >    net: changed arp_hdr struct declaration
> > > >    bond: add link bonding mode 6 implementation
> > > >    bond: add debug info for mode 6 link bonding
> > > >    bond: add example application for link bonding mode 6
> > > >    bond: modify TLB unit tests
> > > >    bond: add unit tests for link bonding mode 6.
> > 
> Hi Thomas,
> > You didn't sign some of these patches. So I suspect that you should
> > fix some authorship.
> That's because I am not an author of all of these patches - 1/6, 5/6 and 6/6

You probably broke it by importing patches with "patch" command instead of "git am".
Then you must fix the authorship in your git tree before sending.

> > Some of the patches make some changes without explaining why.
> I noticed 5/6 has got incomplete description. Probably it disappeared during edition.

Yes please ask yourself why each patch is done, and check it's explained in commit log.

> > > Series Acked-by: Declan Doherty <declan.doherty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > 
> > Please, use checkpatch before submitting and/or when reviewing.
> I was using checkptach.pl, and have no errors, but I will check again.
> Maybe I overlooked something.
> > 
> > A v3 is needed.
> 
> Best regards
> Michal