* [PATCH -next] drm/vkms: Fix the error handling in vkms_init()
@ 2018-08-02 9:04 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-08-02 8:57 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rodrigo Siqueira, Gustavo Padovan,
Haneen Mohammed
Cc: Wei Yongjun, dri-devel, linux-kernel, kernel-janitors
In the drm_vblank_init() error handling case, platform device
unregister is missing. This patch fix it.
Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 6e728b8..5ad09d4 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -110,7 +110,7 @@ static int __init vkms_init(void)
ret = drm_vblank_init(&vkms_device->drm, 1);
if (ret) {
DRM_ERROR("Failed to vblank\n");
- goto out_fini;
+ goto out_unregister;
}
ret = vkms_modeset_init(vkms_device);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] drm/vkms: Fix the error handling in vkms_init()
@ 2018-08-02 9:04 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-08-02 9:04 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rodrigo Siqueira, Gustavo Padovan,
Haneen Mohammed
Cc: Wei Yongjun, dri-devel, linux-kernel, kernel-janitors
In the drm_vblank_init() error handling case, platform device
unregister is missing. This patch fix it.
Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 6e728b8..5ad09d4 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -110,7 +110,7 @@ static int __init vkms_init(void)
ret = drm_vblank_init(&vkms_device->drm, 1);
if (ret) {
DRM_ERROR("Failed to vblank\n");
- goto out_fini;
+ goto out_unregister;
}
ret = vkms_modeset_init(vkms_device);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] drm/vkms: Fix the error handling in vkms_init()
@ 2018-08-02 9:04 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-08-02 9:04 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Rodrigo Siqueira, Gustavo Padovan,
Haneen Mohammed
Cc: Wei Yongjun, dri-devel, linux-kernel, kernel-janitors
In the drm_vblank_init() error handling case, platform device
unregister is missing. This patch fix it.
Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 6e728b8..5ad09d4 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -110,7 +110,7 @@ static int __init vkms_init(void)
ret = drm_vblank_init(&vkms_device->drm, 1);
if (ret) {
DRM_ERROR("Failed to vblank\n");
- goto out_fini;
+ goto out_unregister;
}
ret = vkms_modeset_init(vkms_device);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/vkms: Fix the error handling in vkms_init()
2018-08-02 9:04 ` Wei Yongjun
(?)
@ 2018-08-03 0:08 ` Rodrigo Siqueira
-1 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira @ 2018-08-03 0:08 UTC (permalink / raw)
To: Wei Yongjun
Cc: David Airlie, Daniel Vetter, Gustavo Padovan, Haneen Mohammed,
dri-devel, linux-kernel, kernel-janitors
On 08/02, Wei Yongjun wrote:
> In the drm_vblank_init() error handling case, platform device
> unregister is missing. This patch fix it.
>
> Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 6e728b8..5ad09d4 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -110,7 +110,7 @@ static int __init vkms_init(void)
> ret = drm_vblank_init(&vkms_device->drm, 1);
> if (ret) {
> DRM_ERROR("Failed to vblank\n");
> - goto out_fini;
> + goto out_unregister;
> }
>
> ret = vkms_modeset_init(vkms_device);
>
Hi,
Thanks for the patch! Everything is fine for me.
Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/vkms: Fix the error handling in vkms_init()
@ 2018-08-03 0:08 ` Rodrigo Siqueira
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira @ 2018-08-03 0:08 UTC (permalink / raw)
To: Wei Yongjun
Cc: Haneen Mohammed, David Airlie, Daniel Vetter, kernel-janitors,
linux-kernel, dri-devel, Gustavo Padovan
On 08/02, Wei Yongjun wrote:
> In the drm_vblank_init() error handling case, platform device
> unregister is missing. This patch fix it.
>
> Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 6e728b8..5ad09d4 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -110,7 +110,7 @@ static int __init vkms_init(void)
> ret = drm_vblank_init(&vkms_device->drm, 1);
> if (ret) {
> DRM_ERROR("Failed to vblank\n");
> - goto out_fini;
> + goto out_unregister;
> }
>
> ret = vkms_modeset_init(vkms_device);
>
Hi,
Thanks for the patch! Everything is fine for me.
Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] drm/vkms: Fix the error handling in vkms_init()
@ 2018-08-03 0:08 ` Rodrigo Siqueira
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Siqueira @ 2018-08-03 0:08 UTC (permalink / raw)
To: Wei Yongjun
Cc: Haneen Mohammed, David Airlie, Daniel Vetter, kernel-janitors,
linux-kernel, dri-devel, Gustavo Padovan
On 08/02, Wei Yongjun wrote:
> In the drm_vblank_init() error handling case, platform device
> unregister is missing. This patch fix it.
>
> Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 6e728b8..5ad09d4 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -110,7 +110,7 @@ static int __init vkms_init(void)
> ret = drm_vblank_init(&vkms_device->drm, 1);
> if (ret) {
> DRM_ERROR("Failed to vblank\n");
> - goto out_fini;
> + goto out_unregister;
> }
>
> ret = vkms_modeset_init(vkms_device);
>
Hi,
Thanks for the patch! Everything is fine for me.
Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-03 0:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-02 8:57 [PATCH -next] drm/vkms: Fix the error handling in vkms_init() Wei Yongjun
2018-08-02 9:04 ` Wei Yongjun
2018-08-02 9:04 ` Wei Yongjun
2018-08-03 0:08 ` Rodrigo Siqueira
2018-08-03 0:08 ` Rodrigo Siqueira
2018-08-03 0:08 ` Rodrigo Siqueira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.