From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7BF7C43142 for ; Thu, 2 Aug 2018 10:18:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7988E21501 for ; Thu, 2 Aug 2018 10:18:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7988E21501 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731362AbeHBMIb (ORCPT ); Thu, 2 Aug 2018 08:08:31 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:48637 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726977AbeHBMIb (ORCPT ); Thu, 2 Aug 2018 08:08:31 -0400 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1flAg7-0003BA-A9; Thu, 02 Aug 2018 12:17:55 +0200 Message-ID: <1533205073.3516.17.camel@pengutronix.de> Subject: Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block From: Philipp Zabel To: Leonard Crestez , "stefan@agner.ch" , "marex@denx.de" , "shawnguo@kernel.org" Cc: Anson Huang , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Fabio Estevam , dl-linux-imx , "kernel@pengutronix.de" , Robert Chiras , "l.stach@pengutronix.de" Date: Thu, 02 Aug 2018 12:17:53 +0200 In-Reply-To: References: <1533038097.3444.13.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-07-31 at 12:17 +0000, Leonard Crestez wrote: > On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: > > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > > > Adding lcdif nodes to a power domain currently does work, it results in > > > black/corrupted screens or hangs. While the driver does enable runtime > > > pm it does not deal correctly with the block being unpowered. > > > > > > Ensure power is on when required by adding pm_runtime_get/put_sync to > > > mxsfb_pipe_enable/disable. > > > > > > Since power is lost on suspend implement PM_SLEEP_OPS using > > > drm_mode_config_helper_suspend/resume. > > > > > > The mxsfb_plane_atomic_update function can get called before > > > mxsfb_pipe_enable while the block is not yet powered. When this happens > > > the write to LCDIF_NEXT_BUF is lost causing corrupt display on unblank > > > until a refresh. > > > > Why does this happen? > > I'm not sure what you're asking but register writes to unpowered or > unclocked blocks are not expected to "just work". Here the write is > ignored/lost but I think on imx8 it can even cause a bus error. > > The approach here is to only set the framebuffer address as part of > activating the display. I wonder why atomic update is called at all while the pipe is not enabled. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block Date: Thu, 02 Aug 2018 12:17:53 +0200 Message-ID: <1533205073.3516.17.camel@pengutronix.de> References: <1533038097.3444.13.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7763F6E587 for ; Thu, 2 Aug 2018 10:18:03 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Leonard Crestez , "stefan@agner.ch" , "marex@denx.de" , "shawnguo@kernel.org" Cc: Anson Huang , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Robert Chiras , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDE4LTA3LTMxIGF0IDEyOjE3ICswMDAwLCBMZW9uYXJkIENyZXN0ZXogd3JvdGU6 Cj4gT24gVHVlLCAyMDE4LTA3LTMxIGF0IDEzOjU0ICswMjAwLCBQaGlsaXBwIFphYmVsIHdyb3Rl Ogo+ID4gT24gVHVlLCAyMDE4LTA3LTE3IGF0IDEzOjQ4ICswMzAwLCBMZW9uYXJkIENyZXN0ZXog d3JvdGU6Cj4gPiA+IEFkZGluZyBsY2RpZiBub2RlcyB0byBhIHBvd2VyIGRvbWFpbiBjdXJyZW50 bHkgZG9lcyB3b3JrLCBpdCByZXN1bHRzIGluCj4gPiA+IGJsYWNrL2NvcnJ1cHRlZCBzY3JlZW5z IG9yIGhhbmdzLiBXaGlsZSB0aGUgZHJpdmVyIGRvZXMgZW5hYmxlIHJ1bnRpbWUKPiA+ID4gcG0g aXQgZG9lcyBub3QgZGVhbCBjb3JyZWN0bHkgd2l0aCB0aGUgYmxvY2sgYmVpbmcgdW5wb3dlcmVk Lgo+ID4gPiAKPiA+ID4gRW5zdXJlIHBvd2VyIGlzIG9uIHdoZW4gcmVxdWlyZWQgYnkgYWRkaW5n IHBtX3J1bnRpbWVfZ2V0L3B1dF9zeW5jIHRvCj4gPiA+IG14c2ZiX3BpcGVfZW5hYmxlL2Rpc2Fi bGUuCj4gPiA+IAo+ID4gPiBTaW5jZSBwb3dlciBpcyBsb3N0IG9uIHN1c3BlbmQgaW1wbGVtZW50 IFBNX1NMRUVQX09QUyB1c2luZwo+ID4gPiBkcm1fbW9kZV9jb25maWdfaGVscGVyX3N1c3BlbmQv cmVzdW1lLgo+ID4gPiAKPiA+ID4gVGhlIG14c2ZiX3BsYW5lX2F0b21pY191cGRhdGUgZnVuY3Rp b24gY2FuIGdldCBjYWxsZWQgYmVmb3JlCj4gPiA+IG14c2ZiX3BpcGVfZW5hYmxlIHdoaWxlIHRo ZSBibG9jayBpcyBub3QgeWV0IHBvd2VyZWQuIFdoZW4gdGhpcyBoYXBwZW5zCj4gPiA+IHRoZSB3 cml0ZSB0byBMQ0RJRl9ORVhUX0JVRiBpcyBsb3N0IGNhdXNpbmcgY29ycnVwdCBkaXNwbGF5IG9u IHVuYmxhbmsKPiA+ID4gdW50aWwgYSByZWZyZXNoLgo+ID4gCj4gPiBXaHkgZG9lcyB0aGlzIGhh cHBlbj8KPiAKPiBJJ20gbm90IHN1cmUgd2hhdCB5b3UncmUgYXNraW5nIGJ1dCByZWdpc3RlciB3 cml0ZXMgdG8gdW5wb3dlcmVkIG9yCj4gdW5jbG9ja2VkIGJsb2NrcyBhcmUgbm90IGV4cGVjdGVk IHRvICJqdXN0IHdvcmsiLiBIZXJlIHRoZSB3cml0ZSBpcwo+IGlnbm9yZWQvbG9zdCBidXQgSSB0 aGluayBvbiBpbXg4IGl0IGNhbiBldmVuIGNhdXNlIGEgYnVzIGVycm9yLgo+IAo+IFRoZSBhcHBy b2FjaCBoZXJlIGlzIHRvIG9ubHkgc2V0IHRoZSBmcmFtZWJ1ZmZlciBhZGRyZXNzIGFzIHBhcnQg b2YKPiBhY3RpdmF0aW5nIHRoZSBkaXNwbGF5LgoKSSB3b25kZXIgd2h5IGF0b21pYyB1cGRhdGUg aXMgY2FsbGVkIGF0IGFsbCB3aGlsZSB0aGUgcGlwZSBpcyBub3QKZW5hYmxlZC4KCnJlZ2FyZHMK UGhpbGlwcApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK