From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915: Drop stray clearing of rps->last_adj
Date: Thu, 02 Aug 2018 21:26:48 +0100 [thread overview]
Message-ID: <153324160806.23498.4019231073304287228@skylake-alporthouse-com> (raw)
In-Reply-To: <878t5og50v.fsf@gaia.fi.intel.com>
Quoting Mika Kuoppala (2018-08-02 16:30:24)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > We used to reset last_adj to 0 on crossing a power domain boundary, to
> > slow down our rate of change. However, commit 60548c554be2 ("drm/i915:
> > Interactive RPS mode") accidentally caused it to be reset on every
> > frequency update, nerfing the fast response granted by the slow start
> > algorithm.
> >
> > Fixes: 60548c554be2 ("drm/i915: Interactive RPS mode")
> > Testcase: igt/pm_rps/mix-max-config-loaded
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Plonked this one as fixes the regression. 2&3 are nice cleanups, 4 seems
like an unlikely boundary case, but I suspect kodi might be a good
example.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-08-02 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 10:06 [PATCH 1/4] drm/i915: Drop stray clearing of rps->last_adj Chris Wilson
2018-08-02 10:06 ` [PATCH 2/4] drm/i915: Unconditionally clear the pm/guc GT IIR upon acking Chris Wilson
2018-08-03 13:56 ` Mika Kuoppala
2018-08-03 14:19 ` Chris Wilson
2018-08-02 10:06 ` [PATCH 3/4] drm/i915: Clear all residual RPS events on disabling interrupts Chris Wilson
2018-08-03 13:59 ` Mika Kuoppala
2018-08-03 14:13 ` Chris Wilson
2018-08-02 10:06 ` [PATCH 4/4] drm/i915: Dampen RPS slow start Chris Wilson
2018-08-02 10:44 ` ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Drop stray clearing of rps->last_adj Patchwork
2018-08-02 11:34 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-02 15:30 ` [PATCH 1/4] " Mika Kuoppala
2018-08-02 20:26 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153324160806.23498.4019231073304287228@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.