From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E584DC28CF6 for ; Fri, 3 Aug 2018 05:13:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95D7B208DA for ; Fri, 3 Aug 2018 05:13:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95D7B208DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727473AbeHCHIC (ORCPT ); Fri, 3 Aug 2018 03:08:02 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:25463 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726679AbeHCHIC (ORCPT ); Fri, 3 Aug 2018 03:08:02 -0400 X-UUID: f763aa65407a4abea4d74c0b0a907812-20180803 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 646522891; Fri, 03 Aug 2018 13:13:24 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 3 Aug 2018 13:13:22 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Fri, 3 Aug 2018 13:13:22 +0800 Message-ID: <1533273202.31144.8.camel@mtksdaap41> Subject: Re: [PATCH v2 12/15] drm/mediatek: add callback function to return RDMA layer number From: CK Hu To: Stu Hsieh CC: Philipp Zabel , David Airlie , Matthias Brugger , , , , , Date: Fri, 3 Aug 2018 13:13:22 +0800 In-Reply-To: <1533265868-28110-13-git-send-email-stu.hsieh@mediatek.com> References: <1533265868-28110-1-git-send-email-stu.hsieh@mediatek.com> <1533265868-28110-13-git-send-email-stu.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Stu: On Fri, 2018-08-03 at 11:11 +0800, Stu Hsieh wrote: > This patch add callback function to return RDMA layer number > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > index b728f0f42611..8c145a87c9e5 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > @@ -60,6 +60,7 @@ > > struct mtk_disp_rdma_data { > unsigned int fifo_size; > + unsigned int layer_nr; > }; > > /** > @@ -194,6 +195,13 @@ static unsigned int rdma_fmt_convert(struct mtk_disp_rdma *rdma, > } > } > > +static unsigned int mtk_rdma_layer_nr(struct mtk_ddp_comp *comp) > +{ > + struct mtk_disp_rdma *rdma = comp_to_rdma(comp); > + > + return rdma->data->layer_nr; Maybe RDMA always has one layer, so you could just return 1 here. Regards, CK > +} > + > static void mtk_rdma_layer_config(struct mtk_ddp_comp *comp, unsigned int idx, > struct mtk_plane_state *state) > { > @@ -227,6 +235,7 @@ static const struct mtk_ddp_comp_funcs mtk_disp_rdma_funcs = { > .stop = mtk_rdma_stop, > .enable_vblank = mtk_rdma_enable_vblank, > .disable_vblank = mtk_rdma_disable_vblank, > + .layer_nr = mtk_rdma_layer_nr, > .layer_config = mtk_rdma_layer_config, > }; > > @@ -329,6 +338,7 @@ static const struct mtk_disp_rdma_data mt2701_rdma_driver_data = { > > static const struct mtk_disp_rdma_data mt8173_rdma_driver_data = { > .fifo_size = SZ_8K, > + .layer_nr = 1, > }; > > static const struct of_device_id mtk_disp_rdma_driver_dt_match[] = { From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH v2 12/15] drm/mediatek: add callback function to return RDMA layer number Date: Fri, 3 Aug 2018 13:13:22 +0800 Message-ID: <1533273202.31144.8.camel@mtksdaap41> References: <1533265868-28110-1-git-send-email-stu.hsieh@mediatek.com> <1533265868-28110-13-git-send-email-stu.hsieh@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1533265868-28110-13-git-send-email-stu.hsieh@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stu Hsieh Cc: srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIFN0dToKCk9uIEZyaSwgMjAxOC0wOC0wMyBhdCAxMToxMSArMDgwMCwgU3R1IEhzaWVoIHdy b3RlOgo+IFRoaXMgcGF0Y2ggYWRkIGNhbGxiYWNrIGZ1bmN0aW9uIHRvIHJldHVybiBSRE1BIGxh eWVyIG51bWJlcgo+IAo+IFNpZ25lZC1vZmYtYnk6IFN0dSBIc2llaCA8c3R1LmhzaWVoQG1lZGlh dGVrLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNwX3JkbWEu YyB8IDEwICsrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKykKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kaXNwX3JkbWEuYyBi L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZGlzcF9yZG1hLmMKPiBpbmRleCBiNzI4ZjBm NDI2MTEuLjhjMTQ1YTg3YzllNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0 ZWsvbXRrX2Rpc3BfcmRtYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19k aXNwX3JkbWEuYwo+IEBAIC02MCw2ICs2MCw3IEBACj4gIAo+ICBzdHJ1Y3QgbXRrX2Rpc3BfcmRt YV9kYXRhIHsKPiAgCXVuc2lnbmVkIGludCBmaWZvX3NpemU7Cj4gKwl1bnNpZ25lZCBpbnQgbGF5 ZXJfbnI7Cj4gIH07Cj4gIAo+ICAvKioKPiBAQCAtMTk0LDYgKzE5NSwxMyBAQCBzdGF0aWMgdW5z aWduZWQgaW50IHJkbWFfZm10X2NvbnZlcnQoc3RydWN0IG10a19kaXNwX3JkbWEgKnJkbWEsCj4g IAl9Cj4gIH0KPiAgCj4gK3N0YXRpYyB1bnNpZ25lZCBpbnQgbXRrX3JkbWFfbGF5ZXJfbnIoc3Ry dWN0IG10a19kZHBfY29tcCAqY29tcCkKPiArewo+ICsJc3RydWN0IG10a19kaXNwX3JkbWEgKnJk bWEgPSBjb21wX3RvX3JkbWEoY29tcCk7Cj4gKwo+ICsJcmV0dXJuIHJkbWEtPmRhdGEtPmxheWVy X25yOwoKTWF5YmUgUkRNQSBhbHdheXMgaGFzIG9uZSBsYXllciwgc28geW91IGNvdWxkIGp1c3Qg cmV0dXJuIDEgaGVyZS4KClJlZ2FyZHMsCkNLCgo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBtdGtf cmRtYV9sYXllcl9jb25maWcoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCwgdW5zaWduZWQgaW50 IGlkeCwKPiAgCQkJCSAgc3RydWN0IG10a19wbGFuZV9zdGF0ZSAqc3RhdGUpCj4gIHsKPiBAQCAt MjI3LDYgKzIzNSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgbXRrX2RkcF9jb21wX2Z1bmNzIG10 a19kaXNwX3JkbWFfZnVuY3MgPSB7Cj4gIAkuc3RvcCA9IG10a19yZG1hX3N0b3AsCj4gIAkuZW5h YmxlX3ZibGFuayA9IG10a19yZG1hX2VuYWJsZV92YmxhbmssCj4gIAkuZGlzYWJsZV92Ymxhbmsg PSBtdGtfcmRtYV9kaXNhYmxlX3ZibGFuaywKPiArCS5sYXllcl9uciA9IG10a19yZG1hX2xheWVy X25yLAo+ICAJLmxheWVyX2NvbmZpZyA9IG10a19yZG1hX2xheWVyX2NvbmZpZywKPiAgfTsKPiAg Cj4gQEAgLTMyOSw2ICszMzgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG10a19kaXNwX3JkbWFf ZGF0YSBtdDI3MDFfcmRtYV9kcml2ZXJfZGF0YSA9IHsKPiAgCj4gIHN0YXRpYyBjb25zdCBzdHJ1 Y3QgbXRrX2Rpc3BfcmRtYV9kYXRhIG10ODE3M19yZG1hX2RyaXZlcl9kYXRhID0gewo+ICAJLmZp Zm9fc2l6ZSA9IFNaXzhLLAo+ICsJLmxheWVyX25yID0gMSwKPiAgfTsKPiAgCj4gIHN0YXRpYyBj b25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIG10a19kaXNwX3JkbWFfZHJpdmVyX2R0X21hdGNoW10g PSB7CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Fri, 3 Aug 2018 13:13:22 +0800 Subject: [PATCH v2 12/15] drm/mediatek: add callback function to return RDMA layer number In-Reply-To: <1533265868-28110-13-git-send-email-stu.hsieh@mediatek.com> References: <1533265868-28110-1-git-send-email-stu.hsieh@mediatek.com> <1533265868-28110-13-git-send-email-stu.hsieh@mediatek.com> Message-ID: <1533273202.31144.8.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Stu: On Fri, 2018-08-03 at 11:11 +0800, Stu Hsieh wrote: > This patch add callback function to return RDMA layer number > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > index b728f0f42611..8c145a87c9e5 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > @@ -60,6 +60,7 @@ > > struct mtk_disp_rdma_data { > unsigned int fifo_size; > + unsigned int layer_nr; > }; > > /** > @@ -194,6 +195,13 @@ static unsigned int rdma_fmt_convert(struct mtk_disp_rdma *rdma, > } > } > > +static unsigned int mtk_rdma_layer_nr(struct mtk_ddp_comp *comp) > +{ > + struct mtk_disp_rdma *rdma = comp_to_rdma(comp); > + > + return rdma->data->layer_nr; Maybe RDMA always has one layer, so you could just return 1 here. Regards, CK > +} > + > static void mtk_rdma_layer_config(struct mtk_ddp_comp *comp, unsigned int idx, > struct mtk_plane_state *state) > { > @@ -227,6 +235,7 @@ static const struct mtk_ddp_comp_funcs mtk_disp_rdma_funcs = { > .stop = mtk_rdma_stop, > .enable_vblank = mtk_rdma_enable_vblank, > .disable_vblank = mtk_rdma_disable_vblank, > + .layer_nr = mtk_rdma_layer_nr, > .layer_config = mtk_rdma_layer_config, > }; > > @@ -329,6 +338,7 @@ static const struct mtk_disp_rdma_data mt2701_rdma_driver_data = { > > static const struct mtk_disp_rdma_data mt8173_rdma_driver_data = { > .fifo_size = SZ_8K, > + .layer_nr = 1, > }; > > static const struct of_device_id mtk_disp_rdma_driver_dt_match[] = {