From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin <tursulin@ursulin.net>
Subject: Re: [PATCH v4] drm/i915/tracing: Enable user interrupts while intel_engine_notify is active
Date: Thu, 09 Aug 2018 11:04:15 +0100 [thread overview]
Message-ID: <153380905568.11393.6527769185070092426@skylake-alporthouse-com> (raw)
In-Reply-To: <20180809100128.3224-1-tvrtko.ursulin@linux.intel.com>
Quoting Tvrtko Ursulin (2018-08-09 11:01:28)
> +#if IS_ENABLED(CONFIG_TRACEPOINTS)
> +
> +void i915_tracing_register(struct drm_i915_private *i915);
> +void i915_tracing_unregister(struct drm_i915_private *i915);
> +
> +int intel_engine_notify_tracepoint_register(void);
> +void intel_engine_notify_tracepoint_unregister(void);
> +
> +#else
> +
> +static inline void i915_tracing_register(struct drm_i915_private *i915) { }
> +static inline void i915_tracing_unregister(struct drm_i915_private *i915) { }
> +
> +static inline int intel_engine_notify_tracepoint_register(void) { }
I was blind, return 0;
Better keep the compiler happy before kbuild complains.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-08-09 10:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 15:14 [PATCH v2] drm/i915/tracing: Enable user interrupts while intel_engine_notify is active Tvrtko Ursulin
2018-08-08 15:20 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-08-08 15:34 ` [PATCH v2] " Chris Wilson
2018-08-09 9:07 ` [PATCH v3] " Tvrtko Ursulin
2018-08-09 9:09 ` Tvrtko Ursulin
2018-08-09 9:22 ` Chris Wilson
2018-08-09 9:31 ` Tvrtko Ursulin
2018-08-09 10:01 ` [PATCH v4] " Tvrtko Ursulin
2018-08-09 10:04 ` Chris Wilson [this message]
2018-08-09 10:12 ` [PATCH v5] " Tvrtko Ursulin
2018-08-11 22:39 ` [PATCH v4] " kbuild test robot
2018-08-11 22:47 ` kbuild test robot
2018-08-09 9:29 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tracing: Enable user interrupts while intel_engine_notify is active (rev2) Patchwork
2018-08-09 9:30 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-08-09 9:46 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-09 10:12 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tracing: Enable user interrupts while intel_engine_notify is active (rev3) Patchwork
2018-08-09 10:13 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-08-09 10:29 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-09 10:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/tracing: Enable user interrupts while intel_engine_notify is active (rev4) Patchwork
2018-08-09 10:34 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-08-09 10:51 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-09 11:41 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153380905568.11393.6527769185070092426@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.